linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Latypov <dlatypov@google.com>
To: brendanhiggins@google.com, davidgow@google.com
Cc: elver@google.com, linux-kernel@vger.kernel.org,
	kasan-dev@googlegroups.com, kunit-dev@googlegroups.com,
	linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
	Daniel Latypov <dlatypov@google.com>
Subject: [PATCH 0/3] kunit: add support in kunit.py for --qemu_args
Date: Wed, 18 May 2022 10:01:21 -0700	[thread overview]
Message-ID: <20220518170124.2849497-1-dlatypov@google.com> (raw)

Note: this series applies on top of
https://lore.kernel.org/linux-kselftest/20220516194730.1546328-2-dlatypov@google.com/.
That patch greatly simplified the process of adding new flags.

This flag would let users pass additional arguments to QEMU when using a
non-UML arch to run their tests.
E.g. for kcsan's tests, they require SMP and with this patch, you can do
$ ./tools/testing/kunit/kunit.py run --kconfig_add=CONFIG_SMP --qemu_args='-smp 8'

This is proposed as an alternative to users manually creating new
qemu_config python files and also to [1], where we discussed checking in
a new x86_64 variant w/ `-smp 8` hard-coded into it.

This patch also contains a fix to the example `run_kunit` bash function
since it didn't quote properly and would parse the example above as
  --qemu_args='-smp' '8'
no matter how you tried to quote your arguments.

[1] https://lore.kernel.org/linux-kselftest/20220518073232.526443-1-davidgow@google.com/

Daniel Latypov (3):
  Documentation: kunit: fix example run_kunit func to allow spaces in
    args
  kunit: tool: simplify creating LinuxSourceTreeOperations
  kunit: tool: introduce --qemu_args

 .../dev-tools/kunit/running_tips.rst          |  2 +-
 tools/testing/kunit/kunit.py                  | 14 +++++++++-
 tools/testing/kunit/kunit_kernel.py           | 26 +++++++++++--------
 tools/testing/kunit/kunit_tool_test.py        | 20 +++++++++++---
 4 files changed, 46 insertions(+), 16 deletions(-)

-- 
2.36.1.124.g0e6072fb45-goog


             reply	other threads:[~2022-05-18 17:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 17:01 Daniel Latypov [this message]
2022-05-18 17:01 ` [PATCH 1/3] Documentation: kunit: fix example run_kunit func to allow spaces in args Daniel Latypov
2022-05-19 13:20   ` David Gow
2022-07-06 18:34   ` Brendan Higgins
2022-05-18 17:01 ` [PATCH 2/3] kunit: tool: simplify creating LinuxSourceTreeOperations Daniel Latypov
2022-05-19 13:20   ` David Gow
2022-07-06 20:06   ` Brendan Higgins
2022-05-18 17:01 ` [PATCH 3/3] kunit: tool: introduce --qemu_args Daniel Latypov
2022-05-19 13:20   ` David Gow
2022-07-06 20:11   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518170124.2849497-1-dlatypov@google.com \
    --to=dlatypov@google.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).