From: Daniel Latypov <dlatypov@google.com>
To: brendanhiggins@google.com, davidgow@google.com
Cc: elver@google.com, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
Daniel Latypov <dlatypov@google.com>
Subject: [PATCH 1/3] Documentation: kunit: fix example run_kunit func to allow spaces in args
Date: Wed, 18 May 2022 10:01:22 -0700 [thread overview]
Message-ID: <20220518170124.2849497-2-dlatypov@google.com> (raw)
In-Reply-To: <20220518170124.2849497-1-dlatypov@google.com>
Without the quoting, the example will mess up invocations like
$ run_kunit "Something with spaces"
Note: this example isn't valid, but if ever a usecase arises where a
flag argument might have spaces in it, it'll break.
Signed-off-by: Daniel Latypov <dlatypov@google.com>
---
Documentation/dev-tools/kunit/running_tips.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst
index c36f6760087d..da8677c32aee 100644
--- a/Documentation/dev-tools/kunit/running_tips.rst
+++ b/Documentation/dev-tools/kunit/running_tips.rst
@@ -15,7 +15,7 @@ It can be handy to create a bash function like:
.. code-block:: bash
function run_kunit() {
- ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run $@ )
+ ( cd "$(git rev-parse --show-toplevel)" && ./tools/testing/kunit/kunit.py run "$@" )
}
.. note::
--
2.36.1.124.g0e6072fb45-goog
next prev parent reply other threads:[~2022-05-18 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:01 [PATCH 0/3] kunit: add support in kunit.py for --qemu_args Daniel Latypov
2022-05-18 17:01 ` Daniel Latypov [this message]
2022-05-19 13:20 ` [PATCH 1/3] Documentation: kunit: fix example run_kunit func to allow spaces in args David Gow
2022-07-06 18:34 ` Brendan Higgins
2022-05-18 17:01 ` [PATCH 2/3] kunit: tool: simplify creating LinuxSourceTreeOperations Daniel Latypov
2022-05-19 13:20 ` David Gow
2022-07-06 20:06 ` Brendan Higgins
2022-05-18 17:01 ` [PATCH 3/3] kunit: tool: introduce --qemu_args Daniel Latypov
2022-05-19 13:20 ` David Gow
2022-07-06 20:11 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518170124.2849497-2-dlatypov@google.com \
--to=dlatypov@google.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).