* [PATCH] x86/events/intel/ds: Enable large PEBS for PERF_SAMPLE_WEIGHT type
@ 2022-05-19 10:45 Like Xu
2022-05-19 14:26 ` Liang, Kan
0 siblings, 1 reply; 2+ messages in thread
From: Like Xu @ 2022-05-19 10:45 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Kan Liang, Stephane Eranian, Jiri Olsa, Namhyung Kim,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
linux-perf-users, linux-kernel
From: Like Xu <likexu@tencent.com>
Large PEBS could be enabled for the generic PERF_SAMPLE_WEIGHT sample
type until other non-compatible flags such as PERF_SAMPLE_DATA_PAGE_SIZE
(due to lack of munmap tracking) finally stop it.
Add PERF_SAMPLE_WEIGHT to LARGE_PEBS_FLAGS to save PMIs overhead.
Tested it with:
$ perf mem record -c 1000 workload
Before: Captured and wrote 0.126 MB perf.data (958 samples) [958 PMIs]
After: Captured and wrote 0.313 MB perf.data (4859 samples) [3 PMIs]
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Reported-by: Yongchao Duan <yongduan@tencent.com>
Signed-off-by: Like Xu <likexu@tencent.com>
---
arch/x86/events/perf_event.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h
index 21a5482bcf84..1ed0970d67e6 100644
--- a/arch/x86/events/perf_event.h
+++ b/arch/x86/events/perf_event.h
@@ -136,7 +136,8 @@ struct amd_nb {
PERF_SAMPLE_DATA_SRC | PERF_SAMPLE_IDENTIFIER | \
PERF_SAMPLE_TRANSACTION | PERF_SAMPLE_PHYS_ADDR | \
PERF_SAMPLE_REGS_INTR | PERF_SAMPLE_REGS_USER | \
- PERF_SAMPLE_PERIOD | PERF_SAMPLE_CODE_PAGE_SIZE)
+ PERF_SAMPLE_PERIOD | PERF_SAMPLE_CODE_PAGE_SIZE | \
+ PERF_SAMPLE_WEIGHT)
#define PEBS_GP_REGS \
((1ULL << PERF_REG_X86_AX) | \
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/events/intel/ds: Enable large PEBS for PERF_SAMPLE_WEIGHT type
2022-05-19 10:45 [PATCH] x86/events/intel/ds: Enable large PEBS for PERF_SAMPLE_WEIGHT type Like Xu
@ 2022-05-19 14:26 ` Liang, Kan
0 siblings, 0 replies; 2+ messages in thread
From: Liang, Kan @ 2022-05-19 14:26 UTC (permalink / raw)
To: Like Xu, Peter Zijlstra
Cc: Stephane Eranian, Jiri Olsa, Namhyung Kim,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
linux-perf-users, linux-kernel
On 5/19/2022 6:45 AM, Like Xu wrote:
> From: Like Xu <likexu@tencent.com>
>
> Large PEBS could be enabled for the generic PERF_SAMPLE_WEIGHT sample
I think all the information required by the PERF_SAMPLE_WEIGHT is
available in the pebs record. It should be OK to enable it for the large
PEBS.
Can you please use the PERF_SAMPLE_WEIGHT_TYPE instead? It includes the
new weight extension.
Thanks,
Kan
> type until other non-compatible flags such as PERF_SAMPLE_DATA_PAGE_SIZE
> (due to lack of munmap tracking) finally stop it.
>
> Add PERF_SAMPLE_WEIGHT to LARGE_PEBS_FLAGS to save PMIs overhead.
>
> Tested it with:
>
> $ perf mem record -c 1000 workload
> Before: Captured and wrote 0.126 MB perf.data (958 samples) [958 PMIs]
> After: Captured and wrote 0.313 MB perf.data (4859 samples) [3 PMIs]
>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Reported-by: Yongchao Duan <yongduan@tencent.com>
> Signed-off-by: Like Xu <likexu@tencent.com>
> ---
> arch/x86/events/perf_event.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h
> index 21a5482bcf84..1ed0970d67e6 100644
> --- a/arch/x86/events/perf_event.h
> +++ b/arch/x86/events/perf_event.h
> @@ -136,7 +136,8 @@ struct amd_nb {
> PERF_SAMPLE_DATA_SRC | PERF_SAMPLE_IDENTIFIER | \
> PERF_SAMPLE_TRANSACTION | PERF_SAMPLE_PHYS_ADDR | \
> PERF_SAMPLE_REGS_INTR | PERF_SAMPLE_REGS_USER | \
> - PERF_SAMPLE_PERIOD | PERF_SAMPLE_CODE_PAGE_SIZE)
> + PERF_SAMPLE_PERIOD | PERF_SAMPLE_CODE_PAGE_SIZE | \
> + PERF_SAMPLE_WEIGHT)
>
> #define PEBS_GP_REGS \
> ((1ULL << PERF_REG_X86_AX) | \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 10:45 [PATCH] x86/events/intel/ds: Enable large PEBS for PERF_SAMPLE_WEIGHT type Like Xu
2022-05-19 14:26 ` Liang, Kan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).