From: Serge Semin <fancer.lancer@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 12/23] dt-bindings: ata: ahci: Add platform capability properties
Date: Sun, 22 May 2022 20:43:34 +0300 [thread overview]
Message-ID: <20220522174334.cnguiyl7u3nhe7mm@mobilestation> (raw)
In-Reply-To: <20220517192028.GA1453662-robh@kernel.org>
On Tue, May 17, 2022 at 02:20:28PM -0500, Rob Herring wrote:
> On Thu, May 12, 2022 at 02:17:59AM +0300, Serge Semin wrote:
> > In case if the platform doesn't have BIOS or a comprehensive firmware
> > installed then the HBA capability flags will be left uninitialized. As a
> > good alternative we can define a set AHCI DT-node properties to describe
> > all of HW-init capabilities flags. Luckily there aren't too many of them.
> > SSS - Staggered Spin-up support and MPS - Mechanical Presence Switch
> > support determine the corresponding feature availability for whole HBA by
> > means of the "hba-sss" and "hba-smps" properties. Each port can have the
> > "hba-{hpcp,mpsp,cpd,esp,fbscp}" defined indicatating that the port
> > supports the next functionality: HPCP - HotPlug capable port, MPSP -
> > Mechanical Presence Switch attached to a port, CPD - Cold Plug detection,
> > ESP - External SATA Port (eSATA), FBSCP - FIS-based switching capable
> > port.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > ---
> >
> > Alternatively we could define them as a bitfield, but having a set of
> > boolean properties seemed a better idea since in that case we can
> > implement a simple inter-dependency rules for them, which can't be done
> > should we take the bitfields path.
>
> I would just provide a CAP register override and be done with it.
>
> The boolean fields only let you set a capability, but not unset one.
> They would need to be tristate.
Ok. I'll convert the boolean properties to the generic (hba-cap) and
per-port (hba-port-cap) properties with CAP-override fields.
-Sergey
>
> > ---
> > .../devicetree/bindings/ata/ahci-common.yaml | 66 +++++++++++++++++++
> > .../bindings/ata/ahci-platform.yaml | 11 ++++
> > 2 files changed, 77 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-common.yaml b/Documentation/devicetree/bindings/ata/ahci-common.yaml
> > index a7d1a8353de3..a29edfbb25db 100644
> > --- a/Documentation/devicetree/bindings/ata/ahci-common.yaml
> > +++ b/Documentation/devicetree/bindings/ata/ahci-common.yaml
> > @@ -75,6 +75,19 @@ properties:
> > phy-names:
> > const: sata-phy
> >
> > + hba-sss:
> > + type: boolean
> > + description:
> > + Staggered Spin-up Support. Indicates whether the HBA supports the
> > + staggered spin-up on its ports, for use in balancing power spikes.
> > +
> > + hba-smps:
> > + type: boolean
> > + description:
> > + Mechanical Presence Switch Support. Indicates whether the HBA supports
> > + mechanical presence switches on its ports for use in hot plug
> > + operations.
> > +
> > ports-implemented:
> > $ref: '/schemas/types.yaml#/definitions/uint32'
> > description:
> > @@ -97,6 +110,40 @@ patternProperties:
> > minimum: 0
> > maximum: 31
> >
> > + hba-hpcp:
> > + type: boolean
> > + description:
> > + Hot Plug Capable Port. Indicates that this port’s signal and power
> > + connectors are externally accessible via a joint signal and power
> > + connector for blindmate device hot plug. It is mutually exclusive
> > + with the ESP feature.
> > +
> > + hba-mpsp:
> > + type: boolean
> > + description:
> > + Mechanical Presence Switch Attached to Port. Indicates whether
> > + the platform an mechanical presence switch attached to this
> > + port.
> > +
> > + hba-cpd:
> > + type: boolean
> > + description:
> > + Cold Presence Detection. Indicates whether the platform supports
> > + cold presence detection on this port.
> > +
> > + hba-esp:
> > + type: boolean
> > + description:
> > + External SATA Port. Indicates that this port’s signal connector
> > + is externally accessible on a signal only connector (e.g. eSATA
> > + connector).
> > +
> > + hba-fbscp:
> > + type: boolean
> > + description:
> > + FIS-based Switching Capable Port. Indicates whether this port
> > + supports Port Multiplier FIS-based switching.
> > +
> > phys:
> > description: Individual AHCI SATA port PHY
> > maxItems: 1
> > @@ -111,6 +158,25 @@ patternProperties:
> > required:
> > - reg
> >
> > + # eSATA can't be enabled together with the HotPlug capability
> > + oneOf:
> > + - required:
> > + - hba-hpcp
> > + - required:
> > + - hba-esp
> > + - not:
> > + anyOf:
> > + - required:
> > + - hba-hpcp
> > + - required:
> > + - hba-esp
> > +
> > + # HotPlug capability must be enabled together with Cold Plug
> > + # Detection and Mechanical Presence Switching.
> > + dependencies:
> > + hba-cpd: ["hba-hpcp"]
> > + hba-mpsp: ["hba-hpcp"]
> > +
> > additionalProperties: true
> >
> > required:
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > index 76075d3c8987..6cad7e86f3bb 100644
> > --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > @@ -117,14 +117,25 @@ examples:
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > + hba-smps;
> > +
> > sata0: sata-port@0 {
> > reg = <0>;
> > +
> > + hba-fbscp;
> > + hba-esp;
> > +
> > phys = <&sata_phy 0>;
> > target-supply = <®_sata0>;
> > };
> >
> > sata1: sata-port@1 {
> > reg = <1>;
> > +
> > + hba-fbscp;
> > + hba-hpcp;
> > + hba-mpsp;
> > +
> > phys = <&sata_phy 1>;
> > target-supply = <®_sata1>;
> > };
> > --
> > 2.35.1
> >
> >
next prev parent reply other threads:[~2022-05-22 17:43 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 23:17 [PATCH v3 00/23] ata: ahci: Add DWC/Baikal-T1 AHCI SATA support Serge Semin
2022-05-11 23:17 ` [PATCH v3 01/23] dt-bindings: ata: ahci-platform: Drop dma-coherent property declaration Serge Semin
2022-05-12 6:14 ` Hannes Reinecke
2022-05-17 18:58 ` Rob Herring
2022-05-21 9:22 ` Serge Semin
2022-05-24 14:57 ` Rob Herring
2022-05-25 10:01 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 02/23] dt-bindings: ata: ahci-platform: Detach common AHCI bindings Serge Semin
2022-05-12 6:19 ` Hannes Reinecke
2022-05-12 11:51 ` Serge Semin
2022-05-17 19:10 ` Rob Herring
2022-05-22 15:02 ` Serge Semin
2022-05-24 15:19 ` Rob Herring
2022-05-27 10:10 ` Serge Semin
2022-06-01 0:51 ` Rob Herring
2022-05-11 23:17 ` [PATCH v3 03/23] dt-bindings: ata: ahci-platform: Clarify common AHCI props constraints Serge Semin
2022-05-12 6:21 ` Hannes Reinecke
2022-05-12 12:01 ` Serge Semin
2022-05-12 8:11 ` Sergei Shtylyov
2022-05-12 12:04 ` Serge Semin
2022-05-17 19:14 ` Rob Herring
2022-05-22 15:08 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 04/23] dt-bindings: ata: sata: Extend number of SATA ports Serge Semin
2022-05-12 6:23 ` Hannes Reinecke
2022-05-17 19:15 ` Rob Herring
2022-05-11 23:17 ` [PATCH v3 05/23] ata: libahci_platform: Explicitly set rc on devres_alloc failure Serge Semin
2022-05-12 6:27 ` Hannes Reinecke
2022-05-12 10:32 ` Damien Le Moal
2022-05-12 12:31 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 06/23] ata: libahci_platform: Convert to using platform devm-ioremap methods Serge Semin
2022-05-12 6:31 ` Hannes Reinecke
2022-05-11 23:17 ` [PATCH v3 07/23] ata: libahci_platform: Convert to using devm bulk clocks API Serge Semin
2022-05-12 6:31 ` Hannes Reinecke
2022-05-12 18:32 ` kernel test robot
2022-05-11 23:17 ` [PATCH v3 08/23] ata: libahci_platform: Add function returning a clock-handle by id Serge Semin
2022-05-12 6:32 ` Hannes Reinecke
2022-05-12 14:26 ` Serge Semin
2022-05-13 9:32 ` Damien Le Moal
2022-05-13 13:31 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 09/23] ata: libahci_platform: Sanity check the DT child nodes number Serge Semin
2022-05-12 6:34 ` Hannes Reinecke
2022-05-12 8:24 ` Sergei Shtylyov
2022-05-12 14:40 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 10/23] ata: libahci_platform: Parse ports-implemented property in resources getter Serge Semin
2022-05-12 6:48 ` Hannes Reinecke
2022-05-12 14:31 ` Serge Semin
2022-05-11 23:17 ` [PATCH v3 11/23] ata: libahci_platform: Introduce reset assertion/deassertion methods Serge Semin
2022-05-12 6:54 ` Hannes Reinecke
2022-05-11 23:17 ` [PATCH v3 12/23] dt-bindings: ata: ahci: Add platform capability properties Serge Semin
2022-05-12 6:56 ` Hannes Reinecke
2022-05-17 19:20 ` Rob Herring
2022-05-22 17:43 ` Serge Semin [this message]
2022-05-11 23:18 ` [PATCH v3 13/23] ata: libahci: Extend port-cmd flags set with port capabilities Serge Semin
2022-05-12 6:57 ` Hannes Reinecke
2022-05-12 15:05 ` Serge Semin
2022-05-13 8:22 ` Sergei Shtylyov
2022-05-13 12:13 ` Serge Semin
2022-05-11 23:18 ` [PATCH v3 14/23] ata: libahci: Discard redundant force_port_map parameter Serge Semin
2022-05-12 7:00 ` Hannes Reinecke
2022-05-11 23:18 ` [PATCH v3 15/23] ata: libahci: Don't read AHCI version twice in the save-config method Serge Semin
2022-05-12 7:00 ` Hannes Reinecke
2022-05-11 23:18 ` [PATCH v3 16/23] ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments Serge Semin
2022-05-12 7:08 ` Hannes Reinecke
2022-05-11 23:18 ` [PATCH v3 17/23] ata: ahci: Introduce firmware-specific caps initialization Serge Semin
2022-05-12 7:05 ` Hannes Reinecke
2022-05-12 15:54 ` Serge Semin
2022-05-11 23:18 ` [PATCH v3 18/23] dt-bindings: ata: ahci: Add DWC AHCI SATA controller DT schema Serge Semin
2022-05-12 7:08 ` Hannes Reinecke
2022-05-17 20:04 ` Rob Herring
2022-05-22 17:51 ` Serge Semin
2022-05-11 23:18 ` [PATCH v3 19/23] ata: ahci: Add DWC AHCI SATA controller support Serge Semin
2022-05-12 7:09 ` Hannes Reinecke
2022-05-11 23:18 ` [PATCH v3 20/23] dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema Serge Semin
2022-05-12 7:10 ` Hannes Reinecke
2022-05-17 20:13 ` Rob Herring
2022-05-22 20:49 ` Serge Semin
2022-05-24 15:33 ` Rob Herring
2022-05-27 10:55 ` Serge Semin
2022-05-11 23:18 ` [PATCH v3 21/23] ata: ahci-dwc: Add platform-specific quirks support Serge Semin
2022-05-12 7:12 ` Hannes Reinecke
2022-05-12 16:29 ` Serge Semin
2022-05-14 0:30 ` kernel test robot
2022-05-11 23:18 ` [PATCH v3 22/23] ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support Serge Semin
2022-05-12 7:13 ` Hannes Reinecke
2022-05-11 23:18 ` [PATCH v3 23/23] MAINTAINERS: Add maintainers for DWC AHCI SATA driver Serge Semin
2022-05-12 7:16 ` Hannes Reinecke
2022-05-12 16:47 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220522174334.cnguiyl7u3nhe7mm@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).