* [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups
@ 2022-05-23 6:42 Juerg Haefliger
2022-05-23 6:42 ` [PATCH 1/3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-05-23 6:42 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, linux, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.
While at it, add missing trailing comments to endif statements and replace
tabs before comments with whitespaces (which seems to be more common).
Juerg Haefliger (3):
ARM: s3c: Kconfig: Fix indentation
ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
ARM: s3c: Kconfig.s3c64xx: Fix indentation
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
3 files changed, 27 insertions(+), 29 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: s3c: Kconfig: Fix indentation
2022-05-23 6:42 [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Juerg Haefliger
@ 2022-05-23 6:42 ` Juerg Haefliger
2022-05-23 6:42 ` [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-05-23 6:42 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, linux, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig b/arch/arm/mach-s3c/Kconfig
index 1899fc3f44fd..860df703f696 100644
--- a/arch/arm/mach-s3c/Kconfig
+++ b/arch/arm/mach-s3c/Kconfig
@@ -43,12 +43,12 @@ config SAMSUNG_ATAGS
def_bool n
depends on ATAGS
help
- This option enables ATAGS based boot support code for
- Samsung platforms, including static platform devices, legacy
- clock, timer and interrupt initialization, etc.
+ This option enables ATAGS based boot support code for
+ Samsung platforms, including static platform devices, legacy
+ clock, timer and interrupt initialization, etc.
- Platforms that support only DT based boot need not to select
- this option.
+ Platforms that support only DT based boot need not to select
+ this option.
if SAMSUNG_ATAGS
@@ -102,7 +102,7 @@ config S3C_DEV_HSMMC3
config S3C_DEV_HWMON
bool
help
- Compile in platform device definitions for HWMON
+ Compile in platform device definitions for HWMON
config S3C_DEV_I2C1
bool
@@ -194,7 +194,7 @@ config S3C64XX_DEV_SPI0
config SAMSUNG_DEV_TS
bool
help
- Common in platform device definitions for touchscreen device
+ Common in platform device definitions for touchscreen device
config SAMSUNG_DEV_KEYPAD
bool
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
2022-05-23 6:42 [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Juerg Haefliger
2022-05-23 6:42 ` [PATCH 1/3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
@ 2022-05-23 6:42 ` Juerg Haefliger
2022-05-23 6:58 ` Alim Akhtar
2022-05-23 6:42 ` [PATCH 3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
2022-06-06 9:13 ` [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
3 siblings, 1 reply; 13+ messages in thread
From: Juerg Haefliger @ 2022-05-23 6:42 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, linux, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
While add it, replace tabs before comments with whitespaces and squeeze
multiple empty lines.
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig.s3c24xx b/arch/arm/mach-s3c/Kconfig.s3c24xx
index 000e3e234f71..a7625e772905 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c24xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c24xx
@@ -17,8 +17,6 @@ config PLAT_S3C24XX
help
Base platform code for any Samsung S3C24XX device
-
-
menu "Samsung S3C24XX SoCs Support"
comment "S3C24XX SoCs"
@@ -268,7 +266,7 @@ config MACH_VR1000
help
Say Y here if you are using the Thorcom VR1000 board.
-endif # CPU_S3C2410
+endif # CPU_S3C2410
config S3C2412_PM_SLEEP
bool
@@ -342,7 +340,7 @@ config MACH_VSTMS
help
Say Y here if you are using an VSTMS board
-endif # CPU_S3C2412
+endif # CPU_S3C2412
if CPU_S3C2416
@@ -390,7 +388,7 @@ config MACH_S3C2416_DT
Note: This is under development and not all peripherals can be supported
with this machine file.
-endif # CPU_S3C2416
+endif # CPU_S3C2416
if CPU_S3C2440 || CPU_S3C2442
@@ -419,7 +417,7 @@ config S3C2440_PLL_16934400
default y if S3C24XX_PLL
help
PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals.
-endif
+endif # CPU_S3C2440 || CPU_S3C2442
if CPU_S3C2440
@@ -515,7 +513,7 @@ config SMDK2440_CPU2440
default y if ARCH_S3C2440
select S3C2440_XTAL_16934400
-endif # CPU_S3C2440
+endif # CPU_S3C2440
if CPU_S3C2442
@@ -535,7 +533,7 @@ config MACH_NEO1973_GTA02
select S3C24XX_PWM
select S3C_DEV_USB_HOST
help
- Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone
+ Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone
config MACH_RX1950
bool "HP iPAQ rx1950"
@@ -547,9 +545,9 @@ config MACH_RX1950
select S3C24XX_PWM
select S3C_DEV_NAND
help
- Say Y here if you're using HP iPAQ rx1950
+ Say Y here if you're using HP iPAQ rx1950
-endif # CPU_S3C2442
+endif # CPU_S3C2442
if CPU_S3C2443 || CPU_S3C2416
@@ -558,7 +556,7 @@ config S3C2443_SETUP_SPI
help
Common setup code for SPI GPIO configurations
-endif # CPU_S3C2443 || CPU_S3C2416
+endif # CPU_S3C2443 || CPU_S3C2416
if CPU_S3C2443
@@ -571,13 +569,13 @@ config MACH_SMDK2443
help
Say Y here if you are using an SMDK2443
-endif # CPU_S3C2443
+endif # CPU_S3C2443
config PM_H1940
bool
help
Internal node for H1940 and related PM
-endmenu # Samsung S3C24XX SoCs Support
+endmenu # "Samsung S3C24XX SoCs Support"
-endif # ARCH_S3C24XX
+endif # ARCH_S3C24XX
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
2022-05-23 6:42 [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Juerg Haefliger
2022-05-23 6:42 ` [PATCH 1/3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
2022-05-23 6:42 ` [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
@ 2022-05-23 6:42 ` Juerg Haefliger
2022-06-06 9:13 ` [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
3 siblings, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-05-23 6:42 UTC (permalink / raw)
To: krzysztof.kozlowski, alim.akhtar, linux, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
index af01675d8769..bbaa8ff3367b 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c64xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
@@ -99,7 +99,7 @@ config S3C64XX_SETUP_SDHCI_GPIO
config S3C64XX_SETUP_SPI
bool
help
- Common setup code for SPI GPIO configurations
+ Common setup code for SPI GPIO configurations
config S3C64XX_SETUP_USB_PHY
bool
@@ -109,7 +109,7 @@ config S3C64XX_SETUP_USB_PHY
# S36400 Macchine support
config MACH_SMDK6400
- bool "SMDK6400"
+ bool "SMDK6400"
depends on ATAGS
select CPU_S3C6400
select S3C64XX_SETUP_SDHCI
@@ -200,7 +200,7 @@ config SMDK6410_SD_CH0
bool "Use channel 0 only"
depends on MACH_SMDK6410
help
- Select CON7 (channel 0) as the MMC/SD slot, as
+ Select CON7 (channel 0) as the MMC/SD slot, as
at least some SMDK6410 boards come with the
resistors fitted so that the card detects for
channels 0 and 1 are the same.
@@ -209,7 +209,7 @@ config SMDK6410_SD_CH1
bool "Use channel 1 only"
depends on MACH_SMDK6410
help
- Select CON6 (channel 1) as the MMC/SD slot, as
+ Select CON6 (channel 1) as the MMC/SD slot, as
at least some SMDK6410 boards come with the
resistors fitted so that the card detects for
channels 0 and 1 are the same.
@@ -255,7 +255,7 @@ config MACH_NCP
select S3C_DEV_HSMMC1
select S3C_DEV_I2C1
help
- Machine support for the Samsung NCP
+ Machine support for the Samsung NCP
config MACH_HMT
bool "Airgoo HMT"
@@ -287,21 +287,21 @@ config MACH_SMARTQ
select SAMSUNG_DEV_PWM
select SAMSUNG_DEV_TS
help
- Shared machine support for SmartQ 5/7
+ Shared machine support for SmartQ 5/7
config MACH_SMARTQ5
bool "SmartQ 5"
depends on ATAGS
select MACH_SMARTQ
help
- Machine support for the SmartQ 5
+ Machine support for the SmartQ 5
config MACH_SMARTQ7
bool "SmartQ 7"
depends on ATAGS
select MACH_SMARTQ
help
- Machine support for the SmartQ 7
+ Machine support for the SmartQ 7
config MACH_WLF_CRAGG_6410
bool "Wolfson Cragganmore 6410"
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* RE: [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
2022-05-23 6:42 ` [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
@ 2022-05-23 6:58 ` Alim Akhtar
0 siblings, 0 replies; 13+ messages in thread
From: Alim Akhtar @ 2022-05-23 6:58 UTC (permalink / raw)
To: 'Juerg Haefliger',
krzysztof.kozlowski, linux, linux-arm-kernel, linux-samsung-soc
Cc: linux-kernel, 'Juerg Haefliger'
Thanks Juerg for your patch.
>-----Original Message-----
>From: Juerg Haefliger [mailto:juerg.haefliger@canonical.com]
>Sent: Monday, May 23, 2022 12:13 PM
>To: krzysztof.kozlowski@linaro.org; alim.akhtar@samsung.com;
>linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-samsung-
>soc@vger.kernel.org
>Cc: linux-kernel@vger.kernel.org; Juerg Haefliger <juergh@canonical.com>
>Subject: [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace
>some tabs
>
>The convention for indentation seems to be a single tab. Help text is
further
>indented by an additional two whitespaces. Fix the lines that violate these
>rules.
>
>While add it, replace tabs before comments with whitespaces and squeeze
>multiple empty lines.
>
>Signed-off-by: Juerg Haefliger <juergh@canonical.com>
>---
> arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
>diff --git a/arch/arm/mach-s3c/Kconfig.s3c24xx b/arch/arm/mach-
>s3c/Kconfig.s3c24xx
>index 000e3e234f71..a7625e772905 100644
>--- a/arch/arm/mach-s3c/Kconfig.s3c24xx
>+++ b/arch/arm/mach-s3c/Kconfig.s3c24xx
>@@ -17,8 +17,6 @@ config PLAT_S3C24XX
> help
> Base platform code for any Samsung S3C24XX device
>
>-
>-
> menu "Samsung S3C24XX SoCs Support"
>
> comment "S3C24XX SoCs"
>@@ -268,7 +266,7 @@ config MACH_VR1000
> help
> Say Y here if you are using the Thorcom VR1000 board.
>
>-endif # CPU_S3C2410
>+endif # CPU_S3C2410
>
> config S3C2412_PM_SLEEP
> bool
>@@ -342,7 +340,7 @@ config MACH_VSTMS
> help
> Say Y here if you are using an VSTMS board
>
>-endif # CPU_S3C2412
>+endif # CPU_S3C2412
>
> if CPU_S3C2416
>
>@@ -390,7 +388,7 @@ config MACH_S3C2416_DT
> Note: This is under development and not all peripherals can be
>supported
> with this machine file.
>
>-endif # CPU_S3C2416
>+endif # CPU_S3C2416
>
> if CPU_S3C2440 || CPU_S3C2442
>
>@@ -419,7 +417,7 @@ config S3C2440_PLL_16934400
> default y if S3C24XX_PLL
> help
> PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals.
>-endif
>+endif # CPU_S3C2440 || CPU_S3C2442
>
This change is more then what commit message tells, so please mention these
in the commit message as well
Rest looks fine to me.
> if CPU_S3C2440
>
>@@ -515,7 +513,7 @@ config SMDK2440_CPU2440
> default y if ARCH_S3C2440
> select S3C2440_XTAL_16934400
>
>-endif # CPU_S3C2440
>+endif # CPU_S3C2440
>
> if CPU_S3C2442
>
>@@ -535,7 +533,7 @@ config MACH_NEO1973_GTA02
> select S3C24XX_PWM
> select S3C_DEV_USB_HOST
> help
>- Say Y here if you are using the Openmoko GTA02 / Freerunner GSM
>Phone
>+ Say Y here if you are using the Openmoko GTA02 / Freerunner GSM
>+Phone
>
> config MACH_RX1950
> bool "HP iPAQ rx1950"
>@@ -547,9 +545,9 @@ config MACH_RX1950
> select S3C24XX_PWM
> select S3C_DEV_NAND
> help
>- Say Y here if you're using HP iPAQ rx1950
>+ Say Y here if you're using HP iPAQ rx1950
>
>-endif # CPU_S3C2442
>+endif # CPU_S3C2442
>
> if CPU_S3C2443 || CPU_S3C2416
>
>@@ -558,7 +556,7 @@ config S3C2443_SETUP_SPI
> help
> Common setup code for SPI GPIO configurations
>
>-endif # CPU_S3C2443 || CPU_S3C2416
>+endif # CPU_S3C2443 || CPU_S3C2416
>
> if CPU_S3C2443
>
>@@ -571,13 +569,13 @@ config MACH_SMDK2443
> help
> Say Y here if you are using an SMDK2443
>
>-endif # CPU_S3C2443
>+endif # CPU_S3C2443
>
> config PM_H1940
> bool
> help
> Internal node for H1940 and related PM
>
>-endmenu # Samsung S3C24XX SoCs Support
>+endmenu # "Samsung S3C24XX SoCs Support"
>
>-endif # ARCH_S3C24XX
>+endif # ARCH_S3C24XX
>--
>2.32.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups
2022-05-23 6:42 [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Juerg Haefliger
` (2 preceding siblings ...)
2022-05-23 6:42 ` [PATCH 3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
@ 2022-06-06 9:13 ` Krzysztof Kozlowski
2022-06-06 9:14 ` Krzysztof Kozlowski
3 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 9:13 UTC (permalink / raw)
To: Juerg Haefliger, linux, alim.akhtar, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, linux-kernel, Juerg Haefliger
On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
>
> While at it, add missing trailing comments to endif statements and replace
> tabs before comments with whitespaces (which seems to be more common).
>
> [...]
Applied, thanks!
[1/3] ARM: s3c: Kconfig: Fix indentation
https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
[3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
(no commit info)
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups
2022-06-06 9:13 ` [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
@ 2022-06-06 9:14 ` Krzysztof Kozlowski
2022-06-07 6:59 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
0 siblings, 2 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 9:14 UTC (permalink / raw)
To: Juerg Haefliger, linux, alim.akhtar, linux-arm-kernel, linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
>> The majority of the Kconfig files use a single tab for basic indentation
>> and a single tab followed by two whitespaces for help text indentation.
>> Fix the lines that don't follow this convention.
>>
>> While at it, add missing trailing comments to endif statements and replace
>> tabs before comments with whitespaces (which seems to be more common).
>>
>> [...]
>
> Applied, thanks!
>
> [1/3] ARM: s3c: Kconfig: Fix indentation
> https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> (no commit info)
...And dropped. This does not pass checkpatch. Please be sure you run
scripts/checkpatch on your contributions.
WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg
Haefliger <juergh@canonical.com>'
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups
2022-06-06 9:14 ` Krzysztof Kozlowski
@ 2022-06-07 6:59 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
1 sibling, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-06-07 6:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Juerg Haefliger, linux, alim.akhtar, linux-arm-kernel,
linux-samsung-soc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
On Mon, 6 Jun 2022 11:14:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> >> The majority of the Kconfig files use a single tab for basic indentation
> >> and a single tab followed by two whitespaces for help text indentation.
> >> Fix the lines that don't follow this convention.
> >>
> >> While at it, add missing trailing comments to endif statements and replace
> >> tabs before comments with whitespaces (which seems to be more common).
> >>
> >> [...]
> >
> > Applied, thanks!
> >
> > [1/3] ARM: s3c: Kconfig: Fix indentation
> > https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> > (no commit info)
>
> ...And dropped. This does not pass checkpatch. Please be sure you run
> scripts/checkpatch on your contributions.
I did and the check passed but email aliases don't work well in this scenario.
Will fix and resubmit.
...Juerg
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
> Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg
> Haefliger <juergh@canonical.com>'
>
>
> Best regards,
> Krzysztof
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 0/3 v3] ARM: s3c: Kconfig: Style cleanups
2022-06-06 9:14 ` Krzysztof Kozlowski
2022-06-07 6:59 ` Juerg Haefliger
@ 2022-06-09 8:21 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 1/3 v3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
` (3 more replies)
1 sibling, 4 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-06-09 8:21 UTC (permalink / raw)
To: krzysztof.kozlowski, linux, alim.akhtar, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.
While at it, add missing trailing comments to endif statements and replace
tabs before comments with whitespaces (which seems to be more common).
v3:
- Match sob and author email addresses.
- Rebase to next-20220609.
v2 (patch 2 only):
- Mention additional changes in the commit message.
Juerg Haefliger (3):
ARM: s3c: Kconfig: Fix indentation
ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
ARM: s3c: Kconfig.s3c64xx: Fix indentation
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
3 files changed, 27 insertions(+), 29 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3 v3] ARM: s3c: Kconfig: Fix indentation
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
@ 2022-06-09 8:21 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 2/3 v3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-06-09 8:21 UTC (permalink / raw)
To: krzysztof.kozlowski, linux, alim.akhtar, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig b/arch/arm/mach-s3c/Kconfig
index 54548c051402..a64143574546 100644
--- a/arch/arm/mach-s3c/Kconfig
+++ b/arch/arm/mach-s3c/Kconfig
@@ -43,12 +43,12 @@ config SAMSUNG_ATAGS
def_bool n
depends on ATAGS
help
- This option enables ATAGS based boot support code for
- Samsung platforms, including static platform devices, legacy
- clock, timer and interrupt initialization, etc.
+ This option enables ATAGS based boot support code for
+ Samsung platforms, including static platform devices, legacy
+ clock, timer and interrupt initialization, etc.
- Platforms that support only DT based boot need not to select
- this option.
+ Platforms that support only DT based boot need not to select
+ this option.
if SAMSUNG_ATAGS
@@ -102,7 +102,7 @@ config S3C_DEV_HSMMC3
config S3C_DEV_HWMON
bool
help
- Compile in platform device definitions for HWMON
+ Compile in platform device definitions for HWMON
config S3C_DEV_I2C1
bool
@@ -194,7 +194,7 @@ config S3C64XX_DEV_SPI0
config SAMSUNG_DEV_TS
bool
help
- Common in platform device definitions for touchscreen device
+ Common in platform device definitions for touchscreen device
config SAMSUNG_DEV_KEYPAD
bool
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3 v3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
2022-06-09 8:21 ` [PATCH 1/3 v3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
@ 2022-06-09 8:21 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 3/3 v3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
2022-06-09 18:36 ` [PATCH 0/3 v3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
3 siblings, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-06-09 8:21 UTC (permalink / raw)
To: krzysztof.kozlowski, linux, alim.akhtar, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
While add it, replace tabs before comments with whitespaces (which seems to
be more common), add a missing trailing endif comment and squeeze multiple
empty lines.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
v2:
Mention additional changes in the commit message.
---
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig.s3c24xx b/arch/arm/mach-s3c/Kconfig.s3c24xx
index 662c5aec2ea3..ba8f4f7101de 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c24xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c24xx
@@ -37,8 +37,6 @@ config PLAT_S3C24XX
help
Base platform code for any Samsung S3C24XX device
-
-
menu "Samsung S3C24XX SoCs Support"
comment "S3C24XX SoCs"
@@ -293,7 +291,7 @@ config MACH_VR1000
help
Say Y here if you are using the Thorcom VR1000 board.
-endif # CPU_S3C2410
+endif # CPU_S3C2410
config S3C2412_PM_SLEEP
bool
@@ -367,7 +365,7 @@ config MACH_VSTMS
help
Say Y here if you are using an VSTMS board
-endif # CPU_S3C2412
+endif # CPU_S3C2412
if CPU_S3C2416
@@ -415,7 +413,7 @@ config MACH_S3C2416_DT
Note: This is under development and not all peripherals can be supported
with this machine file.
-endif # CPU_S3C2416
+endif # CPU_S3C2416
if CPU_S3C2440 || CPU_S3C2442
@@ -444,7 +442,7 @@ config S3C2440_PLL_16934400
default y if S3C24XX_PLL
help
PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals.
-endif
+endif # CPU_S3C2440 || CPU_S3C2442
if CPU_S3C2440
@@ -540,7 +538,7 @@ config SMDK2440_CPU2440
default y if ARCH_S3C2440
select S3C2440_XTAL_16934400
-endif # CPU_S3C2440
+endif # CPU_S3C2440
if CPU_S3C2442
@@ -559,7 +557,7 @@ config MACH_NEO1973_GTA02
select POWER_SUPPLY
select S3C_DEV_USB_HOST
help
- Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone
+ Say Y here if you are using the Openmoko GTA02 / Freerunner GSM Phone
config MACH_RX1950
bool "HP iPAQ rx1950"
@@ -570,9 +568,9 @@ config MACH_RX1950
select S3C2440_XTAL_16934400
select S3C_DEV_NAND
help
- Say Y here if you're using HP iPAQ rx1950
+ Say Y here if you're using HP iPAQ rx1950
-endif # CPU_S3C2442
+endif # CPU_S3C2442
if CPU_S3C2443 || CPU_S3C2416
@@ -581,7 +579,7 @@ config S3C2443_SETUP_SPI
help
Common setup code for SPI GPIO configurations
-endif # CPU_S3C2443 || CPU_S3C2416
+endif # CPU_S3C2443 || CPU_S3C2416
if CPU_S3C2443
@@ -594,13 +592,13 @@ config MACH_SMDK2443
help
Say Y here if you are using an SMDK2443
-endif # CPU_S3C2443
+endif # CPU_S3C2443
config PM_H1940
bool
help
Internal node for H1940 and related PM
-endmenu # Samsung S3C24XX SoCs Support
+endmenu # "Samsung S3C24XX SoCs Support"
-endif # ARCH_S3C24XX
+endif # ARCH_S3C24XX
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3 v3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
2022-06-09 8:21 ` [PATCH 1/3 v3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
2022-06-09 8:21 ` [PATCH 2/3 v3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
@ 2022-06-09 8:21 ` Juerg Haefliger
2022-06-09 18:36 ` [PATCH 0/3 v3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
3 siblings, 0 replies; 13+ messages in thread
From: Juerg Haefliger @ 2022-06-09 8:21 UTC (permalink / raw)
To: krzysztof.kozlowski, linux, alim.akhtar, linux-arm-kernel,
linux-samsung-soc
Cc: linux-kernel, Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
index 2b27bff4d928..bfc222f5bcd9 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c64xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
@@ -104,7 +104,7 @@ config S3C64XX_SETUP_SDHCI_GPIO
config S3C64XX_SETUP_SPI
bool
help
- Common setup code for SPI GPIO configurations
+ Common setup code for SPI GPIO configurations
config S3C64XX_SETUP_USB_PHY
bool
@@ -114,7 +114,7 @@ config S3C64XX_SETUP_USB_PHY
# S36400 Macchine support
config MACH_SMDK6400
- bool "SMDK6400"
+ bool "SMDK6400"
depends on ATAGS
select CPU_S3C6400
select S3C64XX_SETUP_SDHCI
@@ -205,7 +205,7 @@ config SMDK6410_SD_CH0
bool "Use channel 0 only"
depends on MACH_SMDK6410
help
- Select CON7 (channel 0) as the MMC/SD slot, as
+ Select CON7 (channel 0) as the MMC/SD slot, as
at least some SMDK6410 boards come with the
resistors fitted so that the card detects for
channels 0 and 1 are the same.
@@ -214,7 +214,7 @@ config SMDK6410_SD_CH1
bool "Use channel 1 only"
depends on MACH_SMDK6410
help
- Select CON6 (channel 1) as the MMC/SD slot, as
+ Select CON6 (channel 1) as the MMC/SD slot, as
at least some SMDK6410 boards come with the
resistors fitted so that the card detects for
channels 0 and 1 are the same.
@@ -260,7 +260,7 @@ config MACH_NCP
select S3C_DEV_HSMMC1
select S3C_DEV_I2C1
help
- Machine support for the Samsung NCP
+ Machine support for the Samsung NCP
config MACH_HMT
bool "Airgoo HMT"
@@ -292,21 +292,21 @@ config MACH_SMARTQ
select SAMSUNG_DEV_PWM
select SAMSUNG_DEV_TS
help
- Shared machine support for SmartQ 5/7
+ Shared machine support for SmartQ 5/7
config MACH_SMARTQ5
bool "SmartQ 5"
depends on ATAGS
select MACH_SMARTQ
help
- Machine support for the SmartQ 5
+ Machine support for the SmartQ 5
config MACH_SMARTQ7
bool "SmartQ 7"
depends on ATAGS
select MACH_SMARTQ
help
- Machine support for the SmartQ 7
+ Machine support for the SmartQ 7
config MACH_WLF_CRAGG_6410
bool "Wolfson Cragganmore 6410"
--
2.32.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 0/3 v3] ARM: s3c: Kconfig: Style cleanups
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
` (2 preceding siblings ...)
2022-06-09 8:21 ` [PATCH 3/3 v3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
@ 2022-06-09 18:36 ` Krzysztof Kozlowski
3 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-09 18:36 UTC (permalink / raw)
To: alim.akhtar, linux-samsung-soc, Juerg Haefliger, linux-arm-kernel, linux
Cc: Krzysztof Kozlowski, linux-kernel
On Thu, 9 Jun 2022 10:21:51 +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
>
> While at it, add missing trailing comments to endif statements and replace
> tabs before comments with whitespaces (which seems to be more common).
>
> [...]
Applied, thanks!
[1/3] ARM: s3c: Kconfig: Fix indentation
https://git.kernel.org/krzk/linux/c/1afde294a99d3dd2a2aa4e28d15590755927f66e
[2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
https://git.kernel.org/krzk/linux/c/48bf4b8497419f5b9a29da19c72e00dc2b8d498c
[3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
https://git.kernel.org/krzk/linux/c/d1065293010a010261f0b1478daff40d5a3dc241
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-06-09 18:36 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 6:42 [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Juerg Haefliger
2022-05-23 6:42 ` [PATCH 1/3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
2022-05-23 6:42 ` [PATCH 2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
2022-05-23 6:58 ` Alim Akhtar
2022-05-23 6:42 ` [PATCH 3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
2022-06-06 9:13 ` [PATCH 0/3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
2022-06-06 9:14 ` Krzysztof Kozlowski
2022-06-07 6:59 ` Juerg Haefliger
2022-06-09 8:21 ` [PATCH 0/3 v3] " Juerg Haefliger
2022-06-09 8:21 ` [PATCH 1/3 v3] ARM: s3c: Kconfig: Fix indentation Juerg Haefliger
2022-06-09 8:21 ` [PATCH 2/3 v3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs Juerg Haefliger
2022-06-09 8:21 ` [PATCH 3/3 v3] ARM: s3c: Kconfig.s3c64xx: Fix indentation Juerg Haefliger
2022-06-09 18:36 ` [PATCH 0/3 v3] ARM: s3c: Kconfig: Style cleanups Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).