* [PATCH -next] cifs: Remove duplicated include in cifssmb.c
@ 2022-05-26 23:26 Yang Li
2022-05-28 1:32 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-05-26 23:26 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, Yang Li, Abaci Robot
Fix following includecheck warning:
./fs/cifs/cifssmb.c: cifsfs.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/cifs/cifssmb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index e3457356ec11..193009f1421b 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -28,7 +28,6 @@
#include "cifsglob.h"
#include "cifsacl.h"
#include "cifsproto.h"
-#include "cifsfs.h"
#include "cifs_unicode.h"
#include "cifs_debug.h"
#include "smb2proto.h"
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] cifs: Remove duplicated include in cifssmb.c
2022-05-26 23:26 [PATCH -next] cifs: Remove duplicated include in cifssmb.c Yang Li
@ 2022-05-28 1:32 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2022-05-28 1:32 UTC (permalink / raw)
To: Yang Li; +Cc: Steve French, CIFS, samba-technical, LKML, Abaci Robot
I don't see this line (ie the include cifsfs.h) in fs/cifs/cifssmb.c
anymore could you do a "git blame" and find where that line was added
in for-next?
On Thu, May 26, 2022 at 11:27 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Fix following includecheck warning:
> ./fs/cifs/cifssmb.c: cifsfs.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/cifs/cifssmb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index e3457356ec11..193009f1421b 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -28,7 +28,6 @@
> #include "cifsglob.h"
> #include "cifsacl.h"
> #include "cifsproto.h"
> -#include "cifsfs.h"
> #include "cifs_unicode.h"
> #include "cifs_debug.h"
> #include "smb2proto.h"
> --
> 2.20.1.7.g153144c
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-28 1:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 23:26 [PATCH -next] cifs: Remove duplicated include in cifssmb.c Yang Li
2022-05-28 1:32 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).