From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Jakub Matěna" <matenajakub@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
patches@lists.linux.dev, linux-kernel@vger.kernel.org,
vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net,
willy@infradead.org, liam.howlett@oracle.com, hughd@google.com,
riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org
Subject: Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge()
Date: Sat, 28 May 2022 02:39:15 +0300 [thread overview]
Message-ID: <20220527233915.55oe6jittuogavot@box.shutemov.name> (raw)
In-Reply-To: <20220527104810.24736-2-matenajakub@gmail.com>
On Fri, May 27, 2022 at 12:48:09PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter and more understandable.
> Main change is the elimination of code duplicity in the case of
> merge next check. This is done by first doing checks and caching
> the results before executing the merge itself. The variable 'area' is
> divided into 'mid' and 'res' as previously it was used for two purposes,
> as the middle VMA between prev and next and also as the result of the
> merge itself. Exit paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@gmail.com>
You've ignored my ack. Or is there substantial changes that you want me to
review again?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2022-05-27 23:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 10:48 [PATCH 0/2] Refactor of vma_merge and new merge call Jakub Matěna
2022-05-27 10:48 ` [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge() Jakub Matěna
2022-05-27 23:39 ` Kirill A. Shutemov [this message]
2022-05-27 10:48 ` [PATCH 2/2] [PATCH 2/2] mm: add merging after mremap resize Jakub Matěna
2022-05-27 16:19 ` kernel test robot
2022-05-27 23:46 ` Kirill A. Shutemov
2022-05-30 10:53 ` Jakub Matěna
2022-06-02 14:56 [PATCH v2 0/2] Refactor of vma_merge and new merge call Jakub Matěna
2022-06-02 14:56 ` [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge() Jakub Matěna
2022-06-02 18:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527233915.55oe6jittuogavot@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).