linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic
@ 2022-05-31  5:17 Samuel Holland
  2022-05-31  5:17 ` [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible Samuel Holland
  2022-06-09 22:40 ` [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Stephen Boyd
  0 siblings, 2 replies; 5+ messages in thread
From: Samuel Holland @ 2022-05-31  5:17 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: Jernej Skrabec, Chen-Yu Tsai, Maxime Ripard, Samuel Holland,
	linux-clk, linux-kernel

This compatible is part of the legacy sunxi clock support, and has not
been used since commit 6b48644b1d29 ("ARM: gr8: Convert to CCU") in
October 2016. Since supporting this compatible adds some overhead to
generic clock code, let's clean it up.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/clk/clk-fixed-factor.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 54942d758ee6..e6b36247c16b 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -210,16 +210,10 @@ struct clk_hw *devm_clk_hw_register_fixed_factor(struct device *dev,
 EXPORT_SYMBOL_GPL(devm_clk_hw_register_fixed_factor);
 
 #ifdef CONFIG_OF
-static const struct of_device_id set_rate_parent_matches[] = {
-	{ .compatible = "allwinner,sun4i-a10-pll3-2x-clk" },
-	{ /* Sentinel */ },
-};
-
 static struct clk_hw *_of_fixed_factor_clk_setup(struct device_node *node)
 {
 	struct clk_hw *hw;
 	const char *clk_name = node->name;
-	unsigned long flags = 0;
 	u32 div, mult;
 	int ret;
 
@@ -237,11 +231,8 @@ static struct clk_hw *_of_fixed_factor_clk_setup(struct device_node *node)
 
 	of_property_read_string(node, "clock-output-names", &clk_name);
 
-	if (of_match_node(set_rate_parent_matches, node))
-		flags |= CLK_SET_RATE_PARENT;
-
 	hw = __clk_hw_register_fixed_factor(NULL, node, clk_name, NULL, 0,
-					    flags, mult, div, false);
+					    0, mult, div, false);
 	if (IS_ERR(hw)) {
 		/*
 		 * Clear OF_POPULATED flag so that clock registration can be
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible
  2022-05-31  5:17 [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Samuel Holland
@ 2022-05-31  5:17 ` Samuel Holland
  2022-06-05 21:24   ` Rob Herring
  2022-06-09 22:41   ` Stephen Boyd
  2022-06-09 22:40 ` [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Stephen Boyd
  1 sibling, 2 replies; 5+ messages in thread
From: Samuel Holland @ 2022-05-31  5:17 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: Jernej Skrabec, Chen-Yu Tsai, Maxime Ripard, Samuel Holland,
	linux-clk, linux-kernel, Krzysztof Kozlowski, Rob Herring,
	devicetree

This compatible is part of the legacy sunxi clock support, and has not
been used since commit 6b48644b1d29 ("ARM: gr8: Convert to CCU") in
October 2016. Now that the code for this compatible has been removed,
let's drop the compatible.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
index f415845b38dd..0b02378a3a0c 100644
--- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
@@ -13,7 +13,6 @@ maintainers:
 properties:
   compatible:
     enum:
-      - allwinner,sun4i-a10-pll3-2x-clk
       - fixed-factor-clock
 
   "#clock-cells":
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible
  2022-05-31  5:17 ` [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible Samuel Holland
@ 2022-06-05 21:24   ` Rob Herring
  2022-06-09 22:41   ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-06-05 21:24 UTC (permalink / raw)
  To: Samuel Holland
  Cc: Krzysztof Kozlowski, linux-kernel, Maxime Ripard, Rob Herring,
	Jernej Skrabec, devicetree, Michael Turquette, Chen-Yu Tsai,
	linux-clk, Stephen Boyd

On Tue, 31 May 2022 00:17:42 -0500, Samuel Holland wrote:
> This compatible is part of the legacy sunxi clock support, and has not
> been used since commit 6b48644b1d29 ("ARM: gr8: Convert to CCU") in
> October 2016. Now that the code for this compatible has been removed,
> let's drop the compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic
  2022-05-31  5:17 [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Samuel Holland
  2022-05-31  5:17 ` [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible Samuel Holland
@ 2022-06-09 22:40 ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2022-06-09 22:40 UTC (permalink / raw)
  To: Michael Turquette, Samuel Holland
  Cc: Jernej Skrabec, Chen-Yu Tsai, Maxime Ripard, Samuel Holland,
	linux-clk, linux-kernel

Quoting Samuel Holland (2022-05-30 22:17:41)
> This compatible is part of the legacy sunxi clock support, and has not
> been used since commit 6b48644b1d29 ("ARM: gr8: Convert to CCU") in
> October 2016. Since supporting this compatible adds some overhead to
> generic clock code, let's clean it up.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible
  2022-05-31  5:17 ` [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible Samuel Holland
  2022-06-05 21:24   ` Rob Herring
@ 2022-06-09 22:41   ` Stephen Boyd
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2022-06-09 22:41 UTC (permalink / raw)
  To: Michael Turquette, Samuel Holland
  Cc: Jernej Skrabec, Chen-Yu Tsai, Maxime Ripard, Samuel Holland,
	linux-clk, linux-kernel, Krzysztof Kozlowski, Rob Herring,
	devicetree

Quoting Samuel Holland (2022-05-30 22:17:42)
> This compatible is part of the legacy sunxi clock support, and has not
> been used since commit 6b48644b1d29 ("ARM: gr8: Convert to CCU") in
> October 2016. Now that the code for this compatible has been removed,
> let's drop the compatible.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-09 22:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31  5:17 [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Samuel Holland
2022-05-31  5:17 ` [PATCH 2/2] dt-bindings: clock: fixed-factor: Drop Allwinner A10 compatible Samuel Holland
2022-06-05 21:24   ` Rob Herring
2022-06-09 22:41   ` Stephen Boyd
2022-06-09 22:40 ` [PATCH 1/2] clk: fixed: Remove Allwinner A10 special-case logic Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).