* [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
@ 2022-05-31 10:25 Kalpana Shetty
2022-05-31 18:40 ` Andrew Morton
2022-06-09 20:21 ` Shuah Khan
0 siblings, 2 replies; 5+ messages in thread
From: Kalpana Shetty @ 2022-05-31 10:25 UTC (permalink / raw)
To: akpm, shuah, linux-mm, linux-kselftest, linux-kernel; +Cc: Kalpana Shetty
Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
---
tools/testing/selftests/vm/run_vmtests.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
index 41fce8bea929..54a0c28f810c 100755
--- a/tools/testing/selftests/vm/run_vmtests.sh
+++ b/tools/testing/selftests/vm/run_vmtests.sh
@@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
# KSM test with 2 NUMA nodes and merge_across_nodes = 0
run_test ./ksm_tests -N -m 0
+# protection_keys tests
+if [ $VADDR64 -eq 0 ]; then
+ run_test ./protection_keys_32
+else
+ run_test ./protection_keys_64
+fi
+
exit $exitcode
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
2022-05-31 10:25 [PATCH] selftests/vm: Add protection_keys tests to run_vmtests Kalpana Shetty
@ 2022-05-31 18:40 ` Andrew Morton
2022-06-01 9:14 ` Shetty, Kalpana
2022-06-09 20:21 ` Shuah Khan
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2022-05-31 18:40 UTC (permalink / raw)
To: Kalpana Shetty; +Cc: shuah, linux-mm, linux-kselftest, linux-kernel
On Tue, 31 May 2022 15:55:56 +0530 Kalpana Shetty <kalpana.shetty@amd.com> wrote:
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
> # KSM test with 2 NUMA nodes and merge_across_nodes = 0
> run_test ./ksm_tests -N -m 0
>
> +# protection_keys tests
> +if [ $VADDR64 -eq 0 ]; then
> + run_test ./protection_keys_32
> +else
> + run_test ./protection_keys_64
> +fi
> +
> exit $exitcode
So we're presently not running this test at all, unless invoked by
hand?
I'm thinking we should backport this fix - have you any idea when we
broke it?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
2022-05-31 18:40 ` Andrew Morton
@ 2022-06-01 9:14 ` Shetty, Kalpana
0 siblings, 0 replies; 5+ messages in thread
From: Shetty, Kalpana @ 2022-06-01 9:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: shuah, linux-mm, linux-kselftest, linux-kernel
On 6/1/2022 12:10 AM, Andrew Morton wrote:
> On Tue, 31 May 2022 15:55:56 +0530 Kalpana Shetty <kalpana.shetty@amd.com> wrote:
>
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
>> # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>> run_test ./ksm_tests -N -m 0
>>
>> +# protection_keys tests
>> +if [ $VADDR64 -eq 0 ]; then
>> + run_test ./protection_keys_32
>> +else
>> + run_test ./protection_keys_64
>> +fi
>> +
>> exit $exitcode
> So we're presently not running this test at all, unless invoked by
> hand?
Yes.
>
> I'm thinking we should backport this fix - have you any idea when we
> broke it?
We didn't break it, just adding "protection_keys" test as part of
run_vmtests.sh
Thanks,
Kalpana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
2022-05-31 10:25 [PATCH] selftests/vm: Add protection_keys tests to run_vmtests Kalpana Shetty
2022-05-31 18:40 ` Andrew Morton
@ 2022-06-09 20:21 ` Shuah Khan
2022-06-10 9:09 ` Shetty, Kalpana
1 sibling, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2022-06-09 20:21 UTC (permalink / raw)
To: Kalpana Shetty, akpm, shuah, linux-mm, linux-kselftest,
linux-kernel, Shuah Khan
On 5/31/22 4:25 AM, Kalpana Shetty wrote:
> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
Missing commit log - please add a detailed commit log explaining why
this change is necessary.
> ---
> tools/testing/selftests/vm/run_vmtests.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index 41fce8bea929..54a0c28f810c 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
> # KSM test with 2 NUMA nodes and merge_across_nodes = 0
> run_test ./ksm_tests -N -m 0
>
> +# protection_keys tests
> +if [ $VADDR64 -eq 0 ]; then
> + run_test ./protection_keys_32
> +else
> + run_test ./protection_keys_64
> +fi
> +
> exit $exitcode
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
2022-06-09 20:21 ` Shuah Khan
@ 2022-06-10 9:09 ` Shetty, Kalpana
0 siblings, 0 replies; 5+ messages in thread
From: Shetty, Kalpana @ 2022-06-10 9:09 UTC (permalink / raw)
To: Shuah Khan, akpm, shuah, linux-mm, linux-kselftest, linux-kernel
On 6/10/2022 1:51 AM, Shuah Khan wrote:
> On 5/31/22 4:25 AM, Kalpana Shetty wrote:
>> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
>
> Missing commit log - please add a detailed commit log explaining why
> this change is necessary.
Sent V2 patch with patch description.
Thanks,
Kalpana
>
>> ---
>> tools/testing/selftests/vm/run_vmtests.sh | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/tools/testing/selftests/vm/run_vmtests.sh
>> b/tools/testing/selftests/vm/run_vmtests.sh
>> index 41fce8bea929..54a0c28f810c 100755
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
>> # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>> run_test ./ksm_tests -N -m 0
>> +# protection_keys tests
>> +if [ $VADDR64 -eq 0 ]; then
>> + run_test ./protection_keys_32
>> +else
>> + run_test ./protection_keys_64
>> +fi
>> +
>> exit $exitcode
>>
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-10 9:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 10:25 [PATCH] selftests/vm: Add protection_keys tests to run_vmtests Kalpana Shetty
2022-05-31 18:40 ` Andrew Morton
2022-06-01 9:14 ` Shetty, Kalpana
2022-06-09 20:21 ` Shuah Khan
2022-06-10 9:09 ` Shetty, Kalpana
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).