* [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register
@ 2022-06-01 2:48 Jiasheng Jiang
2022-06-01 6:52 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2022-06-01 2:48 UTC (permalink / raw)
To: andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, maxime, sam, alsi, jagan,
biju.das.jz, l.stach
Cc: dri-devel, linux-kernel, Jiasheng Jiang
As mipi_dsi_driver_register could return error if fails,
it should be better to check the return value and return error
if fails.
Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 5bb9300040dd..795855b41eb2 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1392,8 +1392,13 @@ static struct i2c_driver adv7511_driver = {
static int __init adv7511_init(void)
{
- if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
- mipi_dsi_driver_register(&adv7533_dsi_driver);
+ int ret;
+
+ if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) {
+ ret = mipi_dsi_driver_register(&adv7533_dsi_driver);
+ if (ret)
+ return ret;
+ }
return i2c_add_driver(&adv7511_driver);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register
2022-06-01 2:48 [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register Jiasheng Jiang
@ 2022-06-01 6:52 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2022-06-01 6:52 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: andrzej.hajda, narmstrong, robert.foss, jonas, jernej.skrabec,
airlied, daniel, maxime, sam, alsi, jagan, biju.das.jz, l.stach,
dri-devel, linux-kernel
Hi Jiasheng,
Thank you for the patch.
On Wed, Jun 01, 2022 at 10:48:22AM +0800, Jiasheng Jiang wrote:
> As mipi_dsi_driver_register could return error if fails,
> it should be better to check the return value and return error
> if fails.
>
> Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 5bb9300040dd..795855b41eb2 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1392,8 +1392,13 @@ static struct i2c_driver adv7511_driver = {
>
> static int __init adv7511_init(void)
> {
> - if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
> - mipi_dsi_driver_register(&adv7533_dsi_driver);
> + int ret;
> +
> + if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) {
> + ret = mipi_dsi_driver_register(&adv7533_dsi_driver);
> + if (ret)
> + return ret;
> + }
>
> return i2c_add_driver(&adv7511_driver);
While at it, should this then call mipi_dsi_driver_unregister() on
failure ?
> }
> --
> 2.25.1
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register
2022-06-01 11:12 Jiasheng Jiang
@ 2022-06-02 8:40 ` Maxime Ripard
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2022-06-02 8:40 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: laurent.pinchart, andrzej.hajda, narmstrong, robert.foss, jonas,
jernej.skrabec, airlied, daniel, sam, alsi, jagan, biju.das.jz,
l.stach, dri-devel, linux-kernel
On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote:
> On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote:
> >> Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue.
> >> Therefore, it might not be necessary to add another mipi_dsi_driver_unregister().
> >
> > The issue is that adv7511_exit() is not called if adv7511_init() fails.
>
> Sorry, I can not find the caller of adv7511_init().
> Please give me more detail.
It's called by the kernel when the module is unloaded (module_exit).
It's not what Laurent is saying though.
His point is that in adv7511, if i2c_add_driver fails, you'll still need
to call mipi_dsi_driver_unregister to clean things up.
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-02 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01 2:48 [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register Jiasheng Jiang
2022-06-01 6:52 ` Laurent Pinchart
2022-06-01 11:12 Jiasheng Jiang
2022-06-02 8:40 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).