* [PATCH] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
@ 2022-06-05 6:51 Miaoqian Lin
2022-08-02 11:02 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-05 6:51 UTC (permalink / raw)
To: Arnd Bergmann, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, linuxppc-dev, linux-kernel
Cc: linmq006
of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.
Fixes: ce21b3c9648a ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/powerpc/platforms/cell/axon_msi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
index f3291e957a19..5b012abca773 100644
--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
if (!prop) {
dev_dbg(&dev->dev,
"axon_msi: no msi-address-(32|64) properties found\n");
+ of_node_put(dn);
return -ENOENT;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
2022-06-05 6:51 [PATCH] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address Miaoqian Lin
@ 2022-08-02 11:02 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-08-02 11:02 UTC (permalink / raw)
To: linuxppc-dev, Paul Mackerras, linux-kernel, Arnd Bergmann,
Benjamin Herrenschmidt, Michael Ellerman, Miaoqian Lin
On Sun, 5 Jun 2022 10:51:29 +0400, Miaoqian Lin wrote:
> of_get_next_parent() returns a node pointer with refcount incremented,
> we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() in the error path to avoid refcount leak.
>
>
Applied to powerpc/next.
[1/1] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
https://git.kernel.org/powerpc/c/df5d4b616ee76abc97e5bd348e22659c2b095b1c
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-02 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-05 6:51 [PATCH] powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address Miaoqian Lin
2022-08-02 11:02 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).