* [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call
@ 2022-06-06 1:44 cgel.zte
2022-11-21 20:25 ` zzam
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-06-06 1:44 UTC (permalink / raw)
To: zzam; +Cc: mchehab, linux-media, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
release_firmware() checks for NULL pointers internally so checking
before calling it is redundant.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/media/dvb-frontends/si2165.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c
index ebee230afb7b..3d167ca670a4 100644
--- a/drivers/media/dvb-frontends/si2165.c
+++ b/drivers/media/dvb-frontends/si2165.c
@@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state)
ret = 0;
state->firmware_loaded = true;
error:
- if (fw) {
- release_firmware(fw);
- fw = NULL;
- }
+ release_firmware(fw);
+ fw = NULL;
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call
2022-06-06 1:44 [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call cgel.zte
@ 2022-11-21 20:25 ` zzam
0 siblings, 0 replies; 2+ messages in thread
From: zzam @ 2022-11-21 20:25 UTC (permalink / raw)
To: cgel.zte; +Cc: mchehab, linux-media, linux-kernel, Minghao Chi, Zeal Robot
Am 06.06.22 um 03:44 schrieb cgel.zte@gmail.com:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/media/dvb-frontends/si2165.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c
> index ebee230afb7b..3d167ca670a4 100644
> --- a/drivers/media/dvb-frontends/si2165.c
> +++ b/drivers/media/dvb-frontends/si2165.c
> @@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state)
> ret = 0;
> state->firmware_loaded = true;
> error:
> - if (fw) {
> - release_firmware(fw);
> - fw = NULL;
> - }
> + release_firmware(fw);
> + fw = NULL;
>
> return ret;
> }
Acked-by: Matthias Schwarzott <zzam@gentoo.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-06 1:44 [PATCH] [media] si2165: Remove redundant NULL check before release_firmware() call cgel.zte
2022-11-21 20:25 ` zzam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).