From: Guru Das Srinagesh <quic_gurus@quicinc.com>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: <linus.walleij@linaro.org>, <brgl@bgdev.pl>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <wens@csie.org>,
<jic23@kernel.org>, <lee.jones@linaro.org>, <sre@kernel.org>,
<broonie@kernel.org>, <gregkh@linuxfoundation.org>,
<lgirdwood@gmail.com>, <lars@metafoo.de>, <rafael@kernel.org>,
<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/10] regmap-irq: Add get_irq_reg to support unusual register layouts
Date: Mon, 6 Jun 2022 10:43:20 -0700 [thread overview]
Message-ID: <20220606174320.GA16522@quicinc.com> (raw)
In-Reply-To: <20220603135714.12007-2-aidanmacdonald.0x0@gmail.com>
On Fri, Jun 03, 2022 at 02:57:05PM +0100, Aidan MacDonald wrote:
> Add a new callback, get_irq_reg, for regmap IRQ chips, to support devices
> with unusual register layouts. This is required in the rare cases where
> the offset of an IRQ register is not constant with respect to the base
> register. This is probably best illustrated with an example:
>
> mask status
> IRQ0 0x40 0x44
> IRQ1 0x41 0x45
> IRQ2 0x42 0x46
> IRQ3 0x43 0x47
> IRQ4 0x4a 0x4d
>
> If we set mask_base = 0x40 and status_base = 0x44, the offsets of each
> register relative to the base are:
>
> mask status
> IRQ0 0 0
> IRQ1 1 1
> IRQ2 2 2
> IRQ3 3 3
> IRQ4 10 9
>
> The existing mapping mechanisms can't include IRQ4 in the same irqchip
> as IRQ0-3 because the offset of IRQ4's register depends on which type
> of register we're asking for, ie. which base register is used.
>
> The get_irq_reg callback allows drivers to specify an arbitrary mapping
> of (base register, register index) pairs to register addresses, instead
> of the default linear mapping "base_register + register_index". This
> allows unusual layouts, like the one above, to be handled using a single
> regmap IRQ chip.
>
> The drawback is that when get_irq_reg is used, it's impossible to use
> bulk reads for status registers even if some of them are contiguous,
> because the mapping is opaque to regmap-irq. This should be acceptable
> for the case of a few infrequently-polled status registers.
This patch does two things:
1. Add a new callback `get_irq_reg`
2. Replace unmask_offset calculation with call to sub_irq_reg()
Could you please split the patch into two to better reflect this?
Thank you.
Guru Das.
next prev parent reply other threads:[~2022-06-06 17:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 13:57 [PATCH 00/10] Add support for AXP192 PMIC Aidan MacDonald
2022-06-03 13:57 ` [PATCH 01/10] regmap-irq: Add get_irq_reg to support unusual register layouts Aidan MacDonald
2022-06-06 17:43 ` Guru Das Srinagesh [this message]
2022-06-07 10:46 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 02/10] dt-bindings: mfd: add bindings for AXP192 MFD device Aidan MacDonald
2022-06-05 22:49 ` Rob Herring
2022-06-27 11:47 ` Lee Jones
2022-06-03 13:57 ` [PATCH 03/10] dt-bindings: iio: adc: axp209: Add AXP192 compatible Aidan MacDonald
2022-06-03 16:34 ` Jonathan Cameron
2022-06-04 11:33 ` Aidan MacDonald
2022-06-05 22:50 ` Rob Herring
2022-06-03 13:57 ` [PATCH 04/10] dt-bindings: power: supply: axp20x: " Aidan MacDonald
2022-06-05 22:50 ` Rob Herring
2022-06-03 13:57 ` [PATCH 05/10] dt-bindings: gpio: Add AXP192 GPIO bindings Aidan MacDonald
2022-06-05 22:55 ` Rob Herring
2022-06-07 10:34 ` Aidan MacDonald
2022-06-07 15:17 ` Rob Herring
2022-06-07 15:40 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 06/10] mfd: axp20x: Add support for AXP192 Aidan MacDonald
2022-06-27 11:54 ` Lee Jones
2022-06-27 13:02 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 07/10] regulator: " Aidan MacDonald
2022-06-06 14:36 ` Mark Brown
2022-06-03 13:57 ` [PATCH 08/10] iio: adc: axp20x_adc: " Aidan MacDonald
2022-06-03 16:47 ` Jonathan Cameron
2022-06-04 11:47 ` Aidan MacDonald
2022-06-04 14:27 ` Jonathan Cameron
2022-06-07 10:49 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 09/10] power: supply: axp20x_usb_power: " Aidan MacDonald
2022-06-05 15:13 ` kernel test robot
2022-06-03 13:57 ` [PATCH 10/10] pinctrl: Add AXP192 pin control driver Aidan MacDonald
2022-06-15 13:44 ` Linus Walleij
2022-06-15 18:06 ` Michael Walle
2022-06-15 14:51 ` Andy Shevchenko
2022-06-17 12:15 ` Aidan MacDonald
2022-06-17 16:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606174320.GA16522@quicinc.com \
--to=quic_gurus@quicinc.com \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).