From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
lee.jones@linaro.org, sre@kernel.org, broonie@kernel.org,
gregkh@linuxfoundation.org, lgirdwood@gmail.com, lars@metafoo.de,
rafael@kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] dt-bindings: iio: adc: axp209: Add AXP192 compatible
Date: Sat, 04 Jun 2022 12:33:25 +0100 [thread overview]
Message-ID: <t8jiSeLliI9SkNKKcN2aBMxSntde4pn7@localhost> (raw)
In-Reply-To: <20220603173404.4cb83647@jic23-huawei>
Jonathan Cameron <jic23@kernel.org> writes:
> On Fri, 3 Jun 2022 14:57:07 +0100
> Aidan MacDonald <aidanmacdonald.0x0@gmail.com> wrote:
>
>> The AXP192 is identical to the AXP20x, except for two additional
>> GPIO ADC channels.
>>
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>
> There is an argument that could be made here to say this should
> have a fallback compatible to a suitable existing part as the driver
> would work, we'd just be missing a couple of channels.
>
> I don't feel strongly either way, but thought I'd raise the possibility.
>
> I guess it's irrelevant if an updated kernel is needed anyway to have
> it functional because of support needed for some other part of the chip
> though.
>
> Jonathan
>
That may be possible, but you can't probe the IIO driver without having
an updated MFD driver so I'm not sure a fallback compatible is needed.
Regards,
Aidan
>> ---
>> .../bindings/iio/adc/x-powers,axp209-adc.yaml | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
>> index d6d3d8590171..1a68e650ac7d 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml
>> @@ -14,6 +14,23 @@ description: |
>> Device is a child of an axp209 multifunction device
>> ADC channels and their indexes per variant:
>>
>> + AXP192
>> + ------
>> + 0 | acin_v
>> + 1 | acin_i
>> + 2 | vbus_v
>> + 3 | vbus_i
>> + 4 | pmic_temp
>> + 5 | gpio0_v
>> + 6 | gpio1_v
>> + 7 | gpio2_v
>> + 8 | gpio3_v
>> + 9 | ipsout_v
>> + 10 | batt_v
>> + 11 | batt_chrg_i
>> + 12 | batt_dischrg_i
>> + 13 | ts_v
>> +
>> AXP209
>> ------
>> 0 | acin_v
>> @@ -50,6 +67,7 @@ description: |
>> properties:
>> compatible:
>> oneOf:
>> + - const: x-powers,axp192-adc
>> - const: x-powers,axp209-adc
>> - const: x-powers,axp221-adc
>> - const: x-powers,axp813-adc
next prev parent reply other threads:[~2022-06-04 11:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 13:57 [PATCH 00/10] Add support for AXP192 PMIC Aidan MacDonald
2022-06-03 13:57 ` [PATCH 01/10] regmap-irq: Add get_irq_reg to support unusual register layouts Aidan MacDonald
2022-06-06 17:43 ` Guru Das Srinagesh
2022-06-07 10:46 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 02/10] dt-bindings: mfd: add bindings for AXP192 MFD device Aidan MacDonald
2022-06-05 22:49 ` Rob Herring
2022-06-27 11:47 ` Lee Jones
2022-06-03 13:57 ` [PATCH 03/10] dt-bindings: iio: adc: axp209: Add AXP192 compatible Aidan MacDonald
2022-06-03 16:34 ` Jonathan Cameron
2022-06-04 11:33 ` Aidan MacDonald [this message]
2022-06-05 22:50 ` Rob Herring
2022-06-03 13:57 ` [PATCH 04/10] dt-bindings: power: supply: axp20x: " Aidan MacDonald
2022-06-05 22:50 ` Rob Herring
2022-06-03 13:57 ` [PATCH 05/10] dt-bindings: gpio: Add AXP192 GPIO bindings Aidan MacDonald
2022-06-05 22:55 ` Rob Herring
2022-06-07 10:34 ` Aidan MacDonald
2022-06-07 15:17 ` Rob Herring
2022-06-07 15:40 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 06/10] mfd: axp20x: Add support for AXP192 Aidan MacDonald
2022-06-27 11:54 ` Lee Jones
2022-06-27 13:02 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 07/10] regulator: " Aidan MacDonald
2022-06-06 14:36 ` Mark Brown
2022-06-03 13:57 ` [PATCH 08/10] iio: adc: axp20x_adc: " Aidan MacDonald
2022-06-03 16:47 ` Jonathan Cameron
2022-06-04 11:47 ` Aidan MacDonald
2022-06-04 14:27 ` Jonathan Cameron
2022-06-07 10:49 ` Aidan MacDonald
2022-06-03 13:57 ` [PATCH 09/10] power: supply: axp20x_usb_power: " Aidan MacDonald
2022-06-05 15:13 ` kernel test robot
2022-06-03 13:57 ` [PATCH 10/10] pinctrl: Add AXP192 pin control driver Aidan MacDonald
2022-06-15 13:44 ` Linus Walleij
2022-06-15 18:06 ` Michael Walle
2022-06-15 14:51 ` Andy Shevchenko
2022-06-17 12:15 ` Aidan MacDonald
2022-06-17 16:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=t8jiSeLliI9SkNKKcN2aBMxSntde4pn7@localhost \
--to=aidanmacdonald.0x0@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).