* [PATCH] s390/kvm: avoid hypfs error message
@ 2022-06-07 12:33 Juergen Gross
2022-06-20 6:03 ` Juergen Gross
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2022-06-07 12:33 UTC (permalink / raw)
To: linux-s390, linux-kernel
Cc: Juergen Gross, Heiko Carstens, Vasily Gorbik, Alexander Gordeev,
Christian Borntraeger, Sven Schnelle
When booting under KVM the following error messages are issued:
hypfs.7f5705: The hardware system does not support hypfs
hypfs.7a79f0: Initialization of hypfs failed with rc=-61
While being documented, they can easily be avoided by bailing out of
hypfs_init() early in case of running as a KVM guest.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/s390/hypfs/inode.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
index 5c97f48cea91..bdf078f3c641 100644
--- a/arch/s390/hypfs/inode.c
+++ b/arch/s390/hypfs/inode.c
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
{
int rc;
+ if (MACHINE_IS_KVM)
+ return -ENODATA;
+
hypfs_dbfs_init();
if (hypfs_diag_init()) {
--
2.35.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/kvm: avoid hypfs error message
2022-06-07 12:33 [PATCH] s390/kvm: avoid hypfs error message Juergen Gross
@ 2022-06-20 6:03 ` Juergen Gross
2022-06-20 7:18 ` Christian Borntraeger
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2022-06-20 6:03 UTC (permalink / raw)
To: linux-s390, linux-kernel, Heiko Carstens, Alexander Gordeev,
Christian Borntraeger, Vasily Gorbik, Sven Schnelle
[-- Attachment #1.1.1: Type: text/plain, Size: 890 bytes --]
Ping?
On 07.06.22 14:33, Juergen Gross wrote:
> When booting under KVM the following error messages are issued:
>
> hypfs.7f5705: The hardware system does not support hypfs
> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>
> While being documented, they can easily be avoided by bailing out of
> hypfs_init() early in case of running as a KVM guest.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/s390/hypfs/inode.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
> index 5c97f48cea91..bdf078f3c641 100644
> --- a/arch/s390/hypfs/inode.c
> +++ b/arch/s390/hypfs/inode.c
> @@ -464,6 +464,9 @@ static int __init hypfs_init(void)
> {
> int rc;
>
> + if (MACHINE_IS_KVM)
> + return -ENODATA;
> +
> hypfs_dbfs_init();
>
> if (hypfs_diag_init()) {
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/kvm: avoid hypfs error message
2022-06-20 6:03 ` Juergen Gross
@ 2022-06-20 7:18 ` Christian Borntraeger
2022-06-20 9:19 ` Heiko Carstens
0 siblings, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2022-06-20 7:18 UTC (permalink / raw)
To: Juergen Gross, linux-s390, linux-kernel, Heiko Carstens,
Alexander Gordeev, Vasily Gorbik, Sven Schnelle
Am 20.06.22 um 08:03 schrieb Juergen Gross:
> Ping?
>
> On 07.06.22 14:33, Juergen Gross wrote:
>> When booting under KVM the following error messages are issued:
>>
>> hypfs.7f5705: The hardware system does not support hypfs
>> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>>
>> While being documented, they can easily be avoided by bailing out of
>> hypfs_init() early in case of running as a KVM guest.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> arch/s390/hypfs/inode.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
>> index 5c97f48cea91..bdf078f3c641 100644
>> --- a/arch/s390/hypfs/inode.c
>> +++ b/arch/s390/hypfs/inode.c
>> @@ -464,6 +464,9 @@ static int __init hypfs_init(void)
>> {
>> int rc;
>> + if (MACHINE_IS_KVM)
>> + return -ENODATA;
>> +
>> hypfs_dbfs_init();
>> if (hypfs_diag_init()) {
In case KVM implements hypfs this check would then be wrong.
Question to people on CC/TO.
Would it be an option to still check with KVM but avoid the error message.
So basically changing hypfs_diag_init and fail_dbfs_exit to check
for KVM on error?
Or is this worse?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/kvm: avoid hypfs error message
2022-06-20 7:18 ` Christian Borntraeger
@ 2022-06-20 9:19 ` Heiko Carstens
2022-06-20 9:25 ` Juergen Gross
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2022-06-20 9:19 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Juergen Gross, linux-s390, linux-kernel, Alexander Gordeev,
Vasily Gorbik, Sven Schnelle
On Mon, Jun 20, 2022 at 09:18:37AM +0200, Christian Borntraeger wrote:
> Am 20.06.22 um 08:03 schrieb Juergen Gross:
> > Ping?
> >
> > On 07.06.22 14:33, Juergen Gross wrote:
> > > When booting under KVM the following error messages are issued:
> > >
> > > hypfs.7f5705: The hardware system does not support hypfs
> > > hypfs.7a79f0: Initialization of hypfs failed with rc=-61
> > >
> > > While being documented, they can easily be avoided by bailing out of
> > > hypfs_init() early in case of running as a KVM guest.
> > >
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > ---
> > > arch/s390/hypfs/inode.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
> > > index 5c97f48cea91..bdf078f3c641 100644
> > > --- a/arch/s390/hypfs/inode.c
> > > +++ b/arch/s390/hypfs/inode.c
> > > @@ -464,6 +464,9 @@ static int __init hypfs_init(void)
> > > {
> > > int rc;
> > > + if (MACHINE_IS_KVM)
> > > + return -ENODATA;
> > > +
> > > hypfs_dbfs_init();
> > > if (hypfs_diag_init()) {
>
> In case KVM implements hypfs this check would then be wrong.
> Question to people on CC/TO.
> Would it be an option to still check with KVM but avoid the error message.
> So basically changing hypfs_diag_init and fail_dbfs_exit to check
> for KVM on error?
> Or is this worse?
I'd say just move the pr_err("Initialization of hypfs failed with...")
one label above to fail_hypfs_diag_exit. Then we still get the message
that the hardware system doesn't support hypfs, which seems to be
wanted, and the error message only appears for an error.
Even though I personally dislike printing everything to the console
this seems to be what is/was preferred. So let's keep that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/kvm: avoid hypfs error message
2022-06-20 9:19 ` Heiko Carstens
@ 2022-06-20 9:25 ` Juergen Gross
2022-06-20 9:28 ` Christian Borntraeger
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2022-06-20 9:25 UTC (permalink / raw)
To: Heiko Carstens, Christian Borntraeger
Cc: linux-s390, linux-kernel, Alexander Gordeev, Vasily Gorbik,
Sven Schnelle
[-- Attachment #1.1.1: Type: text/plain, Size: 2282 bytes --]
On 20.06.22 11:19, Heiko Carstens wrote:
> On Mon, Jun 20, 2022 at 09:18:37AM +0200, Christian Borntraeger wrote:
>> Am 20.06.22 um 08:03 schrieb Juergen Gross:
>>> Ping?
>>>
>>> On 07.06.22 14:33, Juergen Gross wrote:
>>>> When booting under KVM the following error messages are issued:
>>>>
>>>> hypfs.7f5705: The hardware system does not support hypfs
>>>> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>>>>
>>>> While being documented, they can easily be avoided by bailing out of
>>>> hypfs_init() early in case of running as a KVM guest.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>> ---
>>>> arch/s390/hypfs/inode.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
>>>> index 5c97f48cea91..bdf078f3c641 100644
>>>> --- a/arch/s390/hypfs/inode.c
>>>> +++ b/arch/s390/hypfs/inode.c
>>>> @@ -464,6 +464,9 @@ static int __init hypfs_init(void)
>>>> {
>>>> int rc;
>>>> + if (MACHINE_IS_KVM)
>>>> + return -ENODATA;
>>>> +
>>>> hypfs_dbfs_init();
>>>> if (hypfs_diag_init()) {
>>
>> In case KVM implements hypfs this check would then be wrong.
>> Question to people on CC/TO.
>> Would it be an option to still check with KVM but avoid the error message.
>> So basically changing hypfs_diag_init and fail_dbfs_exit to check
>> for KVM on error?
>> Or is this worse?
>
> I'd say just move the pr_err("Initialization of hypfs failed with...")
> one label above to fail_hypfs_diag_exit. Then we still get the message
> that the hardware system doesn't support hypfs, which seems to be
> wanted, and the error message only appears for an error.
>
> Even though I personally dislike printing everything to the console
> this seems to be what is/was preferred. So let's keep that.
Works for me.
Would you be fine with additionally:
@@ __init int hypfs_diag_init(void)
int rc;
if (diag204_probe()) {
- pr_err("The hardware system does not support hypfs\n");
+ pr_info("The hardware system does not support hypfs\n");
return -ENODATA;
}
As this not really an error.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] s390/kvm: avoid hypfs error message
2022-06-20 9:25 ` Juergen Gross
@ 2022-06-20 9:28 ` Christian Borntraeger
0 siblings, 0 replies; 6+ messages in thread
From: Christian Borntraeger @ 2022-06-20 9:28 UTC (permalink / raw)
To: Juergen Gross, Heiko Carstens
Cc: linux-s390, linux-kernel, Alexander Gordeev, Vasily Gorbik,
Sven Schnelle
Am 20.06.22 um 11:25 schrieb Juergen Gross:
> On 20.06.22 11:19, Heiko Carstens wrote:
>> On Mon, Jun 20, 2022 at 09:18:37AM +0200, Christian Borntraeger wrote:
>>> Am 20.06.22 um 08:03 schrieb Juergen Gross:
>>>> Ping?
>>>>
>>>> On 07.06.22 14:33, Juergen Gross wrote:
>>>>> When booting under KVM the following error messages are issued:
>>>>>
>>>>> hypfs.7f5705: The hardware system does not support hypfs
>>>>> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>>>>>
>>>>> While being documented, they can easily be avoided by bailing out of
>>>>> hypfs_init() early in case of running as a KVM guest.
>>>>>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>> ---
>>>>> arch/s390/hypfs/inode.c | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
>>>>> index 5c97f48cea91..bdf078f3c641 100644
>>>>> --- a/arch/s390/hypfs/inode.c
>>>>> +++ b/arch/s390/hypfs/inode.c
>>>>> @@ -464,6 +464,9 @@ static int __init hypfs_init(void)
>>>>> {
>>>>> int rc;
>>>>> + if (MACHINE_IS_KVM)
>>>>> + return -ENODATA;
>>>>> +
>>>>> hypfs_dbfs_init();
>>>>> if (hypfs_diag_init()) {
>>>
>>> In case KVM implements hypfs this check would then be wrong.
>>> Question to people on CC/TO.
>>> Would it be an option to still check with KVM but avoid the error message.
>>> So basically changing hypfs_diag_init and fail_dbfs_exit to check
>>> for KVM on error?
>>> Or is this worse?
>>
>> I'd say just move the pr_err("Initialization of hypfs failed with...")
>> one label above to fail_hypfs_diag_exit. Then we still get the message
>> that the hardware system doesn't support hypfs, which seems to be
>> wanted, and the error message only appears for an error.
>>
>> Even though I personally dislike printing everything to the console
>> this seems to be what is/was preferred. So let's keep that.
>
> Works for me.
>
> Would you be fine with additionally:
>
> @@ __init int hypfs_diag_init(void)
> int rc;
>
> if (diag204_probe()) {
> - pr_err("The hardware system does not support hypfs\n");
> + pr_info("The hardware system does not support hypfs\n");
> return -ENODATA;
> }
>
> As this not really an error.
Yes, makes sense.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-20 9:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 12:33 [PATCH] s390/kvm: avoid hypfs error message Juergen Gross
2022-06-20 6:03 ` Juergen Gross
2022-06-20 7:18 ` Christian Borntraeger
2022-06-20 9:19 ` Heiko Carstens
2022-06-20 9:25 ` Juergen Gross
2022-06-20 9:28 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).