[PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

[PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

[Li Zhengyu]

(!ret) has been checked, so remove (ret).

Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
---
 drivers/clk/qcom/clk-rpmh.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index aed907982344..6d207f7e943d 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -207,10 +207,7 @@ static int clk_rpmh_aggregate_state_send_command(struct clk_rpmh *c,
 	if (!ret)
 		return 0;
 
-	if (ret && enable)
-		c->state = 0;
-	else if (ret)
-		c->state = c->valid_state_mask;
+	c->state = enable ? 0 : c->valid_state_mask;
 
 	WARN(1, "clk: %s failed to %s\n", c->res_name,
 	     enable ? "enable" : "disable");
-- 
2.17.1

Re: [PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

[Stephen Boyd]

Quoting Li Zhengyu (2022-05-31 01:56:11)
> (!ret) has been checked, so remove (ret).
> 
> Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

Re: [PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

[Stephen Boyd]

Quoting Li Zhengyu (2022-06-12 23:33:27)
> By the clk framework already reference counts prepare/unprepare,
> this if statement should be never true.
> 
> Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

[PATCH] clk: qcom: clk-rpmh: Remove redundant if statement

[Li Zhengyu]

By the clk framework already reference counts prepare/unprepare,
this if statement should be never true.

Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
---
Previous threads: 
https://lore.kernel.org/all/20220531094539.252642-1-lizhengyu3@huawei.com/

 drivers/clk/qcom/clk-rpmh.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index aed907982344..249146947923 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -195,10 +195,6 @@ static int clk_rpmh_aggregate_state_send_command(struct clk_rpmh *c,
 {
 	int ret;
 
-	/* Nothing required to be done if already off or on */
-	if (enable == c->state)
-		return 0;
-
 	c->state = enable ? c->valid_state_mask : 0;
 	c->aggr_state = c->state | c->peer->state;
 	c->peer->aggr_state = c->aggr_state;
-- 
2.17.1