* [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist
@ 2022-06-12 4:18 Armin Wolf
2022-06-12 8:26 ` Pali Rohár
2022-06-12 13:08 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Armin Wolf @ 2022-06-12 4:18 UTC (permalink / raw)
To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
A user reported that the program dell-bios-fan-control
worked on his Dell XPS 13 7390 to switch off automatic
fan control.
Since it uses the same mechanism as the dell_smm_hwmon
module, add this model to the fan control whitelist.
Compile-tested only.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 071aa6f4e109..16c10ac84a91 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell XPS 13 7390",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{ }
};
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist
2022-06-12 4:18 [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist Armin Wolf
@ 2022-06-12 8:26 ` Pali Rohár
2022-06-12 13:08 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2022-06-12 8:26 UTC (permalink / raw)
To: Armin Wolf; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
On Sunday 12 June 2022 06:18:06 Armin Wolf wrote:
> A user reported that the program dell-bios-fan-control
> worked on his Dell XPS 13 7390 to switch off automatic
> fan control.
> Since it uses the same mechanism as the dell_smm_hwmon
> module, add this model to the fan control whitelist.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 071aa6f4e109..16c10ac84a91 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell XPS 13 7390",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> { }
> };
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist
2022-06-12 4:18 [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist Armin Wolf
2022-06-12 8:26 ` Pali Rohár
@ 2022-06-12 13:08 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-06-12 13:08 UTC (permalink / raw)
To: Armin Wolf; +Cc: pali, jdelvare, linux-hwmon, linux-kernel
On Sun, Jun 12, 2022 at 06:18:06AM +0200, Armin Wolf wrote:
> A user reported that the program dell-bios-fan-control
> worked on his Dell XPS 13 7390 to switch off automatic
> fan control.
> Since it uses the same mechanism as the dell_smm_hwmon
> module, add this model to the fan control whitelist.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Acked-by: Pali Rohár <pali@kernel.org>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 071aa6f4e109..16c10ac84a91 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell XPS 13 7390",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> { }
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-12 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-12 4:18 [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist Armin Wolf
2022-06-12 8:26 ` Pali Rohár
2022-06-12 13:08 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).