* [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init()
@ 2022-06-14 11:21 Yang Yingliang
2022-06-24 14:36 ` Paul Kocialkowski
0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2022-06-14 11:21 UTC (permalink / raw)
To: linux-kernel, dri-devel; +Cc: paul.kocialkowski, airlied, daniel, mripard
The of_node_put() need be called in error path in logicvc_layers_init().
Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index bae1c7f99569..00a37563a6dc 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
}
ret = logicvc_layer_init(logicvc, layer_node, index);
- if (ret)
+ if (ret) {
+ of_node_put(layer_node);
+ of_node_put(layers_node);
goto error;
+ }
of_node_put(layer_node);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init()
2022-06-14 11:21 [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init() Yang Yingliang
@ 2022-06-24 14:36 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
0 siblings, 1 reply; 3+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 14:36 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, dri-devel, airlied, daniel, mripard
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
Hi Yang,
On Tue 14 Jun 22, 19:21, Yang Yingliang wrote:
> The of_node_put() need be called in error path in logicvc_layers_init().
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Thanks for the fix!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index bae1c7f99569..00a37563a6dc 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
> }
>
> ret = logicvc_layer_init(logicvc, layer_node, index);
> - if (ret)
> + if (ret) {
> + of_node_put(layer_node);
> + of_node_put(layers_node);
> goto error;
> + }
>
> of_node_put(layer_node);
> }
> --
> 2.25.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init()
2022-06-24 14:36 ` Paul Kocialkowski
@ 2022-06-24 15:25 ` Paul Kocialkowski
0 siblings, 0 replies; 3+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 15:25 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, dri-devel, airlied, daniel, mripard
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
Hi,
On Fri 24 Jun 22, 16:36, Paul Kocialkowski wrote:
> Hi Yang,
>
> On Tue 14 Jun 22, 19:21, Yang Yingliang wrote:
> > The of_node_put() need be called in error path in logicvc_layers_init().
> >
> > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> Thanks for the fix!
>
> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Adapted this after Julia's patch: Only the put on layers_node is required
on error condition.
Pushed to drm-misc-next, thanks!
Paul
> > ---
> > drivers/gpu/drm/logicvc/logicvc_layer.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> > index bae1c7f99569..00a37563a6dc 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> > @@ -610,8 +610,11 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
> > }
> >
> > ret = logicvc_layer_init(logicvc, layer_node, index);
> > - if (ret)
> > + if (ret) {
> > + of_node_put(layer_node);
> > + of_node_put(layers_node);
> > goto error;
> > + }
> >
> > of_node_put(layer_node);
> > }
> > --
> > 2.25.1
> >
>
> --
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-24 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 11:21 [PATCH -next] drm/logicvc: add missing of_node_put() in logicvc_layers_init() Yang Yingliang
2022-06-24 14:36 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).