linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: at91: sama5d2: fix compilation warning
@ 2022-06-15  8:06 Claudiu Beznea
  2022-06-15  8:06 ` [PATCH 2/2] " Claudiu Beznea
  2022-07-04  6:46 ` [PATCH 1/2] " Claudiu.Beznea
  0 siblings, 2 replies; 4+ messages in thread
From: Claudiu Beznea @ 2022-06-15  8:06 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, robh+dt, krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, Claudiu Beznea

Fix the following compilation warning:
Warning (simple_bus_reg): /ahb/apb/resistive-touch: missing or empty reg/ranges property

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/sama5d2.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 89c71d419f82..b147db8b973f 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -99,6 +99,16 @@ ns_sram: sram@200000 {
 		ranges = <0 0x00200000 0x20000>;
 	};
 
+	resistive_touch: resistive-touch {
+		compatible = "resistive-adc-touch";
+		io-channels = <&adc AT91_SAMA5D2_ADC_X_CHANNEL>,
+			      <&adc AT91_SAMA5D2_ADC_Y_CHANNEL>,
+			      <&adc AT91_SAMA5D2_ADC_P_CHANNEL>;
+		io-channel-names = "x", "y", "pressure";
+		touchscreen-min-pressure = <50000>;
+		status = "disabled";
+	};
+
 	ahb {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -1050,16 +1060,6 @@ adc: adc@fc030000 {
 				status = "disabled";
 			};
 
-			resistive_touch: resistive-touch {
-				compatible = "resistive-adc-touch";
-				io-channels = <&adc AT91_SAMA5D2_ADC_X_CHANNEL>,
-					      <&adc AT91_SAMA5D2_ADC_Y_CHANNEL>,
-					      <&adc AT91_SAMA5D2_ADC_P_CHANNEL>;
-				io-channel-names = "x", "y", "pressure";
-				touchscreen-min-pressure = <50000>;
-				status = "disabled";
-			};
-
 			pioA: pinctrl@fc038000 {
 				compatible = "atmel,sama5d2-pinctrl";
 				reg = <0xfc038000 0x600>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: at91: sama5d2: fix compilation warning
  2022-06-15  8:06 [PATCH 1/2] ARM: dts: at91: sama5d2: fix compilation warning Claudiu Beznea
@ 2022-06-15  8:06 ` Claudiu Beznea
  2022-07-04  6:46   ` Claudiu.Beznea
  2022-07-04  6:46 ` [PATCH 1/2] " Claudiu.Beznea
  1 sibling, 1 reply; 4+ messages in thread
From: Claudiu Beznea @ 2022-06-15  8:06 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, robh+dt, krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, Claudiu Beznea

Fix the following compilation warning:
arch/arm/boot/dts/sama5d2.dtsi:371.29-382.6: Warning
(avoid_unnecessary_addr_size): /ahb/apb/ethernet@f8008000:
unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
also defined at arch/arm/boot/dts/at91-sama5d2_icp.dts:353.8-363.3

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1.dtsi   | 2 ++
 arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 2 ++
 arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts   | 2 ++
 arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 ++
 arch/arm/boot/dts/sama5d2.dtsi              | 2 --
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
index a4623cc67cc1..c365731b2cce 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
@@ -83,6 +83,8 @@ kernel@200000 {
 			macb0: ethernet@f8008000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_macb0_default>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				phy-mode = "rmii";
 
 				ethernet-phy@7 {
diff --git a/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
index ba621783acdb..76b2025c67b4 100644
--- a/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
@@ -194,6 +194,8 @@ regulator-state-mem {
 &macb0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_macb0_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
 	phy-mode = "rmii";
 
 	ethernet-phy@0 {
diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
index 8ed58af01391..88cf125a55ed 100644
--- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
@@ -139,6 +139,8 @@ spi0: spi@f8000000 {
 			macb0: ethernet@f8008000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				phy-mode = "rmii";
 				status = "okay";
 
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index cdfe891f9a9e..bcc3c1bacb25 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -147,6 +147,8 @@ flash@0 {
 			macb0: ethernet@f8008000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				phy-mode = "rmii";
 				status = "okay";
 
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index b147db8b973f..5b2f2e922d40 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -384,8 +384,6 @@ macb0: ethernet@f8008000 {
 				interrupts = <5  IRQ_TYPE_LEVEL_HIGH 3		/* Queue 0 */
 					      66 IRQ_TYPE_LEVEL_HIGH 3          /* Queue 1 */
 					      67 IRQ_TYPE_LEVEL_HIGH 3>;        /* Queue 2 */
-				#address-cells = <1>;
-				#size-cells = <0>;
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 5>, <&pmc PMC_TYPE_PERIPHERAL 5>;
 				clock-names = "hclk", "pclk";
 				status = "disabled";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: dts: at91: sama5d2: fix compilation warning
  2022-06-15  8:06 [PATCH 1/2] ARM: dts: at91: sama5d2: fix compilation warning Claudiu Beznea
  2022-06-15  8:06 ` [PATCH 2/2] " Claudiu Beznea
@ 2022-07-04  6:46 ` Claudiu.Beznea
  1 sibling, 0 replies; 4+ messages in thread
From: Claudiu.Beznea @ 2022-07-04  6:46 UTC (permalink / raw)
  To: Nicolas.Ferre, alexandre.belloni, robh+dt, krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel

On 15.06.2022 11:06, Claudiu Beznea wrote:
> Fix the following compilation warning:
> Warning (simple_bus_reg): /ahb/apb/resistive-touch: missing or empty reg/ranges property
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Applied to at91-dt, thanks!

> ---
>  arch/arm/boot/dts/sama5d2.dtsi | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..b147db8b973f 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -99,6 +99,16 @@ ns_sram: sram@200000 {
>  		ranges = <0 0x00200000 0x20000>;
>  	};
>  
> +	resistive_touch: resistive-touch {
> +		compatible = "resistive-adc-touch";
> +		io-channels = <&adc AT91_SAMA5D2_ADC_X_CHANNEL>,
> +			      <&adc AT91_SAMA5D2_ADC_Y_CHANNEL>,
> +			      <&adc AT91_SAMA5D2_ADC_P_CHANNEL>;
> +		io-channel-names = "x", "y", "pressure";
> +		touchscreen-min-pressure = <50000>;
> +		status = "disabled";
> +	};
> +
>  	ahb {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
> @@ -1050,16 +1060,6 @@ adc: adc@fc030000 {
>  				status = "disabled";
>  			};
>  
> -			resistive_touch: resistive-touch {
> -				compatible = "resistive-adc-touch";
> -				io-channels = <&adc AT91_SAMA5D2_ADC_X_CHANNEL>,
> -					      <&adc AT91_SAMA5D2_ADC_Y_CHANNEL>,
> -					      <&adc AT91_SAMA5D2_ADC_P_CHANNEL>;
> -				io-channel-names = "x", "y", "pressure";
> -				touchscreen-min-pressure = <50000>;
> -				status = "disabled";
> -			};
> -
>  			pioA: pinctrl@fc038000 {
>  				compatible = "atmel,sama5d2-pinctrl";
>  				reg = <0xfc038000 0x600>;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: at91: sama5d2: fix compilation warning
  2022-06-15  8:06 ` [PATCH 2/2] " Claudiu Beznea
@ 2022-07-04  6:46   ` Claudiu.Beznea
  0 siblings, 0 replies; 4+ messages in thread
From: Claudiu.Beznea @ 2022-07-04  6:46 UTC (permalink / raw)
  To: Nicolas.Ferre, alexandre.belloni, robh+dt, krzysztof.kozlowski+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel

On 15.06.2022 11:06, Claudiu Beznea wrote:
> Fix the following compilation warning:
> arch/arm/boot/dts/sama5d2.dtsi:371.29-382.6: Warning
> (avoid_unnecessary_addr_size): /ahb/apb/ethernet@f8008000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> also defined at arch/arm/boot/dts/at91-sama5d2_icp.dts:353.8-363.3
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Applied to at91-dt, thanks!

> ---
>  arch/arm/boot/dts/at91-sama5d27_som1.dtsi   | 2 ++
>  arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 2 ++
>  arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts   | 2 ++
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 ++
>  arch/arm/boot/dts/sama5d2.dtsi              | 2 --
>  5 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> index a4623cc67cc1..c365731b2cce 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi
> @@ -83,6 +83,8 @@ kernel@200000 {
>  			macb0: ethernet@f8008000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_macb0_default>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				phy-mode = "rmii";
>  
>  				ethernet-phy@7 {
> diff --git a/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi b/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
> index ba621783acdb..76b2025c67b4 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi
> @@ -194,6 +194,8 @@ regulator-state-mem {
>  &macb0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_macb0_default>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  	phy-mode = "rmii";
>  
>  	ethernet-phy@0 {
> diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> index 8ed58af01391..88cf125a55ed 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> @@ -139,6 +139,8 @@ spi0: spi@f8000000 {
>  			macb0: ethernet@f8008000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				phy-mode = "rmii";
>  				status = "okay";
>  
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index cdfe891f9a9e..bcc3c1bacb25 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -147,6 +147,8 @@ flash@0 {
>  			macb0: ethernet@f8008000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				phy-mode = "rmii";
>  				status = "okay";
>  
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index b147db8b973f..5b2f2e922d40 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -384,8 +384,6 @@ macb0: ethernet@f8008000 {
>  				interrupts = <5  IRQ_TYPE_LEVEL_HIGH 3		/* Queue 0 */
>  					      66 IRQ_TYPE_LEVEL_HIGH 3          /* Queue 1 */
>  					      67 IRQ_TYPE_LEVEL_HIGH 3>;        /* Queue 2 */
> -				#address-cells = <1>;
> -				#size-cells = <0>;
>  				clocks = <&pmc PMC_TYPE_PERIPHERAL 5>, <&pmc PMC_TYPE_PERIPHERAL 5>;
>  				clock-names = "hclk", "pclk";
>  				status = "disabled";


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-04  6:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15  8:06 [PATCH 1/2] ARM: dts: at91: sama5d2: fix compilation warning Claudiu Beznea
2022-06-15  8:06 ` [PATCH 2/2] " Claudiu Beznea
2022-07-04  6:46   ` Claudiu.Beznea
2022-07-04  6:46 ` [PATCH 1/2] " Claudiu.Beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).