[PATCH] drivers: clk: Add missing of_node_put() in clk-nomadik.c

[PATCH] drivers: clk: Add missing of_node_put() in clk-nomadik.c

[heliang]

In nomadik_src_init, of_find_matching_node() return a node pointer
with refcount incremented. We should use of_node_put() in fail path
or when it is not used anymore.

Signed-off-by: heliang <windhl@126.com>
---
 drivers/clk/clk-nomadik.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index bad2677e11ae..b3b8855d8890 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -97,6 +97,7 @@ static void __init nomadik_src_init(void)
 	}
 	src_base = of_iomap(np, 0);
 	if (!src_base) {
+		of_node_put(np);
 		pr_err("%s: must have src parent node with REGS (%pOFn)\n",
 		       __func__, np);
 		return;
@@ -130,6 +131,7 @@ static void __init nomadik_src_init(void)
 		val &= ~SRC_XTALCR_MXTALEN;
 		pr_info("disabling MXTALO\n");
 	}
+	of_node_put(np);
 	writel(val, src_base + SRC_XTALCR);
 	register_reboot_notifier(&nomadik_clk_reboot_notifier);
 }
-- 
2.25.1

Re: [PATCH] drivers: clk: Add missing of_node_put() in clk-nomadik.c

[Linus Walleij]

On Wed, Jun 15, 2022 at 10:30 AM heliang <windhl@126.com> wrote:

> In nomadik_src_init, of_find_matching_node() return a node pointer
> with refcount incremented. We should use of_node_put() in fail path
> or when it is not used anymore.
>
> Signed-off-by: heliang <windhl@126.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij