[PATCH] clk: samsung: Add check for platform_driver_register

[PATCH] clk: samsung: Add check for platform_driver_register

[Jiasheng Jiang]

As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.

Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/clk/samsung/clk-exynos5-subcmu.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos5-subcmu.c b/drivers/clk/samsung/clk-exynos5-subcmu.c
index 65c82d922b05..8b090481a9dc 100644
--- a/drivers/clk/samsung/clk-exynos5-subcmu.c
+++ b/drivers/clk/samsung/clk-exynos5-subcmu.c
@@ -188,8 +188,18 @@ static struct platform_driver exynos5_clk_driver __refdata = {
 
 static int __init exynos5_clk_drv_init(void)
 {
-	platform_driver_register(&exynos5_clk_driver);
-	platform_driver_register(&exynos5_subcmu_driver);
+	int ret;
+
+	ret = platform_driver_register(&exynos5_clk_driver);
+	if (ret)
+		return ret;
+
+	ret = platform_driver_register(&exynos5_subcmu_driver);
+	if (ret) {
+		platform_driver_unregister(&exynos5_clk_driver);
+		return ret;
+	}
+
 	return 0;
 }
 core_initcall(exynos5_clk_drv_init);
-- 
2.25.1

Re: [PATCH] clk: samsung: Add check for platform_driver_register

[Chanwoo Choi]

On 5/26/22 7:12 PM, Jiasheng Jiang wrote:
> As platform_driver_register() could fail, it should be better
> to deal with the return value in order to maintain the code
> consisitency.
> 
> Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/clk/samsung/clk-exynos5-subcmu.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos5-subcmu.c b/drivers/clk/samsung/clk-exynos5-subcmu.c
> index 65c82d922b05..8b090481a9dc 100644
> --- a/drivers/clk/samsung/clk-exynos5-subcmu.c
> +++ b/drivers/clk/samsung/clk-exynos5-subcmu.c
> @@ -188,8 +188,18 @@ static struct platform_driver exynos5_clk_driver __refdata = {
>  
>  static int __init exynos5_clk_drv_init(void)
>  {
> -	platform_driver_register(&exynos5_clk_driver);
> -	platform_driver_register(&exynos5_subcmu_driver);
> +	int ret;
> +
> +	ret = platform_driver_register(&exynos5_clk_driver);
> +	if (ret)
> +		return ret;
> +
> +	ret = platform_driver_register(&exynos5_subcmu_driver);
> +	if (ret) {
> +		platform_driver_unregister(&exynos5_clk_driver);
> +		return ret;
> +	}
> +
>  	return 0;
>  }
>  core_initcall(exynos5_clk_drv_init);
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH] clk: samsung: Add check for platform_driver_register

[Stephen Boyd]

Quoting Jiasheng Jiang (2022-05-26 03:12:15)
> As platform_driver_register() could fail, it should be better
> to deal with the return value in order to maintain the code
> consisitency.
> 
> Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>