* [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c
@ 2022-06-16 14:27 Liang He
2022-06-21 15:14 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-16 14:27 UTC (permalink / raw)
To: tsbogend; +Cc: windhl, linux-mips, linux-kernel
In update_gic_frequency_dt(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/mips/mti-malta/malta-time.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c
index bbf1e38e1431..2cb708cdf01a 100644
--- a/arch/mips/mti-malta/malta-time.c
+++ b/arch/mips/mti-malta/malta-time.c
@@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void)
if (of_update_property(node, &gic_frequency_prop) < 0)
pr_err("error updating gic frequency property\n");
+
+ of_node_put(node);
}
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c
2022-06-16 14:27 [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c Liang He
@ 2022-06-21 15:14 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2022-06-21 15:14 UTC (permalink / raw)
To: Liang He; +Cc: linux-mips, linux-kernel
On Thu, Jun 16, 2022 at 10:27:56PM +0800, Liang He wrote:
> In update_gic_frequency_dt(), of_find_compatible_node() will return
> a node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/mips/mti-malta/malta-time.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c
> index bbf1e38e1431..2cb708cdf01a 100644
> --- a/arch/mips/mti-malta/malta-time.c
> +++ b/arch/mips/mti-malta/malta-time.c
> @@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void)
>
> if (of_update_property(node, &gic_frequency_prop) < 0)
> pr_err("error updating gic frequency property\n");
> +
> + of_node_put(node);
> }
>
> #endif
> --
> 2.25.1
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-21 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 14:27 [PATCH] mips: mti-malta: Fix refcount leak in malta-time.c Liang He
2022-06-21 15:14 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).