From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 2/3] f2fs: run GCs synchronously given user requests
Date: Fri, 17 Jun 2022 15:31:05 -0700 [thread overview]
Message-ID: <20220617223106.3517374-2-jaegeuk@kernel.org> (raw)
In-Reply-To: <20220617223106.3517374-1-jaegeuk@kernel.org>
When users set GC_URGENT or GC_MID, they expected to do GCs right away.
But, there's a condition to bypass it. Let's indicate we need to do now
in the thread.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/gc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index d5fb426e0747..f4aa3c88118b 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -37,7 +37,6 @@ static int gc_thread_func(void *data)
unsigned int wait_ms;
struct f2fs_gc_control gc_control = {
.victim_segno = NULL_SEGNO,
- .should_migrate_blocks = false,
.err_gc_skipped = false };
wait_ms = gc_th->min_sleep_time;
@@ -113,7 +112,10 @@ static int gc_thread_func(void *data)
sbi->gc_mode == GC_URGENT_MID) {
wait_ms = gc_th->urgent_sleep_time;
f2fs_down_write(&sbi->gc_lock);
+ gc_control.should_migrate_blocks = true;
goto do_gc;
+ } else {
+ gc_control.should_migrate_blocks = false;
}
if (foreground) {
@@ -139,7 +141,9 @@ static int gc_thread_func(void *data)
if (!foreground)
stat_inc_bggc_count(sbi->stat_info);
- sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC;
+ sync_mode = F2FS_OPTION(sbi).bggc_mode == BGGC_MODE_SYNC ||
+ sbi->gc_mode == GC_URGENT_HIGH ||
+ sbi->gc_mode == GC_URGENT_MID;
/* foreground GC was been triggered via f2fs_balance_fs() */
if (foreground)
--
2.36.1.476.g0c4daa206d-goog
next prev parent reply other threads:[~2022-06-17 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 22:31 [PATCH 1/3] f2fs: attach inline_data after setting compression Jaegeuk Kim
2022-06-17 22:31 ` Jaegeuk Kim [this message]
2022-06-19 0:41 ` [f2fs-dev] [PATCH 2/3] f2fs: run GCs synchronously given user requests Chao Yu
2022-06-19 22:34 ` Jaegeuk Kim
2022-06-22 14:02 ` Chao Yu
2022-06-22 16:58 ` Jaegeuk Kim
2022-06-28 7:59 ` Chao Yu
2022-06-28 18:17 ` Jaegeuk Kim
2022-06-29 16:30 ` Jaegeuk Kim
2022-06-17 22:31 ` [PATCH 3/3] f2fs: do not skip updating inode when retrying to flush node page Jaegeuk Kim
2022-06-19 0:54 ` [f2fs-dev] " Chao Yu
2022-06-19 0:35 ` [f2fs-dev] [PATCH 1/3] f2fs: attach inline_data after setting compression Chao Yu
2022-06-22 14:06 ` Chao Yu
2022-06-22 16:52 ` Jaegeuk Kim
2022-06-22 16:53 ` [PATCH 1/3 v2] " Jaegeuk Kim
2022-06-28 7:46 ` [f2fs-dev] " Chao Yu
2022-06-28 7:50 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617223106.3517374-2-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).