linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Latypov <dlatypov@google.com>,
	mark.rutland@arm.com, boqun.feng@gmail.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	kunit-dev@googlegroups.com, peterz@infradead.org,
	Daniel Latypov <dlatypov@google.com>,
	David Gow <davidgow@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] lib/atomic64_test.c: convert to use KUnit
Date: Sat, 18 Jun 2022 16:16:53 +0800	[thread overview]
Message-ID: <202206181607.somVaD8p-lkp@intel.com> (raw)
In-Reply-To: <20220616180430.930721-1-dlatypov@google.com>

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 8ab2afa23bd197df47819a87f0265c0ac95c5b6a]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Latypov/lib-atomic64_test-c-convert-to-use-KUnit/20220617-020546
base:   8ab2afa23bd197df47819a87f0265c0ac95c5b6a
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220618/202206181607.somVaD8p-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/acffbe860bc2206b4cef16408809b9f558a24465
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniel-Latypov/lib-atomic64_test-c-convert-to-use-KUnit/20220617-020546
        git checkout acffbe860bc2206b4cef16408809b9f558a24465
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   lib/atomic64_test.c: In function 'test_atomic64':
>> lib/atomic64_test.c:241:1: warning: the frame size of 3920 bytes is larger than 2048 bytes [-Wframe-larger-than=]
     241 | }
         | ^
   lib/atomic64_test.c: In function 'test_atomic':
   lib/atomic64_test.c:138:1: warning: the frame size of 3520 bytes is larger than 2048 bytes [-Wframe-larger-than=]
     138 | }
         | ^


vim +241 lib/atomic64_test.c

41b9e9fcc1c44b Peter Zijlstra   2015-07-13  139  
86a8938078a8bb Luca Barbieri    2010-02-24  140  #define INIT(c) do { atomic64_set(&v, c); r = c; } while (0)
acffbe860bc220 Daniel Latypov   2022-06-16  141  static void test_atomic64(struct kunit *test)
86a8938078a8bb Luca Barbieri    2010-02-24  142  {
86a8938078a8bb Luca Barbieri    2010-02-24  143  	long long v0 = 0xaaa31337c001d00dLL;
86a8938078a8bb Luca Barbieri    2010-02-24  144  	long long v1 = 0xdeadbeefdeafcafeLL;
86a8938078a8bb Luca Barbieri    2010-02-24  145  	long long v2 = 0xfaceabadf00df001LL;
ffba19ccae8d98 Michael Ellerman 2017-07-14  146  	long long v3 = 0x8000000000000000LL;
86a8938078a8bb Luca Barbieri    2010-02-24  147  	long long onestwos = 0x1111111122222222LL;
86a8938078a8bb Luca Barbieri    2010-02-24  148  	long long one = 1LL;
ffba19ccae8d98 Michael Ellerman 2017-07-14  149  	int r_int;
86a8938078a8bb Luca Barbieri    2010-02-24  150  
86a8938078a8bb Luca Barbieri    2010-02-24  151  	atomic64_t v = ATOMIC64_INIT(v0);
86a8938078a8bb Luca Barbieri    2010-02-24  152  	long long r = v0;
acffbe860bc220 Daniel Latypov   2022-06-16  153  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  154  
86a8938078a8bb Luca Barbieri    2010-02-24  155  	atomic64_set(&v, v1);
86a8938078a8bb Luca Barbieri    2010-02-24  156  	r = v1;
acffbe860bc220 Daniel Latypov   2022-06-16  157  	KUNIT_ASSERT_EQ(test, v.counter, r);
acffbe860bc220 Daniel Latypov   2022-06-16  158  	KUNIT_ASSERT_EQ(test, atomic64_read(&v), r);
86a8938078a8bb Luca Barbieri    2010-02-24  159  
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  160  	TEST(64, add, +=, onestwos);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  161  	TEST(64, add, +=, -one);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  162  	TEST(64, sub, -=, onestwos);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  163  	TEST(64, sub, -=, -one);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  164  	TEST(64, or, |=, v1);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  165  	TEST(64, and, &=, v1);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  166  	TEST(64, xor, ^=, v1);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  167  	TEST(64, andnot, &= ~, v1);
86a8938078a8bb Luca Barbieri    2010-02-24  168  
978e5a3692c3b6 Boqun Feng       2015-11-04  169  	RETURN_FAMILY_TEST(64, add_return, +=, onestwos);
978e5a3692c3b6 Boqun Feng       2015-11-04  170  	RETURN_FAMILY_TEST(64, add_return, +=, -one);
978e5a3692c3b6 Boqun Feng       2015-11-04  171  	RETURN_FAMILY_TEST(64, sub_return, -=, onestwos);
978e5a3692c3b6 Boqun Feng       2015-11-04  172  	RETURN_FAMILY_TEST(64, sub_return, -=, -one);
86a8938078a8bb Luca Barbieri    2010-02-24  173  
28aa2bda2211f4 Peter Zijlstra   2016-04-18  174  	FETCH_FAMILY_TEST(64, fetch_add, +=, onestwos);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  175  	FETCH_FAMILY_TEST(64, fetch_add, +=, -one);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  176  	FETCH_FAMILY_TEST(64, fetch_sub, -=, onestwos);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  177  	FETCH_FAMILY_TEST(64, fetch_sub, -=, -one);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  178  
28aa2bda2211f4 Peter Zijlstra   2016-04-18  179  	FETCH_FAMILY_TEST(64, fetch_or,  |=, v1);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  180  	FETCH_FAMILY_TEST(64, fetch_and, &=, v1);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  181  	FETCH_FAMILY_TEST(64, fetch_andnot, &= ~, v1);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  182  	FETCH_FAMILY_TEST(64, fetch_xor, ^=, v1);
28aa2bda2211f4 Peter Zijlstra   2016-04-18  183  
86a8938078a8bb Luca Barbieri    2010-02-24  184  	INIT(v0);
86a8938078a8bb Luca Barbieri    2010-02-24  185  	atomic64_inc(&v);
86a8938078a8bb Luca Barbieri    2010-02-24  186  	r += one;
acffbe860bc220 Daniel Latypov   2022-06-16  187  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  188  
86a8938078a8bb Luca Barbieri    2010-02-24  189  	INIT(v0);
86a8938078a8bb Luca Barbieri    2010-02-24  190  	atomic64_dec(&v);
86a8938078a8bb Luca Barbieri    2010-02-24  191  	r -= one;
acffbe860bc220 Daniel Latypov   2022-06-16  192  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  193  
978e5a3692c3b6 Boqun Feng       2015-11-04  194  	INC_RETURN_FAMILY_TEST(64, v0);
978e5a3692c3b6 Boqun Feng       2015-11-04  195  	DEC_RETURN_FAMILY_TEST(64, v0);
86a8938078a8bb Luca Barbieri    2010-02-24  196  
978e5a3692c3b6 Boqun Feng       2015-11-04  197  	XCHG_FAMILY_TEST(64, v0, v1);
978e5a3692c3b6 Boqun Feng       2015-11-04  198  	CMPXCHG_FAMILY_TEST(64, v0, v1, v2);
86a8938078a8bb Luca Barbieri    2010-02-24  199  
86a8938078a8bb Luca Barbieri    2010-02-24  200  	INIT(v0);
acffbe860bc220 Daniel Latypov   2022-06-16  201  	KUNIT_ASSERT_FALSE(test, atomic64_add_unless(&v, one, v0));
acffbe860bc220 Daniel Latypov   2022-06-16  202  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  203  
86a8938078a8bb Luca Barbieri    2010-02-24  204  	INIT(v0);
acffbe860bc220 Daniel Latypov   2022-06-16  205  	KUNIT_ASSERT_TRUE(test, atomic64_add_unless(&v, one, v1));
86a8938078a8bb Luca Barbieri    2010-02-24  206  	r += one;
acffbe860bc220 Daniel Latypov   2022-06-16  207  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  208  
86a8938078a8bb Luca Barbieri    2010-02-24  209  	INIT(onestwos);
acffbe860bc220 Daniel Latypov   2022-06-16  210  	KUNIT_ASSERT_EQ(test, atomic64_dec_if_positive(&v), (onestwos - 1));
86a8938078a8bb Luca Barbieri    2010-02-24  211  	r -= one;
acffbe860bc220 Daniel Latypov   2022-06-16  212  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  213  
86a8938078a8bb Luca Barbieri    2010-02-24  214  	INIT(0);
acffbe860bc220 Daniel Latypov   2022-06-16  215  	KUNIT_ASSERT_EQ(test, atomic64_dec_if_positive(&v), -one);
acffbe860bc220 Daniel Latypov   2022-06-16  216  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  217  
86a8938078a8bb Luca Barbieri    2010-02-24  218  	INIT(-one);
acffbe860bc220 Daniel Latypov   2022-06-16  219  	KUNIT_ASSERT_EQ(test, atomic64_dec_if_positive(&v), (-one - one));
acffbe860bc220 Daniel Latypov   2022-06-16  220  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  221  
86a8938078a8bb Luca Barbieri    2010-02-24  222  	INIT(onestwos);
acffbe860bc220 Daniel Latypov   2022-06-16  223  	KUNIT_ASSERT_TRUE(test, atomic64_inc_not_zero(&v));
86a8938078a8bb Luca Barbieri    2010-02-24  224  	r += one;
acffbe860bc220 Daniel Latypov   2022-06-16  225  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  226  
86a8938078a8bb Luca Barbieri    2010-02-24  227  	INIT(0);
acffbe860bc220 Daniel Latypov   2022-06-16  228  	KUNIT_ASSERT_FALSE(test, atomic64_inc_not_zero(&v));
acffbe860bc220 Daniel Latypov   2022-06-16  229  	KUNIT_ASSERT_EQ(test, v.counter, r);
86a8938078a8bb Luca Barbieri    2010-02-24  230  
86a8938078a8bb Luca Barbieri    2010-02-24  231  	INIT(-one);
acffbe860bc220 Daniel Latypov   2022-06-16  232  	KUNIT_ASSERT_TRUE(test, atomic64_inc_not_zero(&v));
86a8938078a8bb Luca Barbieri    2010-02-24  233  	r += one;
acffbe860bc220 Daniel Latypov   2022-06-16  234  	KUNIT_ASSERT_EQ(test, v.counter, r);
ffba19ccae8d98 Michael Ellerman 2017-07-14  235  
ffba19ccae8d98 Michael Ellerman 2017-07-14  236  	/* Confirm the return value fits in an int, even if the value doesn't */
ffba19ccae8d98 Michael Ellerman 2017-07-14  237  	INIT(v3);
acffbe860bc220 Daniel Latypov   2022-06-16  238  
ffba19ccae8d98 Michael Ellerman 2017-07-14  239  	r_int = atomic64_inc_not_zero(&v);
acffbe860bc220 Daniel Latypov   2022-06-16  240  	KUNIT_ASSERT_NE(test, r_int, 0);
41b9e9fcc1c44b Peter Zijlstra   2015-07-13 @241  }
41b9e9fcc1c44b Peter Zijlstra   2015-07-13  242  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  parent reply	other threads:[~2022-06-18  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 18:04 [PATCH] lib/atomic64_test.c: convert to use KUnit Daniel Latypov
2022-06-17  8:02 ` David Gow
2022-06-18  8:16 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-02 19:23 Daniel Latypov
2022-05-03  6:13 ` David Gow
2022-05-12 18:52 ` Brendan Higgins
2022-05-13  3:05 ` Michael Ellerman
2022-05-13 16:25   ` Daniel Latypov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206181607.somVaD8p-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=boqun.feng@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).