linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] s390/net: Fix duplicate 'the' in two places
@ 2022-06-21 16:07 Jiang Jian
  2022-06-21 22:32 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Jiang Jian @ 2022-06-21 16:07 UTC (permalink / raw)
  To: wintera, wenjia, hca, gor, agordeev
  Cc: borntraeger, svens, linux-s390, netdev, linux-kernel, Jiang Jian

file: drivers/s390/net/qeth_core_main.c
line: 3568
                /*
                 * there's no outstanding PCI any more, so we
                 * have to request a PCI to be sure the the PCI
                 * will wake at some time in the future then we
                 * can flush packed buffers that might still be
                 * hanging around, which can happen if no
                 * further send was requested by the stack
                 */
changed to:
		/*
                 * there's no outstanding PCI any more, so we
                 * have to request a PCI to be sure the PCI
                 * will wake at some time in the future. Then we
                 * can flush packed buffers that might still be
                 * hanging around, which can happen if no
                 * further send was requested by the stack
                 */

Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
---
 drivers/s390/net/qeth_core_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 9e54fe76a9b2..5248f97ee7a6 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -3565,8 +3565,8 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
 			if (!atomic_read(&queue->set_pci_flags_count)) {
 				/*
 				 * there's no outstanding PCI any more, so we
-				 * have to request a PCI to be sure the the PCI
-				 * will wake at some time in the future then we
+                 * have to request a PCI to be sure the PCI
+                 * will wake at some time in the future. Then we
 				 * can flush packed buffers that might still be
 				 * hanging around, which can happen if no
 				 * further send was requested by the stack
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390/net: Fix duplicate 'the' in two places
  2022-06-21 16:07 [PATCH] s390/net: Fix duplicate 'the' in two places Jiang Jian
@ 2022-06-21 22:32 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-06-21 22:32 UTC (permalink / raw)
  To: Jiang Jian
  Cc: wintera, wenjia, hca, gor, agordeev, borntraeger, svens,
	linux-s390, netdev, linux-kernel

Please add the version to the patch subject.
This is the second versions, AFAIU so it should have had
[PATCH v2] in the subject line.

On Wed, 22 Jun 2022 00:07:56 +0800 Jiang Jian wrote:
> file: drivers/s390/net/qeth_core_main.c
> line: 3568
>                 /*
>                  * there's no outstanding PCI any more, so we
>                  * have to request a PCI to be sure the the PCI
>                  * will wake at some time in the future then we
>                  * can flush packed buffers that might still be
>                  * hanging around, which can happen if no
>                  * further send was requested by the stack
>                  */
> changed to:
> 		/*
>                  * there's no outstanding PCI any more, so we
>                  * have to request a PCI to be sure the PCI
>                  * will wake at some time in the future. Then we
>                  * can flush packed buffers that might still be
>                  * hanging around, which can happen if no
>                  * further send was requested by the stack
>                  */

That's basically a copy of the diff, please describe the why and what
not how.

> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>  drivers/s390/net/qeth_core_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 9e54fe76a9b2..5248f97ee7a6 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3565,8 +3565,8 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
>  			if (!atomic_read(&queue->set_pci_flags_count)) {
>  				/*
>  				 * there's no outstanding PCI any more, so we
> -				 * have to request a PCI to be sure the the PCI
> -				 * will wake at some time in the future then we
> +                 * have to request a PCI to be sure the PCI
> +                 * will wake at some time in the future. Then we

You broke the whitespace now.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-21 22:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 16:07 [PATCH] s390/net: Fix duplicate 'the' in two places Jiang Jian
2022-06-21 22:32 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).