From: Alex Williamson <alex.williamson@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: lizhe.67@bytedance.com, cohuck@redhat.com, jgg@ziepe.ca,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
lizefan.x@bytedance.com
Subject: Re: [PATCH] vfio: remove useless judgement
Date: Mon, 27 Jun 2022 16:06:40 -0600 [thread overview]
Message-ID: <20220627160640.7edca0dd.alex.williamson@redhat.com> (raw)
In-Reply-To: <20220627035109.73745-1-lizhe.67@bytedance.com>
Hey Steve, how did you get around this for cpr or is this a gap?
Thanks,
Alex
On Mon, 27 Jun 2022 11:51:09 +0800
lizhe.67@bytedance.com wrote:
> From: Li Zhe <lizhe.67@bytedance.com>
>
> In function vfio_dma_do_unmap(), we currently prevent process to unmap
> vfio dma region whose mm_struct is different from the vfio_dma->task.
> In our virtual machine scenario which is using kvm and qemu, this
> judgement stops us from liveupgrading our qemu, which uses fork() &&
> exec() to load the new binary but the new process cannot do the
> VFIO_IOMMU_UNMAP_DMA action during vm exit because of this judgement.
>
> This judgement is added in commit 8f0d5bb95f76 ("vfio iommu type1: Add
> task structure to vfio_dma") for the security reason. But it seems that
> no other task who has no family relationship with old and new process
> can get the same vfio_dma struct here for the reason of resource
> isolation. So this patch delete it.
>
> Signed-off-by: Li Zhe <lizhe.67@bytedance.com>
> Reviewed-by: Jason Gunthorpe <jgg@ziepe.ca>
> ---
> drivers/vfio/vfio_iommu_type1.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index c13b9290e357..a8ff00dad834 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -1377,12 +1377,6 @@ static int vfio_dma_do_unmap(struct vfio_iommu *iommu,
>
> if (!iommu->v2 && iova > dma->iova)
> break;
> - /*
> - * Task with same address space who mapped this iova range is
> - * allowed to unmap the iova range.
> - */
> - if (dma->task->mm != current->mm)
> - break;
>
> if (invalidate_vaddr) {
> if (dma->vaddr_invalid) {
next prev parent reply other threads:[~2022-06-27 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 3:51 [PATCH] vfio: remove useless judgement lizhe.67
2022-06-27 22:06 ` Alex Williamson [this message]
2022-06-28 12:48 ` Steven Sistare
2022-06-28 13:03 ` Jason Gunthorpe
2022-06-28 13:54 ` Steven Sistare
2022-06-28 14:04 ` Jason Gunthorpe
2022-06-30 19:51 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627160640.7edca0dd.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=lizhe.67@bytedance.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).