* [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event
@ 2022-06-28 12:37 Kai-Heng Feng
2022-06-28 21:24 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2022-06-28 12:37 UTC (permalink / raw)
To: hdegoede, markgross
Cc: Kai-Heng Feng, Jorge Lopez, platform-driver-x86, linux-kernel
After system resume the hp-wmi driver may complain:
[ 702.620180] hp_wmi: Unknown event_id - 23 - 0x0
According to HP it means 'Sanitization Mode' and it's harmless to just
ignore the event.
Cc: Jorge Lopez <jorge.lopez2@hp.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/platform/x86/hp-wmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 0d8cb22e30df9..bc7020e9df9e8 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -89,6 +89,7 @@ enum hp_wmi_event_ids {
HPWMI_BACKLIT_KB_BRIGHTNESS = 0x0D,
HPWMI_PEAKSHIFT_PERIOD = 0x0F,
HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
+ HPWMI_SANITIZATION_MODE = 0x17,
};
/*
@@ -853,6 +854,8 @@ static void hp_wmi_notify(u32 value, void *context)
break;
case HPWMI_BATTERY_CHARGE_PERIOD:
break;
+ case HPWMI_SANITIZATION_MODE:
+ break;
default:
pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
break;
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event
2022-06-28 12:37 [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event Kai-Heng Feng
@ 2022-06-28 21:24 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-06-28 21:24 UTC (permalink / raw)
To: Kai-Heng Feng, markgross; +Cc: Jorge Lopez, platform-driver-x86, linux-kernel
Hi,
On 6/28/22 14:37, Kai-Heng Feng wrote:
> After system resume the hp-wmi driver may complain:
> [ 702.620180] hp_wmi: Unknown event_id - 23 - 0x0
>
> According to HP it means 'Sanitization Mode' and it's harmless to just
> ignore the event.
>
> Cc: Jorge Lopez <jorge.lopez2@hp.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 0d8cb22e30df9..bc7020e9df9e8 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -89,6 +89,7 @@ enum hp_wmi_event_ids {
> HPWMI_BACKLIT_KB_BRIGHTNESS = 0x0D,
> HPWMI_PEAKSHIFT_PERIOD = 0x0F,
> HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
> + HPWMI_SANITIZATION_MODE = 0x17,
> };
>
> /*
> @@ -853,6 +854,8 @@ static void hp_wmi_notify(u32 value, void *context)
> break;
> case HPWMI_BATTERY_CHARGE_PERIOD:
> break;
> + case HPWMI_SANITIZATION_MODE:
> + break;
> default:
> pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
> break;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 12:37 [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event Kai-Heng Feng
2022-06-28 21:24 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).