From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 3/3] x86: fix .brk attribute in linker script
Date: Wed, 29 Jun 2022 10:18:29 -0700 [thread overview]
Message-ID: <20220629171829.shotpln44nzgo2eu@treble> (raw)
In-Reply-To: <20220623094608.7294-4-jgross@suse.com>
On Thu, Jun 23, 2022 at 11:46:08AM +0200, Juergen Gross wrote:
> Commit e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for older binutils")
> added the "NOLOAD" attribute to the .brk section as a "failsafe"
> measure.
>
> Unfortunately this leads to the linker no longer covering the .brk
> section in a program header, resulting in the kernel loader not knowing
> that the memory for the .brk section must be reserved.
>
> This has led to crashes when loading the kernel as PV dom0 under Xen,
> but other scenarios could be hit by the same problem (e.g. in case an
> uncompressed kernel is used and the initrd is placed directly behind
> it).
>
> So drop the "NOLOAD" attribute. This has been verified to correctly
> cover the .brk section by a program header of the resulting ELF file.
>
> Fixes: e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for older binutils")
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
next prev parent reply other threads:[~2022-06-29 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 9:46 [PATCH v2 0/3] x86: fix brk area initialization Juergen Gross
2022-06-23 9:46 ` [PATCH v2 1/3] x86/xen: use clear_bss() for Xen PV guests Juergen Gross
2022-06-23 9:51 ` Jan Beulich
2022-06-28 12:03 ` Juergen Gross
2022-06-23 9:46 ` [PATCH v2 2/3] x86: fix setup of brk area Juergen Gross
2022-06-29 17:14 ` Josh Poimboeuf
2022-06-30 6:55 ` Juergen Gross
2022-06-23 9:46 ` [PATCH v2 3/3] x86: fix .brk attribute in linker script Juergen Gross
2022-06-29 17:18 ` Josh Poimboeuf [this message]
2022-06-29 14:10 ` [PATCH v2 0/3] x86: fix brk area initialization Juergen Gross
2022-06-29 17:17 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629171829.shotpln44nzgo2eu@treble \
--to=jpoimboe@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).