Re: [PATCH v2 0/3] x86: fix brk area initialization

From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	regressions@lists.linux.dev
Subject: Re: [PATCH v2 0/3] x86: fix brk area initialization
Date: Wed, 29 Jun 2022 16:10:04 +0200	[thread overview]
Message-ID: <2592493b-4339-3e54-8acf-585dcf90be96@suse.com> (raw)
In-Reply-To: <20220623094608.7294-1-jgross@suse.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 872 bytes --]

On 23.06.22 11:46, Juergen Gross wrote:
> The brk area needs to be zeroed initially, like the .bss section.
> At the same time its memory should be covered by the ELF program
> headers.
> 
> Juergen Gross (3):
>    x86/xen: use clear_bss() for Xen PV guests
>    x86: fix setup of brk area
>    x86: fix .brk attribute in linker script
> 
>   arch/x86/include/asm/setup.h  |  3 +++
>   arch/x86/kernel/head64.c      |  4 +++-
>   arch/x86/kernel/vmlinux.lds.S |  2 +-
>   arch/x86/xen/enlighten_pv.c   |  8 ++++++--
>   arch/x86/xen/xen-head.S       | 10 +---------
>   5 files changed, 14 insertions(+), 13 deletions(-)
> 

Could I please have some feedback? This series is fixing a major
regression regarding running as Xen PV guest (depending on kernel
configuration system will crash very early).

#regzbot ^introduced e32683c6f7d2

Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]