From: xiubli@redhat.com
To: jlayton@kernel.org, idryomov@gmail.com, dhowells@redhat.com
Cc: vshankar@redhat.com, linux-kernel@vger.kernel.org,
ceph-devel@vger.kernel.org, willy@infradead.org,
keescook@chromium.org, linux-fsdevel@vger.kernel.org,
linux-cachefs@redhat.com, Xiubo Li <xiubli@redhat.com>
Subject: [PATCH 1/2] netfs: release the folio lock and put the folio before retrying
Date: Fri, 1 Jul 2022 10:29:46 +0800 [thread overview]
Message-ID: <20220701022947.10716-2-xiubli@redhat.com> (raw)
In-Reply-To: <20220701022947.10716-1-xiubli@redhat.com>
From: Xiubo Li <xiubli@redhat.com>
The lower layer filesystem should always make sure the folio is
locked and do the unlock and put the folio in netfs layer.
URL: https://tracker.ceph.com/issues/56423
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
fs/netfs/buffered_read.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
index 42f892c5712e..257fd37c2461 100644
--- a/fs/netfs/buffered_read.c
+++ b/fs/netfs/buffered_read.c
@@ -351,8 +351,11 @@ int netfs_write_begin(struct netfs_inode *ctx,
ret = ctx->ops->check_write_begin(file, pos, len, folio, _fsdata);
if (ret < 0) {
trace_netfs_failure(NULL, NULL, ret, netfs_fail_check_write_begin);
- if (ret == -EAGAIN)
+ if (ret == -EAGAIN) {
+ folio_unlock(folio);
+ folio_put(folio);
goto retry;
+ }
goto error;
}
}
--
2.36.0.rc1
next prev parent reply other threads:[~2022-07-01 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 2:29 [PATCH 0/2] netfs, ceph: fix the crash when unlocking the folio xiubli
2022-07-01 2:29 ` xiubli [this message]
2022-07-01 10:38 ` [PATCH 1/2] netfs: release the folio lock and put the folio before retrying Jeff Layton
2022-07-04 1:13 ` Xiubo Li
2022-07-04 2:10 ` Matthew Wilcox
2022-07-04 2:40 ` Xiubo Li
2022-07-04 6:58 ` Xiubo Li
2022-07-05 13:21 ` David Howells
2022-07-05 13:41 ` Jeff Layton
2022-07-06 0:58 ` Xiubo Li
2022-07-01 2:29 ` [PATCH 2/2] ceph: do not release the folio lock in kceph xiubli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701022947.10716-2-xiubli@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vshankar@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).