From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>, <ck.hu@mediatek.com>,
<xinlei.lee@mediatek.com>, <liangxu.xu@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v15 12/16] drm/mediatek: dpi: move the csc_enable bit to SoC config
Date: Fri, 1 Jul 2022 11:58:41 +0800 [thread overview]
Message-ID: <20220701035845.16458-13-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220701035845.16458-1-rex-bc.chen@mediatek.com>
From: Guillaume Ranquet <granquet@baylibre.com>
Add flexibility by moving the csc_enable bit to SoC specific config
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 0b75a4ce8261..3085033becbd 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -127,6 +127,7 @@ struct mtk_dpi_yc_limit {
* @hvsize_mask: Mask of HSIZE and VSIZE mask (no shift).
* @channel_swap_shift: Shift value of channel swap.
* @yuv422_en_bit: Enable bit of yuv422.
+ * @csc_enable_bit: Enable bit of CSC.
*/
struct mtk_dpi_conf {
unsigned int (*cal_factor)(int clock);
@@ -141,6 +142,7 @@ struct mtk_dpi_conf {
u32 hvsize_mask;
u32 channel_swap_shift;
u32 yuv422_en_bit;
+ u32 csc_enable_bit;
};
static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -384,7 +386,8 @@ static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool enable)
static void mtk_dpi_config_csc_enable(struct mtk_dpi *dpi, bool enable)
{
- mtk_dpi_mask(dpi, DPI_CON, enable ? CSC_ENABLE : 0, CSC_ENABLE);
+ mtk_dpi_mask(dpi, DPI_CON, enable ? dpi->conf->csc_enable_bit : 0,
+ dpi->conf->csc_enable_bit);
}
static void mtk_dpi_config_swap_input(struct mtk_dpi *dpi, bool enable)
@@ -826,6 +829,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
.hvsize_mask = HSIZE_MASK,
.channel_swap_shift = CH_SWAP,
.yuv422_en_bit = YUV422_EN,
+ .csc_enable_bit = CSC_ENABLE,
};
static const struct mtk_dpi_conf mt2701_conf = {
@@ -841,6 +845,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
.hvsize_mask = HSIZE_MASK,
.channel_swap_shift = CH_SWAP,
.yuv422_en_bit = YUV422_EN,
+ .csc_enable_bit = CSC_ENABLE,
};
static const struct mtk_dpi_conf mt8183_conf = {
@@ -855,6 +860,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
.hvsize_mask = HSIZE_MASK,
.channel_swap_shift = CH_SWAP,
.yuv422_en_bit = YUV422_EN,
+ .csc_enable_bit = CSC_ENABLE,
};
static const struct mtk_dpi_conf mt8192_conf = {
@@ -869,6 +875,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
.hvsize_mask = HSIZE_MASK,
.channel_swap_shift = CH_SWAP,
.yuv422_en_bit = YUV422_EN,
+ .csc_enable_bit = CSC_ENABLE,
};
static int mtk_dpi_probe(struct platform_device *pdev)
--
2.18.0
next prev parent reply other threads:[~2022-07-01 3:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 3:58 [PATCH v15 00/16] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-07-01 3:58 ` [PATCH v15 01/16] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-07-05 3:42 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 02/16] dt-bindings: mediatek,dpi: Revise mediatek strings to correct format Bo-Chen Chen
2022-07-05 3:43 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 03/16] drm/mediatek: dpi: Add kernel document for struct mtk_dpi_conf Bo-Chen Chen
2022-07-05 3:44 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 04/16] drm/mediatek: dpi: Remove output format of YUV Bo-Chen Chen
2022-07-05 3:48 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 05/16] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-07-05 3:49 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 06/16] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-07-05 3:50 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 07/16] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-07-05 3:51 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 08/16] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-07-05 3:52 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 09/16] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-07-05 3:53 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 10/16] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-07-05 3:53 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 11/16] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-07-05 3:54 ` CK Hu
2022-07-01 3:58 ` Bo-Chen Chen [this message]
2022-07-05 3:55 ` [PATCH v15 12/16] drm/mediatek: dpi: move the csc_enable bit " CK Hu
2022-07-01 3:58 ` [PATCH v15 13/16] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-07-05 5:21 ` CK Hu
2022-07-05 8:39 ` Rex-BC Chen
2022-07-05 8:51 ` Rex-BC Chen
2022-07-01 3:58 ` [PATCH v15 14/16] drm/mediatek: dpi: add config to support direct connection to dpi panels Bo-Chen Chen
2022-07-05 5:24 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 15/16] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-07-05 3:56 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 16/16] drm/mediatek: dpi: Add dp_intf support Bo-Chen Chen
2022-07-05 5:29 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701035845.16458-13-rex-bc.chen@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).