From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>, <ck.hu@mediatek.com>,
<xinlei.lee@mediatek.com>, <liangxu.xu@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Bo-Chen Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH v15 08/16] drm/mediatek: dpi: move dimension mask to SoC config
Date: Fri, 1 Jul 2022 11:58:37 +0800 [thread overview]
Message-ID: <20220701035845.16458-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220701035845.16458-1-rex-bc.chen@mediatek.com>
From: Guillaume Ranquet <granquet@baylibre.com>
Add flexibility by moving the dimension mask to the SoC config
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index ba871c347d15..586527458064 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -122,6 +122,8 @@ struct mtk_dpi_yc_limit {
* @num_output_fmts: Quantity of supported output formats.
* @is_ck_de_pol: Support CK/DE polarity.
* @swap_input_support: Support input swap function.
+ * @dimension_mask: Mask used for HWIDTH, HPORCH, VSYNC_WIDTH and VSYNC_PORCH
+ * (no shift).
*/
struct mtk_dpi_conf {
unsigned int (*cal_factor)(int clock);
@@ -132,6 +134,7 @@ struct mtk_dpi_conf {
u32 num_output_fmts;
bool is_ck_de_pol;
bool swap_input_support;
+ u32 dimension_mask;
};
static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -160,30 +163,30 @@ static void mtk_dpi_disable(struct mtk_dpi *dpi)
static void mtk_dpi_config_hsync(struct mtk_dpi *dpi,
struct mtk_dpi_sync_param *sync)
{
- mtk_dpi_mask(dpi, DPI_TGEN_HWIDTH,
- sync->sync_width << HPW, HPW_MASK);
- mtk_dpi_mask(dpi, DPI_TGEN_HPORCH,
- sync->back_porch << HBP, HBP_MASK);
+ mtk_dpi_mask(dpi, DPI_TGEN_HWIDTH, sync->sync_width << HPW,
+ dpi->conf->dimension_mask << HPW);
+ mtk_dpi_mask(dpi, DPI_TGEN_HPORCH, sync->back_porch << HBP,
+ dpi->conf->dimension_mask << HBP);
mtk_dpi_mask(dpi, DPI_TGEN_HPORCH, sync->front_porch << HFP,
- HFP_MASK);
+ dpi->conf->dimension_mask << HFP);
}
static void mtk_dpi_config_vsync(struct mtk_dpi *dpi,
struct mtk_dpi_sync_param *sync,
u32 width_addr, u32 porch_addr)
{
- mtk_dpi_mask(dpi, width_addr,
- sync->sync_width << VSYNC_WIDTH_SHIFT,
- VSYNC_WIDTH_MASK);
mtk_dpi_mask(dpi, width_addr,
sync->shift_half_line << VSYNC_HALF_LINE_SHIFT,
VSYNC_HALF_LINE_MASK);
+ mtk_dpi_mask(dpi, width_addr,
+ sync->sync_width << VSYNC_WIDTH_SHIFT,
+ dpi->conf->dimension_mask << VSYNC_WIDTH_SHIFT);
mtk_dpi_mask(dpi, porch_addr,
sync->back_porch << VSYNC_BACK_PORCH_SHIFT,
- VSYNC_BACK_PORCH_MASK);
+ dpi->conf->dimension_mask << VSYNC_BACK_PORCH_SHIFT);
mtk_dpi_mask(dpi, porch_addr,
sync->front_porch << VSYNC_FRONT_PORCH_SHIFT,
- VSYNC_FRONT_PORCH_MASK);
+ dpi->conf->dimension_mask << VSYNC_FRONT_PORCH_SHIFT);
}
static void mtk_dpi_config_vsync_lodd(struct mtk_dpi *dpi,
@@ -808,6 +811,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
.is_ck_de_pol = true,
.swap_input_support = true,
+ .dimension_mask = HPW_MASK,
};
static const struct mtk_dpi_conf mt2701_conf = {
@@ -819,6 +823,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
.is_ck_de_pol = true,
.swap_input_support = true,
+ .dimension_mask = HPW_MASK,
};
static const struct mtk_dpi_conf mt8183_conf = {
@@ -829,6 +834,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
.is_ck_de_pol = true,
.swap_input_support = true,
+ .dimension_mask = HPW_MASK,
};
static const struct mtk_dpi_conf mt8192_conf = {
@@ -839,6 +845,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
.is_ck_de_pol = true,
.swap_input_support = true,
+ .dimension_mask = HPW_MASK,
};
static int mtk_dpi_probe(struct platform_device *pdev)
--
2.18.0
next prev parent reply other threads:[~2022-07-01 3:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 3:58 [PATCH v15 00/16] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-07-01 3:58 ` [PATCH v15 01/16] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-07-05 3:42 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 02/16] dt-bindings: mediatek,dpi: Revise mediatek strings to correct format Bo-Chen Chen
2022-07-05 3:43 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 03/16] drm/mediatek: dpi: Add kernel document for struct mtk_dpi_conf Bo-Chen Chen
2022-07-05 3:44 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 04/16] drm/mediatek: dpi: Remove output format of YUV Bo-Chen Chen
2022-07-05 3:48 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 05/16] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-07-05 3:49 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 06/16] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-07-05 3:50 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 07/16] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-07-05 3:51 ` CK Hu
2022-07-01 3:58 ` Bo-Chen Chen [this message]
2022-07-05 3:52 ` [PATCH v15 08/16] drm/mediatek: dpi: move dimension mask to " CK Hu
2022-07-01 3:58 ` [PATCH v15 09/16] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-07-05 3:53 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 10/16] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-07-05 3:53 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 11/16] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-07-05 3:54 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 12/16] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-07-05 3:55 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 13/16] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-07-05 5:21 ` CK Hu
2022-07-05 8:39 ` Rex-BC Chen
2022-07-05 8:51 ` Rex-BC Chen
2022-07-01 3:58 ` [PATCH v15 14/16] drm/mediatek: dpi: add config to support direct connection to dpi panels Bo-Chen Chen
2022-07-05 5:24 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 15/16] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-07-05 3:56 ` CK Hu
2022-07-01 3:58 ` [PATCH v15 16/16] drm/mediatek: dpi: Add dp_intf support Bo-Chen Chen
2022-07-05 5:29 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701035845.16458-9-rex-bc.chen@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).