* [PATCH -next] certs: Fix Kconfig dependency
@ 2022-07-04 11:20 Ren Zhijie
2022-07-11 0:36 ` Randy Dunlap
2022-07-25 6:19 ` Ren Zhijie
0 siblings, 2 replies; 3+ messages in thread
From: Ren Zhijie @ 2022-07-04 11:20 UTC (permalink / raw)
To: dhowells, herbert, davem, simo
Cc: keyrings, linux-crypto, linux-kernel, Ren Zhijie
If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y,
make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest':
selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message'
selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data'
selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify'
selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust'
selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message'
make: *** [vmlinux] Error 1
To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
---
crypto/asymmetric_keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index 3df3fe4ed95f..fe007db96c69 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
for FIPS.
depends on KEYS
depends on ASYMMETRIC_KEY_TYPE
- depends on PKCS7_MESSAGE_PARSER
+ depends on PKCS7_MESSAGE_PARSER=y
endif # ASYMMETRIC_KEY_TYPE
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] certs: Fix Kconfig dependency
2022-07-04 11:20 [PATCH -next] certs: Fix Kconfig dependency Ren Zhijie
@ 2022-07-11 0:36 ` Randy Dunlap
2022-07-25 6:19 ` Ren Zhijie
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-07-11 0:36 UTC (permalink / raw)
To: Ren Zhijie, dhowells, herbert, davem, simo
Cc: keyrings, linux-crypto, linux-kernel
On 7/4/22 04:20, Ren Zhijie wrote:
> If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
>
> crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest':
> selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message'
> selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data'
> selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify'
> selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust'
> selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message'
> make: *** [vmlinux] Error 1
>
> To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
> crypto/asymmetric_keys/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 3df3fe4ed95f..fe007db96c69 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
> for FIPS.
> depends on KEYS
> depends on ASYMMETRIC_KEY_TYPE
> - depends on PKCS7_MESSAGE_PARSER
> + depends on PKCS7_MESSAGE_PARSER=y
>
> endif # ASYMMETRIC_KEY_TYPE
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reported-by: kernel test robot <lkp@intel.com> # 2022-06-30
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] certs: Fix Kconfig dependency
2022-07-04 11:20 [PATCH -next] certs: Fix Kconfig dependency Ren Zhijie
2022-07-11 0:36 ` Randy Dunlap
@ 2022-07-25 6:19 ` Ren Zhijie
1 sibling, 0 replies; 3+ messages in thread
From: Ren Zhijie @ 2022-07-25 6:19 UTC (permalink / raw)
To: dhowells, herbert, davem, simo; +Cc: keyrings, linux-crypto, linux-kernel
Hi,
Just a friendly ping...
在 2022/7/4 19:20, Ren Zhijie 写道:
> If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
>
> crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest':
> selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message'
> selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data'
> selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify'
> selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust'
> selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message'
> make: *** [vmlinux] Error 1
>
> To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
> crypto/asymmetric_keys/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 3df3fe4ed95f..fe007db96c69 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
> for FIPS.
> depends on KEYS
> depends on ASYMMETRIC_KEY_TYPE
> - depends on PKCS7_MESSAGE_PARSER
> + depends on PKCS7_MESSAGE_PARSER=y
>
> endif # ASYMMETRIC_KEY_TYPE
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-25 6:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 11:20 [PATCH -next] certs: Fix Kconfig dependency Ren Zhijie
2022-07-11 0:36 ` Randy Dunlap
2022-07-25 6:19 ` Ren Zhijie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).