* [PATCH 0/2] slimbus: patches for 5.20
@ 2022-07-06 10:11 Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 1/2] drivers: slimbus: Directly use ida_alloc()/free() Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 2/2] slimbus: messaging: fix typos in comments Srinivas Kandagatla
0 siblings, 2 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2022-07-06 10:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Srinivas Kandagatla
Hi Greg,
Here are some trivial SlimBus patches for 5.20,
One of them is to do with typos in comments and other one is to move to
ida_alloc apis from old deprecated ida_simple apis.
Can you please queue them up for 5.20.
Thanks,
Srini
Julia Lawall (1):
slimbus: messaging: fix typos in comments
keliu (1):
drivers: slimbus: Directly use ida_alloc()/free()
drivers/slimbus/core.c | 6 +++---
drivers/slimbus/messaging.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] drivers: slimbus: Directly use ida_alloc()/free()
2022-07-06 10:11 [PATCH 0/2] slimbus: patches for 5.20 Srinivas Kandagatla
@ 2022-07-06 10:11 ` Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 2/2] slimbus: messaging: fix typos in comments Srinivas Kandagatla
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2022-07-06 10:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, keliu, Srinivas Kandagatla
From: keliu <liuke94@huawei.com>
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .
Signed-off-by: keliu <liuke94@huawei.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 78480e332ab8..219483b79c09 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -250,7 +250,7 @@ int slim_register_controller(struct slim_controller *ctrl)
{
int id;
- id = ida_simple_get(&ctrl_ida, 0, 0, GFP_KERNEL);
+ id = ida_alloc(&ctrl_ida, GFP_KERNEL);
if (id < 0)
return id;
@@ -299,7 +299,7 @@ int slim_unregister_controller(struct slim_controller *ctrl)
{
/* Remove all clients */
device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device);
- ida_simple_remove(&ctrl_ida, ctrl->id);
+ ida_free(&ctrl_ida, ctrl->id);
return 0;
}
@@ -323,7 +323,7 @@ void slim_report_absent(struct slim_device *sbdev)
sbdev->is_laddr_valid = false;
mutex_unlock(&ctrl->lock);
if (!ctrl->get_laddr)
- ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr);
+ ida_free(&ctrl->laddr_ida, sbdev->laddr);
slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN);
}
EXPORT_SYMBOL_GPL(slim_report_absent);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] slimbus: messaging: fix typos in comments
2022-07-06 10:11 [PATCH 0/2] slimbus: patches for 5.20 Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 1/2] drivers: slimbus: Directly use ida_alloc()/free() Srinivas Kandagatla
@ 2022-07-06 10:11 ` Srinivas Kandagatla
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2022-07-06 10:11 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Julia Lawall, Srinivas Kandagatla
From: Julia Lawall <Julia.Lawall@inria.fr>
Spelling mistakes (triple letters) in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/messaging.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index e5ae26227bdb..4ce0cb61e481 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -79,7 +79,7 @@ int slim_alloc_txn_tid(struct slim_controller *ctrl, struct slim_msg_txn *txn)
EXPORT_SYMBOL_GPL(slim_alloc_txn_tid);
/**
- * slim_free_txn_tid() - Freee tid of txn
+ * slim_free_txn_tid() - Free tid of txn
*
* @ctrl: Controller handle
* @txn: transaction whose tid should be freed
@@ -101,7 +101,7 @@ EXPORT_SYMBOL_GPL(slim_free_txn_tid);
* @txn: Transaction to be sent over SLIMbus
*
* Called by controller to transmit messaging transactions not dealing with
- * Interface/Value elements. (e.g. transmittting a message to assign logical
+ * Interface/Value elements. (e.g. transmitting a message to assign logical
* address to a slave device
*
* Return: -ETIMEDOUT: If transmission of this message timed out
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-06 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 10:11 [PATCH 0/2] slimbus: patches for 5.20 Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 1/2] drivers: slimbus: Directly use ida_alloc()/free() Srinivas Kandagatla
2022-07-06 10:11 ` [PATCH 2/2] slimbus: messaging: fix typos in comments Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).