* [PATCH V4] arm64: dts: imx8mp: add NoC node
@ 2022-07-06 23:47 Peng Fan (OSS)
2022-07-07 8:43 ` Georgi Djakov
2022-07-08 8:21 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2022-07-06 23:47 UTC (permalink / raw)
To: djakov, shawnguo, s.hauer, festevam, robh+dt,
krzysztof.kozlowski+dt, abel.vesa, abailon, l.stach,
laurent.pinchart, marex, paul.elder, Markus.Niebel, aford173
Cc: kernel, linux-pm, devicetree, linux-arm-kernel, linux-kernel,
linux-imx, abelvesa, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work.
Currently dynamic frequency scaling of the i.MX8MP NoC has not been
supported, only NoC initial settings are configured by interconnect
driver.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V4:
Georgi has merged the V3 driver and bindings patches. So only resend
this patch. Per Georgi's comments:
- Drop syscon from compatbile
- Drop the header inclusion
Seems I not see this patch in patchwork or mailist, maybe sent failed.
So gave a resend of V4.
V3:
https://lore.kernel.org/linux-arm-kernel/20220703091132.1412063-1-peng.fan@oss.nxp.com/
I not list the full change log, since this is only a minor patch
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index eb2d516278eb..42ed8ee08548 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1019,6 +1019,27 @@ eqos: ethernet@30bf0000 {
};
};
+ noc: interconnect@32700000 {
+ compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
+ reg = <0x32700000 0x100000>;
+ clocks = <&clk IMX8MP_CLK_NOC>;
+ #interconnect-cells = <1>;
+
+ operating-points-v2 = <&noc_opp_table>;
+
+ noc_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-200M {
+ opp-hz = /bits/ 64 <200000000>;
+ };
+
+ opp-1000M {
+ opp-hz = /bits/ 64 <1000000000>;
+ };
+ };
+ };
+
aips4: bus@32c00000 {
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32c00000 0x400000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V4] arm64: dts: imx8mp: add NoC node
2022-07-06 23:47 [PATCH V4] arm64: dts: imx8mp: add NoC node Peng Fan (OSS)
@ 2022-07-07 8:43 ` Georgi Djakov
2022-07-08 8:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Georgi Djakov @ 2022-07-07 8:43 UTC (permalink / raw)
To: Peng Fan (OSS),
shawnguo, s.hauer, festevam, robh+dt, krzysztof.kozlowski+dt,
abel.vesa, abailon, l.stach, laurent.pinchart, marex, paul.elder,
Markus.Niebel, aford173
Cc: kernel, linux-pm, devicetree, linux-arm-kernel, linux-kernel,
linux-imx, abelvesa, Peng Fan
On 7.07.22 2:47, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work.
> Currently dynamic frequency scaling of the i.MX8MP NoC has not been
> supported, only NoC initial settings are configured by interconnect
> driver.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Looks good to me.
Acked-by: Georgi Djakov <djakov@kernel.org>
> ---
>
> V4:
> Georgi has merged the V3 driver and bindings patches. So only resend
> this patch. Per Georgi's comments:
> - Drop syscon from compatbile
> - Drop the header inclusion
>
> Seems I not see this patch in patchwork or mailist, maybe sent failed.
> So gave a resend of V4.
>
> V3:
> https://lore.kernel.org/linux-arm-kernel/20220703091132.1412063-1-peng.fan@oss.nxp.com/
>
> I not list the full change log, since this is only a minor patch
>
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index eb2d516278eb..42ed8ee08548 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1019,6 +1019,27 @@ eqos: ethernet@30bf0000 {
> };
> };
>
> + noc: interconnect@32700000 {
> + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
> + reg = <0x32700000 0x100000>;
> + clocks = <&clk IMX8MP_CLK_NOC>;
> + #interconnect-cells = <1>;
> +
> + operating-points-v2 = <&noc_opp_table>;
> +
> + noc_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-200M {
> + opp-hz = /bits/ 64 <200000000>;
> + };
> +
> + opp-1000M {
> + opp-hz = /bits/ 64 <1000000000>;
> + };
> + };
> + };
> +
> aips4: bus@32c00000 {
> compatible = "fsl,aips-bus", "simple-bus";
> reg = <0x32c00000 0x400000>;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V4] arm64: dts: imx8mp: add NoC node
2022-07-06 23:47 [PATCH V4] arm64: dts: imx8mp: add NoC node Peng Fan (OSS)
2022-07-07 8:43 ` Georgi Djakov
@ 2022-07-08 8:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-07-08 8:21 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: djakov, s.hauer, festevam, robh+dt, krzysztof.kozlowski+dt,
abel.vesa, abailon, l.stach, laurent.pinchart, marex, paul.elder,
Markus.Niebel, aford173, kernel, linux-pm, devicetree,
linux-arm-kernel, linux-kernel, linux-imx, abelvesa, Peng Fan
On Thu, Jul 07, 2022 at 07:47:57AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work.
> Currently dynamic frequency scaling of the i.MX8MP NoC has not been
> supported, only NoC initial settings are configured by interconnect
> driver.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V4:
> Georgi has merged the V3 driver and bindings patches. So only resend
> this patch. Per Georgi's comments:
> - Drop syscon from compatbile
> - Drop the header inclusion
>
> Seems I not see this patch in patchwork or mailist, maybe sent failed.
> So gave a resend of V4.
>
> V3:
> https://lore.kernel.org/linux-arm-kernel/20220703091132.1412063-1-peng.fan@oss.nxp.com/
>
> I not list the full change log, since this is only a minor patch
>
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index eb2d516278eb..42ed8ee08548 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1019,6 +1019,27 @@ eqos: ethernet@30bf0000 {
> };
> };
>
> + noc: interconnect@32700000 {
> + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
> + reg = <0x32700000 0x100000>;
> + clocks = <&clk IMX8MP_CLK_NOC>;
> + #interconnect-cells = <1>;
> +
This newline is not really necessary. Dropped it and applied patch.
Shawn
> + operating-points-v2 = <&noc_opp_table>;
> +
> + noc_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-200M {
> + opp-hz = /bits/ 64 <200000000>;
> + };
> +
> + opp-1000M {
> + opp-hz = /bits/ 64 <1000000000>;
> + };
> + };
> + };
> +
> aips4: bus@32c00000 {
> compatible = "fsl,aips-bus", "simple-bus";
> reg = <0x32c00000 0x400000>;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-08 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 23:47 [PATCH V4] arm64: dts: imx8mp: add NoC node Peng Fan (OSS)
2022-07-07 8:43 ` Georgi Djakov
2022-07-08 8:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).