* [PATCH] mm/khugepaged: Avoid possible memory leak in failure path
@ 2022-07-13 2:41 Souptick Joarder
2022-07-13 16:39 ` Zach O'Keefe
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2022-07-13 2:41 UTC (permalink / raw)
To: akpm
Cc: linux-mm, linux-kernel, Souptick Joarder (HPE),
kernel test robot, Dan Carpenter
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory
leak of 'cc'
Avoiding possible memory leak.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
mm/khugepaged.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 0207fc0a5b2a..8da9e7467543 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -2397,12 +2397,6 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
BUG_ON(vma->vm_start > start);
BUG_ON(vma->vm_end < end);
- cc = kmalloc(sizeof(*cc), GFP_KERNEL);
- if (!cc)
- return -ENOMEM;
- cc->is_khugepaged = false;
- cc->last_target_node = NUMA_NO_NODE;
-
*prev = vma;
/* TODO: Support file/shmem */
@@ -2415,6 +2409,12 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
if (!hugepage_vma_check(vma, vma->vm_flags, false, false, false))
return -EINVAL;
+ cc = kmalloc(sizeof(*cc), GFP_KERNEL);
+ if (!cc)
+ return -ENOMEM;
+ cc->is_khugepaged = false;
+ cc->last_target_node = NUMA_NO_NODE;
+
mmgrab(mm);
lru_add_drain_all();
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/khugepaged: Avoid possible memory leak in failure path
2022-07-13 2:41 [PATCH] mm/khugepaged: Avoid possible memory leak in failure path Souptick Joarder
@ 2022-07-13 16:39 ` Zach O'Keefe
0 siblings, 0 replies; 2+ messages in thread
From: Zach O'Keefe @ 2022-07-13 16:39 UTC (permalink / raw)
To: Souptick Joarder
Cc: akpm, linux-mm, linux-kernel, kernel test robot, Dan Carpenter
On Jul 13 08:11, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> smatch warnings:
> mm/khugepaged.c:2409 madvise_collapse() warn: possible memory
> leak of 'cc'
>
> Avoiding possible memory leak.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
> mm/khugepaged.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 0207fc0a5b2a..8da9e7467543 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2397,12 +2397,6 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
> BUG_ON(vma->vm_start > start);
> BUG_ON(vma->vm_end < end);
>
> - cc = kmalloc(sizeof(*cc), GFP_KERNEL);
> - if (!cc)
> - return -ENOMEM;
> - cc->is_khugepaged = false;
> - cc->last_target_node = NUMA_NO_NODE;
> -
> *prev = vma;
>
> /* TODO: Support file/shmem */
> @@ -2415,6 +2409,12 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
> if (!hugepage_vma_check(vma, vma->vm_flags, false, false, false))
> return -EINVAL;
>
> + cc = kmalloc(sizeof(*cc), GFP_KERNEL);
> + if (!cc)
> + return -ENOMEM;
> + cc->is_khugepaged = false;
> + cc->last_target_node = NUMA_NO_NODE;
> +
> mmgrab(mm);
> lru_add_drain_all();
>
> --
> 2.25.1
>
>
Thanks for the fix!
I've also sent out another patch on top which addresses the actual missing
kfree()
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-13 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 2:41 [PATCH] mm/khugepaged: Avoid possible memory leak in failure path Souptick Joarder
2022-07-13 16:39 ` Zach O'Keefe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).