* [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
@ 2022-07-13 14:34 Manivannan Sadhasivam
2022-07-13 14:51 ` Andrew Halaney
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-07-13 14:34 UTC (permalink / raw)
To: bjorn.andersson
Cc: linux-arm-msm, devicetree, linux-kernel, Manivannan Sadhasivam,
Johan Hovold, Steve Capper
PPI interrupt should be 7 for the PMU.
Cc: Johan Hovold <johan+linaro@kernel.org>
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Reported-by: Steve Capper <Steve.Capper@arm.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 268ab423577a..2d7823cb783c 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -477,7 +477,7 @@ memory@80000000 {
pmu {
compatible = "arm,armv8-pmuv3";
- interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
};
psci {
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
2022-07-13 14:34 [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Manivannan Sadhasivam
@ 2022-07-13 14:51 ` Andrew Halaney
2022-07-13 14:55 ` Johan Hovold
2022-07-16 15:18 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Halaney @ 2022-07-13 14:51 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: bjorn.andersson, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, Steve Capper
On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote:
> PPI interrupt should be 7 for the PMU.
>
> Cc: Johan Hovold <johan+linaro@kernel.org>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Reported-by: Steve Capper <Steve.Capper@arm.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 268ab423577a..2d7823cb783c 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -477,7 +477,7 @@ memory@80000000 {
>
> pmu {
> compatible = "arm,armv8-pmuv3";
> - interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> psci {
> --
> 2.25.1
>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
2022-07-13 14:34 [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Manivannan Sadhasivam
2022-07-13 14:51 ` Andrew Halaney
@ 2022-07-13 14:55 ` Johan Hovold
2022-07-13 15:13 ` Manivannan Sadhasivam
2022-07-16 15:18 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-07-13 14:55 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: bjorn.andersson, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, Steve Capper
On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote:
> PPI interrupt should be 7 for the PMU.
>
> Cc: Johan Hovold <johan+linaro@kernel.org>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Reported-by: Steve Capper <Steve.Capper@arm.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 268ab423577a..2d7823cb783c 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -477,7 +477,7 @@ memory@80000000 {
>
> pmu {
> compatible = "arm,armv8-pmuv3";
> - interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> psci {
The interrupt number matches the vendor devicetree I have access to, but
the vendor source also has IRQ_TYPE_LEVEL_LOW instead of
IRQ_TYPE_LEVEL_HIGH here.
Is that another copy-paste error, perhaps?
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
2022-07-13 14:55 ` Johan Hovold
@ 2022-07-13 15:13 ` Manivannan Sadhasivam
2022-07-13 15:26 ` Andrew Halaney
0 siblings, 1 reply; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-07-13 15:13 UTC (permalink / raw)
To: Johan Hovold
Cc: bjorn.andersson, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, Steve Capper
On Wed, Jul 13, 2022 at 04:55:12PM +0200, Johan Hovold wrote:
> On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote:
> > PPI interrupt should be 7 for the PMU.
> >
> > Cc: Johan Hovold <johan+linaro@kernel.org>
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Reported-by: Steve Capper <Steve.Capper@arm.com>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > index 268ab423577a..2d7823cb783c 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > @@ -477,7 +477,7 @@ memory@80000000 {
> >
> > pmu {
> > compatible = "arm,armv8-pmuv3";
> > - interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > };
> >
> > psci {
>
> The interrupt number matches the vendor devicetree I have access to, but
> the vendor source also has IRQ_TYPE_LEVEL_LOW instead of
> IRQ_TYPE_LEVEL_HIGH here.
>
> Is that another copy-paste error, perhaps?
>
I don't have access to the documentation of this SoC now but since Steve
tried with IRQ_TYPE_LEVEL_HIGH and it worked for him, I think it is best
to leave it as it is.
Thanks,
Mani
> Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
2022-07-13 15:13 ` Manivannan Sadhasivam
@ 2022-07-13 15:26 ` Andrew Halaney
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Halaney @ 2022-07-13 15:26 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Johan Hovold, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel, Johan Hovold, Steve Capper
On Wed, Jul 13, 2022 at 08:43:05PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Jul 13, 2022 at 04:55:12PM +0200, Johan Hovold wrote:
> > On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote:
> > > PPI interrupt should be 7 for the PMU.
> > >
> > > Cc: Johan Hovold <johan+linaro@kernel.org>
> > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > > Reported-by: Steve Capper <Steve.Capper@arm.com>
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > index 268ab423577a..2d7823cb783c 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > @@ -477,7 +477,7 @@ memory@80000000 {
> > >
> > > pmu {
> > > compatible = "arm,armv8-pmuv3";
> > > - interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
> > > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > > };
> > >
> > > psci {
> >
> > The interrupt number matches the vendor devicetree I have access to, but
> > the vendor source also has IRQ_TYPE_LEVEL_LOW instead of
> > IRQ_TYPE_LEVEL_HIGH here.
+1 to what I see as well, fwiw. Totally missed that when reviewing
earlier.
> >
> > Is that another copy-paste error, perhaps?
> >
>
> I don't have access to the documentation of this SoC now but since Steve
> tried with IRQ_TYPE_LEVEL_HIGH and it worked for him, I think it is best
> to leave it as it is.
>
> Thanks,
> Mani
>
> > Johan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
2022-07-13 14:34 [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Manivannan Sadhasivam
2022-07-13 14:51 ` Andrew Halaney
2022-07-13 14:55 ` Johan Hovold
@ 2022-07-16 15:18 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-07-16 15:18 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: linux-arm-msm, linux-kernel, devicetree, Johan Hovold, Steve Capper
On Wed, 13 Jul 2022 20:04:29 +0530, Manivannan Sadhasivam wrote:
> PPI interrupt should be 7 for the PMU.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc8280xp: Fix PMU interrupt
commit: 39aa5646adae386719100e9e555a40e9db7bc4a2
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-16 15:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 14:34 [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Manivannan Sadhasivam
2022-07-13 14:51 ` Andrew Halaney
2022-07-13 14:55 ` Johan Hovold
2022-07-13 15:13 ` Manivannan Sadhasivam
2022-07-13 15:26 ` Andrew Halaney
2022-07-16 15:18 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).