* [PATCH] drm/i915/selftests: Fix comment typo
@ 2022-07-16 4:05 Jason Wang
2022-07-20 16:56 ` [Intel-gfx] " Andrzej Hajda
2022-07-21 13:08 ` Andi Shyti
0 siblings, 2 replies; 7+ messages in thread
From: Jason Wang @ 2022-07-16 4:05 UTC (permalink / raw)
To: daniel
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, John.C.Harrison, matthew.d.roper, matthew.brost,
andi.shyti, zhou1615, michal.winiarski, intel-gfx, dri-devel,
linux-kernel, Jason Wang
Fix the double `wait' typo in comment.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index c56a0c2cd2f7..ec05f578a698 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
if (err)
goto err;
- /* Force the wait wait now to avoid including it in the benchmark */
+ /* Force the wait now to avoid including it in the benchmark */
err = i915_vma_sync(vma);
if (err)
goto err_pin;
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-16 4:05 [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
@ 2022-07-20 16:56 ` Andrzej Hajda
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 13:08 ` Andi Shyti
1 sibling, 1 reply; 7+ messages in thread
From: Andrzej Hajda @ 2022-07-20 16:56 UTC (permalink / raw)
To: Jason Wang, daniel
Cc: michal.winiarski, airlied, intel-gfx, linux-kernel, dri-devel,
rodrigo.vivi, zhou1615
On 16.07.2022 06:05, Jason Wang wrote:
> Fix the double `wait' typo in comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-20 16:56 ` [Intel-gfx] " Andrzej Hajda
@ 2022-07-21 8:08 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2022-07-21 8:08 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Jason Wang, daniel, michal.winiarski, airlied, intel-gfx,
linux-kernel, dri-devel, zhou1615
On Wed, Jul 20, 2022 at 06:56:16PM +0200, Andrzej Hajda wrote:
> On 16.07.2022 06:05, Jason Wang wrote:
> > Fix the double `wait' typo in comment.
> >
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> > ---
> > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> > index c56a0c2cd2f7..ec05f578a698 100644
> > --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> > @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> > if (err)
> > goto err;
> > - /* Force the wait wait now to avoid including it in the benchmark */
> > + /* Force the wait now to avoid including it in the benchmark */
> > err = i915_vma_sync(vma);
> > if (err)
> > goto err_pin;
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Thanks for the patch and review. Pushed to drm-intel-gt-next.
>
> Regards
> Andrzej
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/selftests: Fix comment typo
2022-07-16 4:05 [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-20 16:56 ` [Intel-gfx] " Andrzej Hajda
@ 2022-07-21 13:08 ` Andi Shyti
2022-07-21 13:19 ` Andi Shyti
1 sibling, 1 reply; 7+ messages in thread
From: Andi Shyti @ 2022-07-21 13:08 UTC (permalink / raw)
To: Jason Wang
Cc: daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, John.C.Harrison, matthew.d.roper,
matthew.brost, andi.shyti, zhou1615, michal.winiarski, intel-gfx,
dri-devel, linux-kernel
Hi Jason,
On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote:
> Fix the double `wait' typo in comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Few warnings for this patch:
1. you missed Rodrigo's r-b tag.
2. please add a counter to your patch, this would be [PATCH v2]
3. please add a changelog, as this is a single patch, do it
after the '---'
No need to resend, just keep the three notes in mind for your
next patches. Anyway, thanks for the fix and as I am at it:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/selftests: Fix comment typo
2022-07-21 13:08 ` Andi Shyti
@ 2022-07-21 13:19 ` Andi Shyti
0 siblings, 0 replies; 7+ messages in thread
From: Andi Shyti @ 2022-07-21 13:19 UTC (permalink / raw)
To: Andi Shyti
Cc: Jason Wang, daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, John.C.Harrison, matthew.d.roper,
matthew.brost, zhou1615, michal.winiarski, intel-gfx, dri-devel,
linux-kernel
> On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote:
> > Fix the double `wait' typo in comment.
> >
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
>
> Few warnings for this patch:
>
> 1. you missed Rodrigo's r-b tag.
> 2. please add a counter to your patch, this would be [PATCH v2]
> 3. please add a changelog, as this is a single patch, do it
> after the '---'
>
> No need to resend, just keep the three notes in mind for your
> next patches. Anyway, thanks for the fix and as I am at it:
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Pushed in drm-intel-next.
Thanks,
Andi
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/i915/selftests: Fix comment typo
@ 2022-07-15 5:19 Jason Wang
2022-07-18 18:28 ` Rodrigo Vivi
0 siblings, 1 reply; 7+ messages in thread
From: Jason Wang @ 2022-07-15 5:19 UTC (permalink / raw)
To: daniel
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, John.C.Harrison, matthew.d.roper, matthew.brost,
andi.shyti, michal.winiarski, zhou1615, intel-gfx, dri-devel,
linux-kernel, Jason Wang
The double `wait' is duplicated in line 974, remove one.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index c56a0c2cd2f7..ec05f578a698 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
if (err)
goto err;
- /* Force the wait wait now to avoid including it in the benchmark */
+ /* Force the wait now to avoid including it in the benchmark */
err = i915_vma_sync(vma);
if (err)
goto err_pin;
--
2.35.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/selftests: Fix comment typo
2022-07-15 5:19 Jason Wang
@ 2022-07-18 18:28 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2022-07-18 18:28 UTC (permalink / raw)
To: Jason Wang
Cc: daniel, jani.nikula, joonas.lahtinen, tvrtko.ursulin, airlied,
John.C.Harrison, matthew.d.roper, matthew.brost, andi.shyti,
michal.winiarski, zhou1615, intel-gfx, dri-devel, linux-kernel
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote:
> The double `wait' is duplicated in line 974, remove one.
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-21 13:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-16 4:05 [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-20 16:56 ` [Intel-gfx] " Andrzej Hajda
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 13:08 ` Andi Shyti
2022-07-21 13:19 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2022-07-15 5:19 Jason Wang
2022-07-18 18:28 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).