* [PATCH] dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems
@ 2022-07-12 15:46 Krzysztof Kozlowski
2022-07-18 20:24 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-12 15:46 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Michael Srba, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
There is no need to specify "minItems" if it equals to "maxItems". On the
other hand number of items in an array can be specified via describing
items, which might bring some additional information. This simplifies a
bit the binding.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/bus/qcom,ssc-block-bus.yaml | 25 ++++++++-----------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
index 5b9705079015..8e9e6ff35d7d 100644
--- a/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
+++ b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
@@ -28,11 +28,9 @@ properties:
- const: qcom,ssc-block-bus
reg:
- description: |
- Shall contain the addresses of the SSCAON_CONFIG0 and SSCAON_CONFIG1
- registers
- minItems: 2
- maxItems: 2
+ items:
+ - description: SSCAON_CONFIG0 registers
+ - description: SSCAON_CONFIG1 registers
reg-names:
items:
@@ -48,7 +46,6 @@ properties:
ranges: true
clocks:
- minItems: 6
maxItems: 6
clock-names:
@@ -61,9 +58,9 @@ properties:
- const: ssc_ahbs
power-domains:
- description: Power domain phandles for the ssc_cx and ssc_mx power domains
- minItems: 2
- maxItems: 2
+ items:
+ - description: CX power domain
+ - description: MX power domain
power-domain-names:
items:
@@ -71,11 +68,11 @@ properties:
- const: ssc_mx
resets:
- description: |
- Reset phandles for the ssc_reset and ssc_bcr resets (note: ssc_bcr is the
- branch control register associated with the ssc_xo and ssc_ahbs clocks)
- minItems: 2
- maxItems: 2
+ items:
+ - description: Main reset
+ - description:
+ SSC Branch Control Register reset (associated with the ssc_xo and
+ ssc_ahbs clocks)
reset-names:
items:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems
2022-07-12 15:46 [PATCH] dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems Krzysztof Kozlowski
@ 2022-07-18 20:24 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-07-18 20:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-kernel, Konrad Dybcio, Michael Srba,
linux-arm-msm, devicetree, Rob Herring, Andy Gross,
Krzysztof Kozlowski
On Tue, 12 Jul 2022 17:46:02 +0200, Krzysztof Kozlowski wrote:
> There is no need to specify "minItems" if it equals to "maxItems". On the
> other hand number of items in an array can be specified via describing
> items, which might bring some additional information. This simplifies a
> bit the binding.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/bus/qcom,ssc-block-bus.yaml | 25 ++++++++-----------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 15:46 [PATCH] dt-bindings: bus: qcom,ssc-block-bus: rework arrays and drop redundant minItems Krzysztof Kozlowski
2022-07-18 20:24 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).