* [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of
@ 2022-07-19 7:54 Pali Rohár
2022-07-19 8:01 ` Marek Behún
2022-07-29 10:33 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2022-07-19 7:54 UTC (permalink / raw)
To: Antoine Tenart, Herbert Xu, David S. Miller, Marek Behún
Cc: linux-crypto, linux-kernel
Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
loaded on platforms where inside-secure crypto HW is specified in device
tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/crypto/inside-secure/safexcel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 9b1a158aec29..ad0d8c4a71ac 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1831,6 +1831,8 @@ static const struct of_device_id safexcel_of_match_table[] = {
{},
};
+MODULE_DEVICE_TABLE(of, safexcel_of_match_table);
+
static struct platform_driver crypto_safexcel = {
.probe = safexcel_probe,
.remove = safexcel_remove,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of
2022-07-19 7:54 [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of Pali Rohár
@ 2022-07-19 8:01 ` Marek Behún
2022-07-29 10:33 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Marek Behún @ 2022-07-19 8:01 UTC (permalink / raw)
To: Pali Rohár
Cc: Antoine Tenart, Herbert Xu, David S. Miller, linux-crypto, linux-kernel
On Tue, 19 Jul 2022 09:54:03 +0200
Pali Rohár <pali@kernel.org> wrote:
> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
>
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Rohár <pali@kernel.org>
Acked-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of
2022-07-19 7:54 [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of Pali Rohár
2022-07-19 8:01 ` Marek Behún
@ 2022-07-29 10:33 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-07-29 10:33 UTC (permalink / raw)
To: Pali Rohár
Cc: Antoine Tenart, David S. Miller, Marek Behún, linux-crypto,
linux-kernel
On Tue, Jul 19, 2022 at 09:54:03AM +0200, Pali Rohár wrote:
> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
>
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/crypto/inside-secure/safexcel.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-29 10:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 7:54 [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of Pali Rohár
2022-07-19 8:01 ` Marek Behún
2022-07-29 10:33 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).