* [PATCH] staging: r8188eu: Inserted empty line after declarations
@ 2022-07-20 16:01 Abhijeet23081989
2022-07-20 19:00 ` Pavel Skripkin
0 siblings, 1 reply; 5+ messages in thread
From: Abhijeet23081989 @ 2022-07-20 16:01 UTC (permalink / raw)
Cc: abhijeet.srivastava2308, Larry Finger, Phillip Potter,
Pavel Skripkin, Greg Kroah-Hartman, Michael Straube,
Rebecca Mckeever, Martin Kaiser, Vihas Makwana, linux-staging,
linux-kernel
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet23081989 <abhijeet.srivastava2308@gmail.com>
---
drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index 5b6a891b5d67..6fbf6e4234cf 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv)
while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
+
if (c2h && c2h != (void *)pevtpriv)
kfree(c2h);
}
@@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare ssid list */
if (ssid) {
int i;
+
for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
if (ssid[i].SsidLength) {
memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
@@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare channel list */
if (ch) {
int i;
+
for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) {
if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: Inserted empty line after declarations
2022-07-20 16:01 [PATCH] staging: r8188eu: Inserted empty line after declarations Abhijeet23081989
@ 2022-07-20 19:00 ` Pavel Skripkin
2022-07-21 3:50 ` Abhijeet Srivastava
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Skripkin @ 2022-07-20 19:00 UTC (permalink / raw)
To: Abhijeet23081989
Cc: Larry Finger, Phillip Potter, Greg Kroah-Hartman,
Michael Straube, Rebecca Mckeever, Martin Kaiser, Vihas Makwana,
linux-staging, linux-kernel
Hi Abhijeet23081989,
Abhijeet23081989 <abhijeet.srivastava2308@gmail.com> says:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet23081989 <abhijeet.srivastava2308@gmail.com>
Please use your real name as you always do when signing documents in
real life.
Patch with above S-b can't be accepted.
With regards,
Pavel Skripkin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: r8188eu: Inserted empty line after declarations
2022-07-20 19:00 ` Pavel Skripkin
@ 2022-07-21 3:50 ` Abhijeet Srivastava
2022-07-21 4:59 ` Philipp Hortmann
2022-07-21 8:15 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Abhijeet Srivastava @ 2022-07-21 3:50 UTC (permalink / raw)
Cc: abhijeet.srivastava2308, Larry Finger, Phillip Potter,
Pavel Skripkin, Greg Kroah-Hartman, Michael Straube,
Rebecca Mckeever, Martin Kaiser, Vihas Makwana, linux-staging,
linux-kernel
Warning found by checkpatch.pl script. Resending this patch after
correcting my Username
Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
---
drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index 5b6a891b5d67..6fbf6e4234cf 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv)
while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
+
if (c2h && c2h != (void *)pevtpriv)
kfree(c2h);
}
@@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare ssid list */
if (ssid) {
int i;
+
for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
if (ssid[i].SsidLength) {
memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
@@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare channel list */
if (ch) {
int i;
+
for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) {
if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: Inserted empty line after declarations
2022-07-21 3:50 ` Abhijeet Srivastava
@ 2022-07-21 4:59 ` Philipp Hortmann
2022-07-21 8:15 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Philipp Hortmann @ 2022-07-21 4:59 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Larry Finger, Phillip Potter, Pavel Skripkin, Greg Kroah-Hartman,
Michael Straube, Rebecca Mckeever, Martin Kaiser, Vihas Makwana,
linux-staging, linux-kernel
On 7/21/22 05:50, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script. Resending this patch after
> correcting my Username
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 5b6a891b5d67..6fbf6e4234cf 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv)
>
> while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
> void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
> +
> if (c2h && c2h != (void *)pevtpriv)
> kfree(c2h);
> }
> @@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
> /* prepare ssid list */
> if (ssid) {
> int i;
> +
> for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
> if (ssid[i].SsidLength) {
> memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
> @@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
> /* prepare channel list */
> if (ch) {
> int i;
> +
> for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) {
> if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
> memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));
Hi,
I am sorry to tell you that this patch is unlikely to be accepted.
Reason is that you need a [PATCH v2] subject and that the change
information needs to be below the (signed off line and the "---")
Find an example here:
https://lore.kernel.org/linux-staging/20220718021241.GA8270@cloud-MacBookPro/T/#m7a25ce1dd320c742bfb0ca0236ca06476d8dd8eb
And read about the canonical patch style.
Consider that the next version you send is not v2. Because this was v2.
The next version you can send is already v3.
Thanks for your patch. You can do it.
Bye Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: Inserted empty line after declarations
2022-07-21 3:50 ` Abhijeet Srivastava
2022-07-21 4:59 ` Philipp Hortmann
@ 2022-07-21 8:15 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-07-21 8:15 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Larry Finger, Phillip Potter, Pavel Skripkin, Greg Kroah-Hartman,
Michael Straube, Rebecca Mckeever, Martin Kaiser, Vihas Makwana,
linux-staging, linux-kernel
Put [PATCH v2] (now v3 I guess) in the subject.
On Thu, Jul 21, 2022 at 09:20:39AM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script. Resending this patch after
> correcting my Username
Don't put this stuff in the permanent git log. Put it after the ---
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
^^^
cut off here.
v2: fix my name
v3: fix commit message
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-21 8:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 16:01 [PATCH] staging: r8188eu: Inserted empty line after declarations Abhijeet23081989
2022-07-20 19:00 ` Pavel Skripkin
2022-07-21 3:50 ` Abhijeet Srivastava
2022-07-21 4:59 ` Philipp Hortmann
2022-07-21 8:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).