From: kernel test robot <lkp@intel.com>
To: Chengming Zhou <zhouchengming@bytedance.com>,
hannes@cmpxchg.org, surenb@google.com, mingo@redhat.com,
peterz@infradead.org, tj@kernel.org, corbet@lwn.net,
akpm@linux-foundation.org, rdunlap@infradead.org
Cc: kbuild-all@lists.01.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
cgroups@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH 9/9] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure
Date: Fri, 22 Jul 2022 06:10:13 +0800 [thread overview]
Message-ID: <202207220642.sbCB4Bcf-lkp@intel.com> (raw)
In-Reply-To: <20220721040439.2651-10-zhouchengming@bytedance.com>
Hi Chengming,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on akpm-mm/mm-everything linus/master v5.19-rc7]
[cannot apply to tj-cgroup/for-next next-20220721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chengming-Zhou/sched-psi-some-optimization-and-extension/20220721-120833
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 401e4963bf45c800e3e9ea0d3a0289d738005fd4
config: x86_64-randconfig-s022-20220718 (https://download.01.org/0day-ci/archive/20220722/202207220642.sbCB4Bcf-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/d14f2a9ff31fefc5b28a16addaa832dc80d84189
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chengming-Zhou/sched-psi-some-optimization-and-extension/20220721-120833
git checkout d14f2a9ff31fefc5b28a16addaa832dc80d84189
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/sched/core.c:711:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:711:31: sparse: expected struct task_struct *curr
kernel/sched/core.c:711:31: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:781:48: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:781:48: sparse: expected struct task_struct *p
kernel/sched/core.c:781:48: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:1028:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:1028:38: sparse: expected struct task_struct *curr
kernel/sched/core.c:1028:38: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:2192:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:2192:33: sparse: expected struct task_struct *p
kernel/sched/core.c:2192:33: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:2192:68: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:2192:68: sparse: expected struct task_struct *tsk
kernel/sched/core.c:2192:68: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:5376:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:5376:38: sparse: expected struct task_struct *curr
kernel/sched/core.c:5376:38: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:6322:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct task_struct *prev @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:6322:14: sparse: expected struct task_struct *prev
kernel/sched/core.c:6322:14: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:6848:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/core.c:6848:17: sparse: struct task_struct *
kernel/sched/core.c:6848:17: sparse: struct task_struct [noderef] __rcu *
kernel/sched/core.c:7064:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/core.c:7064:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/core.c:7064:22: sparse: struct task_struct *
kernel/sched/core.c:11121:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/core.c:11121:25: sparse: expected struct task_struct *p
kernel/sched/core.c:11121:25: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/core.c:537:6: sparse: sparse: context imbalance in 'raw_spin_rq_lock_nested' - wrong count at exit
kernel/sched/core.c:570:23: sparse: sparse: context imbalance in 'raw_spin_rq_trylock' - wrong count at exit
kernel/sched/core.c:586:6: sparse: sparse: context imbalance in 'raw_spin_rq_unlock' - unexpected unlock
kernel/sched/core.c:624:36: sparse: sparse: context imbalance in '__task_rq_lock' - wrong count at exit
kernel/sched/core.c:665:36: sparse: sparse: context imbalance in 'task_rq_lock' - wrong count at exit
kernel/sched/core.c:781:11: sparse: sparse: dereference of noderef expression
kernel/sched/core.c:2183:33: sparse: sparse: dereference of noderef expression
kernel/sched/core.c:2184:19: sparse: sparse: dereference of noderef expression
kernel/sched/core.c:2185:18: sparse: sparse: dereference of noderef expression
kernel/sched/core.c: note: in included file:
kernel/sched/sched.h:1592:9: sparse: sparse: context imbalance in 'ttwu_runnable' - wrong count at exit
kernel/sched/core.c:4262:9: sparse: sparse: context imbalance in 'task_call_func' - wrong count at exit
kernel/sched/sched.h:1592:9: sparse: sparse: context imbalance in 'wake_up_new_task' - wrong count at exit
kernel/sched/core.c:5035:9: sparse: sparse: context imbalance in 'finish_task_switch' - wrong count at exit
kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2053:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2053:25: sparse: struct task_struct *
kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2210:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2210:9: sparse: struct task_struct *
kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2210:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2210:9: sparse: struct task_struct *
kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2053:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2053:25: sparse: struct task_struct *
kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2210:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2210:9: sparse: struct task_struct *
kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2053:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2053:25: sparse: struct task_struct *
kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2210:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2210:9: sparse: struct task_struct *
kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2053:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2053:25: sparse: struct task_struct *
kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2210:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2210:9: sparse: struct task_struct *
kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2053:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2053:25: sparse: struct task_struct *
vim +711 kernel/sched/core.c
675
676 /*
677 * RQ-clock updating methods:
678 */
679
680 static void update_rq_clock_task(struct rq *rq, s64 delta)
681 {
682 /*
683 * In theory, the compile should just see 0 here, and optimize out the call
684 * to sched_rt_avg_update. But I don't trust it...
685 */
686 s64 __maybe_unused steal = 0, irq_delta = 0;
687
688 #ifdef CONFIG_IRQ_TIME_ACCOUNTING
689 irq_delta = irq_time_read(cpu_of(rq)) - rq->prev_irq_time;
690
691 /*
692 * Since irq_time is only updated on {soft,}irq_exit, we might run into
693 * this case when a previous update_rq_clock() happened inside a
694 * {soft,}irq region.
695 *
696 * When this happens, we stop ->clock_task and only update the
697 * prev_irq_time stamp to account for the part that fit, so that a next
698 * update will consume the rest. This ensures ->clock_task is
699 * monotonic.
700 *
701 * It does however cause some slight miss-attribution of {soft,}irq
702 * time, a more accurate solution would be to update the irq_time using
703 * the current rq->clock timestamp, except that would require using
704 * atomic ops.
705 */
706 if (irq_delta > delta)
707 irq_delta = delta;
708
709 rq->prev_irq_time += irq_delta;
710 delta -= irq_delta;
> 711 psi_account_irqtime(rq->curr, irq_delta);
712 #endif
713 #ifdef CONFIG_PARAVIRT_TIME_ACCOUNTING
714 if (static_key_false((¶virt_steal_rq_enabled))) {
715 steal = paravirt_steal_clock(cpu_of(rq));
716 steal -= rq->prev_steal_time_rq;
717
718 if (unlikely(steal > delta))
719 steal = delta;
720
721 rq->prev_steal_time_rq += steal;
722 delta -= steal;
723 }
724 #endif
725
726 rq->clock_task += delta;
727
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-21 22:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 4:04 [PATCH 0/9] sched/psi: some optimization and extension Chengming Zhou
2022-07-21 4:04 ` [PATCH 1/9] sched/psi: fix periodic aggregation shut off Chengming Zhou
2022-07-25 15:34 ` Johannes Weiner
2022-07-25 15:39 ` Johannes Weiner
2022-07-26 13:28 ` Chengming Zhou
2022-07-21 4:04 ` [PATCH 2/9] sched/psi: optimize task switch inside shared cgroups again Chengming Zhou
2022-07-21 4:04 ` [PATCH 3/9] sched/psi: move private helpers to sched/stats.h Chengming Zhou
2022-07-25 16:39 ` Johannes Weiner
2022-07-21 4:04 ` [PATCH 4/9] sched/psi: don't change task psi_flags when migrate CPU/group Chengming Zhou
2022-07-21 4:04 ` [PATCH 5/9] sched/psi: don't create cgroup PSI files when psi_disabled Chengming Zhou
2022-07-25 16:41 ` Johannes Weiner
2022-07-21 4:04 ` [PATCH 6/9] sched/psi: save percpu memory when !psi_cgroups_enabled Chengming Zhou
2022-07-25 16:47 ` Johannes Weiner
2022-07-21 4:04 ` [PATCH 7/9] sched/psi: cache parent psi_group to speed up groups iterate Chengming Zhou
2022-07-21 4:04 ` [PATCH 8/9] sched/psi: add kernel cmdline parameter psi_inner_cgroup Chengming Zhou
2022-07-25 16:52 ` Johannes Weiner
2022-07-26 13:38 ` [External] " Chengming Zhou
2022-07-26 17:54 ` Tejun Heo
2022-08-03 12:17 ` Chengming Zhou
2022-08-03 17:58 ` Tejun Heo
2022-08-03 19:22 ` Johannes Weiner
2022-08-03 19:48 ` Tejun Heo
2022-08-04 13:51 ` Chengming Zhou
2022-08-04 16:56 ` Johannes Weiner
2022-08-04 2:02 ` Chengming Zhou
2022-07-21 4:04 ` [PATCH 9/9] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure Chengming Zhou
2022-07-21 10:00 ` kernel test robot
2022-07-21 22:10 ` kernel test robot [this message]
2022-07-22 3:30 ` Abel Wu
2022-07-22 6:13 ` Chengming Zhou
2022-07-22 7:14 ` Abel Wu
2022-07-22 7:33 ` Chengming Zhou
2022-07-25 18:26 ` Johannes Weiner
2022-07-26 13:55 ` [External] " Chengming Zhou
2022-07-27 11:28 ` Chengming Zhou
2022-07-27 13:00 ` Johannes Weiner
2022-07-27 15:09 ` Chengming Zhou
2022-07-27 16:07 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207220642.sbCB4Bcf-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).