* [PATCH v2] usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop
@ 2022-07-26 19:57 Wesley Cheng
0 siblings, 0 replies; only message in thread
From: Wesley Cheng @ 2022-07-26 19:57 UTC (permalink / raw)
To: balbi, gregkh
Cc: linux-kernel, linux-usb, quic_jackp, quic_mrana, Thinh.Nguyen,
Wesley Cheng
Relocate the pullups_connected check until after it is ensured that there
are no runtime PM transitions. If another context triggered the DWC3
core's runtime resume, it may have already enabled the Run/Stop. Do not
re-run the entire pullup sequence again, as it may issue a core soft
reset while Run/Stop is already set.
This patch depends on
commit 69e131d1ac4e ("usb: dwc3: gadget: Prevent repeat pullup()")
Fixes: 77adb8bdf422 ("usb: dwc3: gadget: Allow runtime suspend if UDC
unbinded")
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
drivers/usb/dwc3/gadget.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index aeeec751c53c..67b1039c664c 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2539,9 +2539,6 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
is_on = !!is_on;
- if (dwc->pullups_connected == is_on)
- return 0;
-
dwc->softconnect = is_on;
/*
@@ -2566,6 +2563,9 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
return 0;
}
+ if (dwc->pullups_connected == is_on)
+ return 0;
+
if (!is_on) {
ret = dwc3_gadget_soft_disconnect(dwc);
} else {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-26 19:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 19:57 [PATCH v2] usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop Wesley Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).