* [PATCH] dma-mapping: Reformat comment to suppress htmldoc warning
@ 2022-07-27 19:15 Logan Gunthorpe
2022-07-28 14:21 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Logan Gunthorpe @ 2022-07-27 19:15 UTC (permalink / raw)
To: Christoph Hellwig
Cc: iommu, Linux Kernel Mailing List, Linux Next Mailing List,
Stephen Rothwell, Logan Gunthorpe
make html doc reports a cryptic warning with the commit named below:
kernel/dma/mapping.c:258: WARNING: Option list ends without a blank
line; unexpected unindent.
Seems the parser is a bit fussy about the tabbing and having a single
space tab causes the warning. To suppress the warning add another
tab to the list and reindent everything.
Fixes: 7c2645a2a30a ("dma-mapping: allow EREMOTEIO return code for P2PDMA transfers")
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
kernel/dma/mapping.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index a9ce5d728231..49cbf3e33de7 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -249,15 +249,15 @@ EXPORT_SYMBOL(dma_map_sg_attrs);
* Returns 0 on success or a negative error code on error. The following
* error codes are supported with the given meaning:
*
- * -EINVAL An invalid argument, unaligned access or other error
- * in usage. Will not succeed if retried.
- * -ENOMEM Insufficient resources (like memory or IOVA space) to
- * complete the mapping. Should succeed if retried later.
- * -EIO Legacy error code with an unknown meaning. eg. this is
- * returned if a lower level call returned DMA_MAPPING_ERROR.
- * -EREMOTEIO The DMA device cannot access P2PDMA memory specified in
- * the sg_table. This will not succeed if retried.
- *
+ * -EINVAL An invalid argument, unaligned access or other error
+ * in usage. Will not succeed if retried.
+ * -ENOMEM Insufficient resources (like memory or IOVA space) to
+ * complete the mapping. Should succeed if retried later.
+ * -EIO Legacy error code with an unknown meaning. eg. this is
+ * returned if a lower level call returned
+ * DMA_MAPPING_ERROR.
+ * -EREMOTEIO The DMA device cannot access P2PDMA memory specified
+ * in the sg_table. This will not succeed if retried.
*/
int dma_map_sgtable(struct device *dev, struct sg_table *sgt,
enum dma_data_direction dir, unsigned long attrs)
base-commit: 0d06132fc84bd91379300768c75a19474e06d0c5
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-mapping: Reformat comment to suppress htmldoc warning
2022-07-27 19:15 [PATCH] dma-mapping: Reformat comment to suppress htmldoc warning Logan Gunthorpe
@ 2022-07-28 14:21 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-07-28 14:21 UTC (permalink / raw)
To: Logan Gunthorpe
Cc: Christoph Hellwig, iommu, Linux Kernel Mailing List,
Linux Next Mailing List, Stephen Rothwell
Thanks,
applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 19:15 [PATCH] dma-mapping: Reformat comment to suppress htmldoc warning Logan Gunthorpe
2022-07-28 14:21 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).