* [PATCH v2] rtc: rtc-spear: set range max
@ 2022-07-28 10:01 Zeng Jingxiang
2022-07-28 10:02 ` Viresh Kumar
2022-08-09 11:47 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Zeng Jingxiang @ 2022-07-28 10:01 UTC (permalink / raw)
To: a.zummo, alexandre.belloni
Cc: linux-rtc, linux-kernel, viresh.kumar, Zeng Jingxiang
From: Zeng Jingxiang <linuszeng@tencent.com>
In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
("rtc: spear: set range"), the value of
RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;
Fixes: f395e1d3b28d ("rtc: spear: set range")
Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---
Change in v2:
- Add fixes tag
drivers/rtc/rtc-spear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index d4777b01ab22..736fe535cd45 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
config->rtc->ops = &spear_rtc_ops;
config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
- config->rtc->range_min = RTC_TIMESTAMP_END_9999;
+ config->rtc->range_max = RTC_TIMESTAMP_END_9999;
status = devm_rtc_register_device(config->rtc);
if (status)
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtc: rtc-spear: set range max
2022-07-28 10:01 [PATCH v2] rtc: rtc-spear: set range max Zeng Jingxiang
@ 2022-07-28 10:02 ` Viresh Kumar
2022-08-09 11:47 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2022-07-28 10:02 UTC (permalink / raw)
To: Zeng Jingxiang
Cc: a.zummo, alexandre.belloni, linux-rtc, linux-kernel, Zeng Jingxiang
On 28-07-22, 18:01, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
>
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> Fixes: f395e1d3b28d ("rtc: spear: set range")
> Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>
> Change in v2:
> - Add fixes tag
>
> drivers/rtc/rtc-spear.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index d4777b01ab22..736fe535cd45 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
>
> config->rtc->ops = &spear_rtc_ops;
> config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> - config->rtc->range_min = RTC_TIMESTAMP_END_9999;
> + config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> status = devm_rtc_register_device(config->rtc);
> if (status)
> --
> 2.27.0
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtc: rtc-spear: set range max
2022-07-28 10:01 [PATCH v2] rtc: rtc-spear: set range max Zeng Jingxiang
2022-07-28 10:02 ` Viresh Kumar
@ 2022-08-09 11:47 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2022-08-09 11:47 UTC (permalink / raw)
To: a.zummo, zengjx95; +Cc: linuszeng, linux-kernel, linux-rtc, Viresh Kumar
On Thu, 28 Jul 2022 18:01:01 +0800, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
>
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390 config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391 config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>
> [...]
Applied, thanks!
[1/1] rtc: rtc-spear: set range max
commit: 03c4cd6f89e074a51e289eb9129ac646f0f2bd29
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-09 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 10:01 [PATCH v2] rtc: rtc-spear: set range max Zeng Jingxiang
2022-07-28 10:02 ` Viresh Kumar
2022-08-09 11:47 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).