* [PATCH] proc: remove initialization assignment
@ 2022-08-01 8:51 Li zeming
2022-09-08 23:40 ` Luis Chamberlain
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2022-08-01 8:51 UTC (permalink / raw)
To: mcgrof, keescook, yzaikin; +Cc: linux-kernel, linux-fsdevel, Li zeming
The allocation address of the core_parent pointer variable is first
executed in the function, no initialization assignment is required.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
fs/proc/proc_sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 021e83fe831f..50ba9e4fb284 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -1246,7 +1246,7 @@ static bool get_links(struct ctl_dir *dir,
static int insert_links(struct ctl_table_header *head)
{
struct ctl_table_set *root_set = &sysctl_table_root.default_set;
- struct ctl_dir *core_parent = NULL;
+ struct ctl_dir *core_parent;
struct ctl_table_header *links;
int err;
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] proc: remove initialization assignment
2022-08-01 8:51 [PATCH] proc: remove initialization assignment Li zeming
@ 2022-09-08 23:40 ` Luis Chamberlain
0 siblings, 0 replies; 2+ messages in thread
From: Luis Chamberlain @ 2022-09-08 23:40 UTC (permalink / raw)
To: Li zeming; +Cc: keescook, yzaikin, linux-kernel, linux-fsdevel
On Mon, Aug 01, 2022 at 04:51:17PM +0800, Li zeming wrote:
> The allocation address of the core_parent pointer variable is first
> executed in the function, no initialization assignment is required.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Thanks!
Queued up for sysctl-testing, if that comes back without issues, I'll
move it to sysctl-next.
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-08 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 8:51 [PATCH] proc: remove initialization assignment Li zeming
2022-09-08 23:40 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).