* [PATCH] dt-bindings: remove the dead code in cmd_mk_schema
@ 2022-07-29 5:21 Masahiro Yamada
2022-08-01 15:12 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2022-07-29 5:21 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, devicetree
Cc: Masahiro Yamada, Geert Uytterhoeven, Krzysztof Kozlowski,
Nathan Chancellor, Sam Protsenko, linux-kernel
Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to
dt-validate"), the processed schema takes all the YAML files.
Remove the dead code.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Documentation/devicetree/bindings/Makefile | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index c9953f86b19d..223df2a023fd 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT $@
quiet_cmd_mk_schema = SCHEMA $@
cmd_mk_schema = f=$$(mktemp) ; \
- $(if $(DT_MK_SCHEMA_FLAGS), \
- printf '%s\n' $(real-prereqs), \
- $(find_all_cmd)) > $$f ; \
- $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
+ $(find_all_cmd) > $$f ; \
+ $(DT_MK_SCHEMA) -j @$$f > $@ ; \
rm -f $$f
define rule_chkdt
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: remove the dead code in cmd_mk_schema
2022-07-29 5:21 [PATCH] dt-bindings: remove the dead code in cmd_mk_schema Masahiro Yamada
@ 2022-08-01 15:12 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-08-01 15:12 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Frank Rowand, devicetree, Geert Uytterhoeven,
Krzysztof Kozlowski, Nathan Chancellor, Sam Protsenko,
linux-kernel
On Fri, Jul 29, 2022 at 02:21:12PM +0900, Masahiro Yamada wrote:
> Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to
> dt-validate"), the processed schema takes all the YAML files.
>
> Remove the dead code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Documentation/devicetree/bindings/Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
I also sent out a similar patch[1].
>
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index c9953f86b19d..223df2a023fd 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT $@
>
> quiet_cmd_mk_schema = SCHEMA $@
> cmd_mk_schema = f=$$(mktemp) ; \
> - $(if $(DT_MK_SCHEMA_FLAGS), \
> - printf '%s\n' $(real-prereqs), \
> - $(find_all_cmd)) > $$f ; \
> - $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
> + $(find_all_cmd) > $$f ; \
> + $(DT_MK_SCHEMA) -j @$$f > $@ ; \
I want to keep DT_MK_SCHEMA_FLAGS because I'm working on a new optional
flag to pass.
Rob
[1] https://lore.kernel.org/all/20220727211100.3249417-1-robh@kernel.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-01 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 5:21 [PATCH] dt-bindings: remove the dead code in cmd_mk_schema Masahiro Yamada
2022-08-01 15:12 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).