From: Pankaj Raghav <p.raghav@samsung.com>
To: Johannes.Thumshirn@wdc.com, snitzer@kernel.org, axboe@kernel.dk,
damien.lemoal@opensource.wdc.com, agk@redhat.com, hch@lst.de
Cc: dm-devel@redhat.com, matias.bjorling@wdc.com,
gost.dev@samsung.com, linux-kernel@vger.kernel.org,
pankydev8@gmail.com, jaegeuk@kernel.org, hare@suse.de,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
bvanassche@acm.org, Pankaj Raghav <p.raghav@samsung.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v9 07/13] zonefs: allow non power of 2 zoned devices
Date: Wed, 3 Aug 2022 11:47:55 +0200 [thread overview]
Message-ID: <20220803094801.177490-8-p.raghav@samsung.com> (raw)
In-Reply-To: <20220803094801.177490-1-p.raghav@samsung.com>
The zone size shift variable is useful only if the zone sizes are known
to be power of 2. Remove that variable and use generic helpers from
block layer to calculate zone index in zonefs.
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
fs/zonefs/super.c | 6 ++----
fs/zonefs/zonefs.h | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 860f0b1032c6..e549ef16738c 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -476,10 +476,9 @@ static void __zonefs_io_error(struct inode *inode, bool write)
{
struct zonefs_inode_info *zi = ZONEFS_I(inode);
struct super_block *sb = inode->i_sb;
- struct zonefs_sb_info *sbi = ZONEFS_SB(sb);
unsigned int noio_flag;
unsigned int nr_zones =
- zi->i_zone_size >> (sbi->s_zone_sectors_shift + SECTOR_SHIFT);
+ bdev_zone_no(sb->s_bdev, zi->i_zone_size >> SECTOR_SHIFT);
struct zonefs_ioerr_data err = {
.inode = inode,
.write = write,
@@ -1401,7 +1400,7 @@ static int zonefs_init_file_inode(struct inode *inode, struct blk_zone *zone,
struct zonefs_inode_info *zi = ZONEFS_I(inode);
int ret = 0;
- inode->i_ino = zone->start >> sbi->s_zone_sectors_shift;
+ inode->i_ino = bdev_zone_no(sb->s_bdev, zone->start);
inode->i_mode = S_IFREG | sbi->s_perm;
zi->i_ztype = type;
@@ -1776,7 +1775,6 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)
* interface constraints.
*/
sb_set_blocksize(sb, bdev_zone_write_granularity(sb->s_bdev));
- sbi->s_zone_sectors_shift = ilog2(bdev_zone_sectors(sb->s_bdev));
sbi->s_uid = GLOBAL_ROOT_UID;
sbi->s_gid = GLOBAL_ROOT_GID;
sbi->s_perm = 0640;
diff --git a/fs/zonefs/zonefs.h b/fs/zonefs/zonefs.h
index 4b3de66c3233..39895195cda6 100644
--- a/fs/zonefs/zonefs.h
+++ b/fs/zonefs/zonefs.h
@@ -177,7 +177,6 @@ struct zonefs_sb_info {
kgid_t s_gid;
umode_t s_perm;
uuid_t s_uuid;
- unsigned int s_zone_sectors_shift;
unsigned int s_nr_files[ZONEFS_ZTYPE_MAX];
--
2.25.1
next prev parent reply other threads:[~2022-08-03 9:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220803094802eucas1p2052b092c7bd82bea1a0ac4a5d70d7bc9@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
[not found] ` <CGME20220803094803eucas1p2ee8d16f3b6e08203ac9b4e0df6f53d9d@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
[not found] ` <CGME20220803094804eucas1p1feea4b1bdae819f4c8750994ddd94803@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-03 17:11 ` [dm-devel] [PATCH v9 02/13] block:rearrange bdev_{is_zoned, zone_sectors, get_queue} " Bart Van Assche
2022-08-10 16:50 ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} " Damien Le Moal
[not found] ` <CGME20220803094805eucas1p1c68ba40d319331c2c34059f966ba2d83@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-08-03 17:18 ` [dm-devel] " Bart Van Assche
2022-08-10 17:03 ` Damien Le Moal
2022-08-11 13:13 ` Pankaj Raghav
[not found] ` <CGME20220803094806eucas1p24e1fd0f3a595e050d79c4315559d97ae@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-08-10 17:04 ` Damien Le Moal
[not found] ` <CGME20220803094808eucas1p1a6a800161d32fe4242d39e669e5f3527@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-03 17:22 ` [dm-devel] " Bart Van Assche
2022-08-04 7:29 ` Pankaj Raghav
[not found] ` <CGME20220803094809eucas1p1e24ddc3076eaa05db0658b88fd34ffd4@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
[not found] ` <CGME20220803094810eucas1p1304a82ba94d0265c3f6a8a371e5127a7@eucas1p1.samsung.com>
2022-08-03 9:47 ` Pankaj Raghav [this message]
[not found] ` <CGME20220803094811eucas1p17a2ac191899bba7938de6b9e3a55352f@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-08-10 17:10 ` Damien Le Moal
[not found] ` <CGME20220803094812eucas1p271cea804453d9dd379b919067fe5b154@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-08-03 17:23 ` Bart Van Assche
[not found] ` <CGME20220803094813eucas1p2eab78901e97417ad52be1f8023db3d82@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-03 17:24 ` [dm-devel] " Bart Van Assche
2022-08-10 17:12 ` Damien Le Moal
[not found] ` <CGME20220803094814eucas1p2789149466d095cc16710ee09a380cbdb@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
[not found] ` <CGME20220803094815eucas1p2dfab477daf4f2eb05342d756fdf7f14d@eucas1p2.samsung.com>
2022-08-03 9:48 ` [PATCH v9 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
2022-08-10 17:16 ` Damien Le Moal
[not found] ` <CGME20220803094816eucas1p1890ceb4faebaf4f0cdbc9581d1308672@eucas1p1.samsung.com>
2022-08-03 9:48 ` [PATCH v9 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-10 12:24 ` Joel Granados
2022-08-10 17:31 ` Damien Le Moal
2022-08-11 13:17 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803094801.177490-8-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=mcgrof@kernel.org \
--cc=pankydev8@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).