From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Pankaj Raghav <p.raghav@samsung.com>,
Johannes.Thumshirn@wdc.com, snitzer@kernel.org, axboe@kernel.dk,
agk@redhat.com, hch@lst.de
Cc: dm-devel@redhat.com, matias.bjorling@wdc.com,
gost.dev@samsung.com, linux-kernel@vger.kernel.org,
pankydev8@gmail.com, jaegeuk@kernel.org, hare@suse.de,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
bvanassche@acm.org
Subject: Re: [PATCH v9 12/13] dm: introduce DM_EMULATED_ZONES target type
Date: Wed, 10 Aug 2022 10:16:42 -0700 [thread overview]
Message-ID: <3ee96421-94b2-12d8-9aa2-83d4f7027694@opensource.wdc.com> (raw)
In-Reply-To: <20220803094801.177490-13-p.raghav@samsung.com>
On 2022/08/03 2:48, Pankaj Raghav wrote:
> Introduce a new target type DM_EMULATED_ZONES for targets with
> a different zone number of sectors than the underlying device zone
> number of sectors.
"zone number of sectors" is strange. "number of sectors per zone (aka zone
size)" is simpler and clear.
>
> This target type is introduced as the existing zoned targets assume
> that the target and the underlying device have the same zone
> number of sectors. The new target: dm-po2zone will use this new target
> type as it emulates the zone boundary that is different from the
> underlying zoned device.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
With that text fixed, looks OK to me.
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/md/dm-table.c | 13 ++++++++++---
> include/linux/device-mapper.h | 9 +++++++++
> 2 files changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 31eb1d29d136..b37991ea3ffb 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -1614,13 +1614,20 @@ static bool dm_table_supports_zoned_model(struct dm_table *t,
> return true;
> }
>
> -static int device_not_matches_zone_sectors(struct dm_target *ti, struct dm_dev *dev,
> +/*
> + * Callback function to check for device zone sector across devices. If the
> + * DM_TARGET_EMULATED_ZONES target feature flag is not set, then the target
> + * should have the same zone sector as the underlying devices.
> + */
> +static int check_valid_device_zone_sectors(struct dm_target *ti, struct dm_dev *dev,
> sector_t start, sector_t len, void *data)
> {
> unsigned int *zone_sectors = data;
>
> - if (!bdev_is_zoned(dev->bdev))
> + if (!bdev_is_zoned(dev->bdev) ||
> + dm_target_supports_emulated_zones(ti->type))
> return 0;
> +
> return bdev_zone_sectors(dev->bdev) != *zone_sectors;
> }
>
> @@ -1645,7 +1652,7 @@ static int validate_hardware_zoned_model(struct dm_table *t,
> if (!zone_sectors)
> return -EINVAL;
>
> - if (dm_table_any_dev_attr(t, device_not_matches_zone_sectors, &zone_sectors)) {
> + if (dm_table_any_dev_attr(t, check_valid_device_zone_sectors, &zone_sectors)) {
> DMERR("%s: zone sectors is not consistent across all zoned devices",
> dm_device_name(t->md));
> return -EINVAL;
> diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
> index 04c6acf7faaa..83e20de264c9 100644
> --- a/include/linux/device-mapper.h
> +++ b/include/linux/device-mapper.h
> @@ -294,6 +294,15 @@ struct target_type {
> #define dm_target_supports_mixed_zoned_model(type) (false)
> #endif
>
> +#ifdef CONFIG_BLK_DEV_ZONED
> +#define DM_TARGET_EMULATED_ZONES 0x00000400
> +#define dm_target_supports_emulated_zones(type) \
> + ((type)->features & DM_TARGET_EMULATED_ZONES)
> +#else
> +#define DM_TARGET_EMULATED_ZONES 0x00000000
> +#define dm_target_supports_emulated_zones(type) (false)
> +#endif
> +
> struct dm_target {
> struct dm_table *table;
> struct target_type *type;
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-08-10 17:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220803094802eucas1p2052b092c7bd82bea1a0ac4a5d70d7bc9@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
[not found] ` <CGME20220803094803eucas1p2ee8d16f3b6e08203ac9b4e0df6f53d9d@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
[not found] ` <CGME20220803094804eucas1p1feea4b1bdae819f4c8750994ddd94803@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-03 17:11 ` [dm-devel] [PATCH v9 02/13] block:rearrange bdev_{is_zoned, zone_sectors, get_queue} " Bart Van Assche
2022-08-10 16:50 ` [PATCH v9 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} " Damien Le Moal
[not found] ` <CGME20220803094805eucas1p1c68ba40d319331c2c34059f966ba2d83@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-08-03 17:18 ` [dm-devel] " Bart Van Assche
2022-08-10 17:03 ` Damien Le Moal
2022-08-11 13:13 ` Pankaj Raghav
[not found] ` <CGME20220803094806eucas1p24e1fd0f3a595e050d79c4315559d97ae@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-08-10 17:04 ` Damien Le Moal
[not found] ` <CGME20220803094808eucas1p1a6a800161d32fe4242d39e669e5f3527@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-03 17:22 ` [dm-devel] " Bart Van Assche
2022-08-04 7:29 ` Pankaj Raghav
[not found] ` <CGME20220803094809eucas1p1e24ddc3076eaa05db0658b88fd34ffd4@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
[not found] ` <CGME20220803094810eucas1p1304a82ba94d0265c3f6a8a371e5127a7@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
[not found] ` <CGME20220803094811eucas1p17a2ac191899bba7938de6b9e3a55352f@eucas1p1.samsung.com>
2022-08-03 9:47 ` [PATCH v9 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-08-10 17:10 ` Damien Le Moal
[not found] ` <CGME20220803094812eucas1p271cea804453d9dd379b919067fe5b154@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-08-03 17:23 ` Bart Van Assche
[not found] ` <CGME20220803094813eucas1p2eab78901e97417ad52be1f8023db3d82@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-03 17:24 ` [dm-devel] " Bart Van Assche
2022-08-10 17:12 ` Damien Le Moal
[not found] ` <CGME20220803094814eucas1p2789149466d095cc16710ee09a380cbdb@eucas1p2.samsung.com>
2022-08-03 9:47 ` [PATCH v9 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
[not found] ` <CGME20220803094815eucas1p2dfab477daf4f2eb05342d756fdf7f14d@eucas1p2.samsung.com>
2022-08-03 9:48 ` [PATCH v9 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
2022-08-10 17:16 ` Damien Le Moal [this message]
[not found] ` <CGME20220803094816eucas1p1890ceb4faebaf4f0cdbc9581d1308672@eucas1p1.samsung.com>
2022-08-03 9:48 ` [PATCH v9 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-10 12:24 ` Joel Granados
2022-08-10 17:31 ` Damien Le Moal
2022-08-11 13:17 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee96421-94b2-12d8-9aa2-83d4f7027694@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).