* [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1)
@ 2022-08-04 9:27 Krzysztof Kozlowski
2022-08-08 1:36 ` Andrew Jeffery
2022-10-18 13:32 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-04 9:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Cc: Krzysztof Kozlowski
Due to copy-paste, the ast2600-evb and ast2600-evb-a1 got the same
compatible. Drop the '-a1' suffix from the first to match what is
expected by bindings.
Fixes: aa5e06208500 ("ARM: dts: ast2600-evb: fix board compatible")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index c698e6538269..2010e3cb6158 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -8,7 +8,7 @@
/ {
model = "AST2600 EVB";
- compatible = "aspeed,ast2600-evb-a1", "aspeed,ast2600";
+ compatible = "aspeed,ast2600-evb", "aspeed,ast2600";
aliases {
serial4 = &uart5;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1)
2022-08-04 9:27 [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1) Krzysztof Kozlowski
@ 2022-08-08 1:36 ` Andrew Jeffery
2022-10-18 13:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2022-08-08 1:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel
On Thu, 4 Aug 2022, at 18:57, Krzysztof Kozlowski wrote:
> Due to copy-paste, the ast2600-evb and ast2600-evb-a1 got the same
> compatible. Drop the '-a1' suffix from the first to match what is
> expected by bindings.
>
> Fixes: aa5e06208500 ("ARM: dts: ast2600-evb: fix board compatible")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1)
2022-08-04 9:27 [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1) Krzysztof Kozlowski
2022-08-08 1:36 ` Andrew Jeffery
@ 2022-10-18 13:32 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-18 13:32 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Arnd Bergmann
On 04/08/2022 05:27, Krzysztof Kozlowski wrote:
> Due to copy-paste, the ast2600-evb and ast2600-evb-a1 got the same
> compatible. Drop the '-a1' suffix from the first to match what is
> expected by bindings.
>
> Fixes: aa5e06208500 ("ARM: dts: ast2600-evb: fix board compatible")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index c698e6538269..2010e3cb6158 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -8,7 +8,7 @@
>
> / {
> model = "AST2600 EVB";
> - compatible = "aspeed,ast2600-evb-a1", "aspeed,ast2600";
> + compatible = "aspeed,ast2600-evb", "aspeed,ast2600";
This is weird. I sent this patch on 4th August but it was never
applied... yet instead I see a commit in mainline from end of September:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d916109169159f9319f45ce7e1339e41eccf22c4
which was never sent to mailing list.
So instead of picking up existing commit from mailing list waiting there
for 1.5 months, Joel just committed something without sharing in public way.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-18 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 9:27 [PATCH] ARM: dts: ast2600-evb: correct compatible (drop -a1) Krzysztof Kozlowski
2022-08-08 1:36 ` Andrew Jeffery
2022-10-18 13:32 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).